Re: [dev] [st] compilation warnings/errors

2022-11-12 Thread NRK
On Sun, Nov 13, 2022 at 09:46:00AM +0600, Enan Ajmain wrote: > But if you're asking why the Makefile of st doesn't use these flags by > default then I think the makefile is supposed to be used by the end user > and the user should not be required to deal with warnings. Unless they > want to, in

Re: [dev] [st] compilation warnings/errors

2022-11-12 Thread Enan Ajmain
On Sat, 12 Nov 2022 19:56:17 + ShellCode wrote: > So it made me wonder, what are your thoughts on passing -Werror by > default to the compiler ? And what about -Wall and -Wextra ? I think these warnings are valuable indicators of potential bugs and the devs should pay close attention to

[dev] [st] compilation warnings/errors

2022-11-12 Thread ShellCode
Hey everyone, I started using st (thanks a lot for your work by the way) and applied some patches. When I applied the externalpipe patch, and recompiled st, I noticed some warnings were emitted by my compiler. I'm not a 100% sure (i'm not familiar with this code) but I feel like there's a bug