[dev] [st] Removing timeouts in main loop

2012-09-16 Thread Roberto E. Vargas Caballero
This serie of patches try fix the problem of the timeout in main loop, which causes st wakeup each 20 ms even thare is noting to do. Please send comments and suggestion. Best regards. From 48aac423ea93820f8a406da3f4e53c8ce4bcb2a6 Mon Sep 17 00:00:00 2001 From: Roberto E. Vargas Caballero

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread stanio
* Roberto E. Vargas Caballero k...@shike2.com [2012-09-16 09:48]: The main loop waits until there is some data to read in file descriptors of the X server or the pseudo tty. But it uses a timeout in select(), which causes that st awake each 20 ms, even it doesn't have something to do. This

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Aurélien Aptel
On Sun, Sep 16, 2012 at 9:47 AM, Roberto E. Vargas Caballero k...@shike2.com wrote: This serie of patches try fix the problem of the timeout in main loop, which causes st wakeup each 20 ms even thare is noting to do. The timeout problem was introduced to speed up the rendering when a lot of

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Aurélien Aptel
On Sun, Sep 16, 2012 at 11:51 AM, Aurélien Aptel aurelien.ap...@gmail.com wrote: - try to read data for SELECT_TIMEOUT ms max - if something was read, handle it in the term - if something was read and the last call to draw was more than DRAW_TIMEOUT ms ago then redraw. In retrospect, the

Re: [dev] [st] New patches

2012-09-16 Thread Aurélien Aptel
I'm not exactly sure what this feature will be used for. If you want to script something around a program expecting to run in a term there are already better tools for that like expect [1]. I'm not the one who added this goal. On Wed, Sep 12, 2012 at 8:22 PM, Roberto E. Vargas Caballero

Re: [dev] [st] New patches

2012-09-16 Thread Roberto E. Vargas Caballero
On Sun, Sep 16, 2012 at 12:33:34PM +0200, Aurélien Aptel wrote: I'm not exactly sure what this feature will be used for. If you want to script something around a program expecting to run in a term there are already better tools for that like expect [1]. I'm not the one who added this goal.

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Roberto E. Vargas Caballero
The timeout problem was introduced to speed up the rendering when a lot of text is printed. The logic is basically to not redraw on every read when the throughput is high: I tried do the same thing putting the draw at the end of the loop, so if you have a high throughput you will read more

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Roberto E. Vargas Caballero
Maybe a way to improve my patches is testing is some data can be read from the file descriptors and in this case continue the loop. something like: if(i++ 4) { struct timeval tv = {0}; FD_ZERO(rfd); FD_SET(cmdfd, rfd);

Re: [dev] [st] New patches

2012-09-16 Thread Roberto E. Vargas Caballero
If the only use is to debug it shouldn't be exposed to users and it's I only implemented a goal of the project (I don't know who insert that goal to) that was very useful for me. doesn't need to be fast. Besides there's already a dump() function you can modify/use. There is also this great

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 12:26:21 +0200 Aurélien Aptel aurelien.ap...@gmail.com wrote: On Sun, Sep 16, 2012 at 9:47 AM, Roberto E. Vargas Caballero k...@shike2.com wrote: This serie of patches try fix the problem of the timeout in main loop, which causes st wakeup each 20 ms even thare

Re: [dev] [st] New patches

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 13:34:18 +0200 Aurélien Aptel aurelien.ap...@gmail.com wrote: On Sun, Sep 16, 2012 at 12:38 PM, Roberto E. Vargas Caballero k...@shike2.com wrote: Main use of this feature (actually) is only helping to debug. When you are debugging escape sequences is very useful

[dev] [st] small fix after draw() changes

2012-09-16 Thread Roberto E. Vargas Caballero
I forgot this small change. From dda44edaafd907e96080db2257842d0a796f8d19 Mon Sep 17 00:00:00 2001 From: Roberto E. Vargas Caballero k...@shike2.com Date: Sun, 16 Sep 2012 13:50:13 +0200 Subject: [PATCH] Remove call to draw in resize In previous commits draw was removed from all the X events, but

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Aurélien Aptel
On Sun, Sep 16, 2012 at 12:26 PM, Christoph Lohmann 2...@r-36.net wrote: If there is something to read from the tty, handle it, then wait for five microseconds in select() and see if the buffer filled again. If yes, handle this and do it again. After a certain amount of such loops

Re: [dev] [st] Removing timeouts in main loop

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 14:00:44 +0200 Aurélien Aptel aurelien.ap...@gmail.com wrote: On Sun, Sep 16, 2012 at 12:26 PM, Christoph Lohmann 2...@r-36.net wrote: If there is something to read from the tty, handle it, then wait for five microseconds in select() and see if the buffer

Re: [dev] [st] New patches

2012-09-16 Thread Nick
Quoth Christoph Lohmann: The ‐f switch allows easy recording of st sessions and so is useful to the users. It would be a useful feature for me, acting as a kind of easier to deal with scrollback thing, for when there's a good deal of text that flew by, that I need to read, or copy elsewhere

Re: [dev] [st] New patches

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 17:18:07 +0200 Nick suckless-...@njw.me.uk wrote: Quoth Christoph Lohmann: The ‐f switch allows easy recording of st sessions and so is useful to the users. It would be a useful feature for me, acting as a kind of easier to deal with scrollback thing, for

Re: [dev] [st] New patches

2012-09-16 Thread Nick
Quoth Christoph Lohmann: On Sun, 16 Sep 2012 17:18:07 +0200 Nick suckless-...@njw.me.uk wrote: Quoth Christoph Lohmann: The ‐f switch allows easy recording of st sessions and so is useful to the users. It would be a useful feature for me, acting as a kind of easier to deal

Re: [dev] [st] New patches

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 19:08:01 +0200 Nick suckless-...@njw.me.uk wrote: Quoth Christoph Lohmann: On Sun, 16 Sep 2012 17:18:07 +0200 Nick suckless-...@njw.me.uk wrote: Quoth Christoph Lohmann: The ‐f switch allows easy recording of st sessions and so is useful to the users.

Re: [dev] [st] New patches

2012-09-16 Thread Roberto E. Vargas Caballero
The ???f switch allows easy recording of st sessions and so is useful to the users. Thinking a bit about it, it is true that you can get the session using 'script -f', and it is not necessary insert this feature inside of st.

Re: [dev] [st] New patches

2012-09-16 Thread Christoph Lohmann
Hello. On Sun, 16 Sep 2012 20:45:13 +0200 Roberto E. Vargas Caballero k...@shike2.com wrote: The ???f switch allows easy recording of st sessions and so is useful to the users. Thinking a bit about it, it is true that you can get the session using 'script -f', and it is not

Re: [dev] [st] New patches

2012-09-16 Thread Roberto E. Vargas Caballero
As said on IRC: I really like the convenience of st -f - | cat -v Doing it manually over a fifo is tiresome when I want to do fast debug??? ging. Well, you can use a named pipe and script -f, cat -v. But I think this is too much complex, and the cost of -f option is minimum and don't