Re: [dev] [dwm] Style changes

2015-04-10 Thread Roberto E. Vargas Caballero
Well, it would be identified as such, so you just go to the commit before that. In the end, this is a very weak argument. If you change the style early enough, the succeeding history will be fine. And when you go to the previous commit, you discover that it was another style change and you

Re: [dev] [st] [PATCH 2/2] Simplify window mapping loop.

2015-04-10 Thread Roberto E. Vargas Caballero
XFilterEvent usually filters KeyPress events that are hooked by input method, but at this point the window is not mapped so it is impossible to press keys in the terminal. Calling XFilterEvent would only be useful if input methods filtered ConfigureNotify or MapNotify events. I don't think

Re: [dev] [st] [PATCH 2/2] Simplify window mapping loop.

2015-04-10 Thread noname
On Fri, Apr 10, 2015 at 05:41:16PM +0200, Roberto E. Vargas Caballero wrote: - if(XFilterEvent(ev, None)) - continue; Why are you removing the call to XFilterEvent here? XFilterEvent usually filters KeyPress events that are hooked by input method, but at this

Re: [dev] [dwm] Style changes

2015-04-10 Thread Aaron Burrow
If we're going to fix a bunch of formatting problems we should make sure the problem doesn't resurface. Put a commit hook on the git server that either validates formatting or does auto-formatting. On Fri, Apr 10, 2015 at 2:40 PM, Daniel Martí mv...@mvdan.cc wrote: On Fri, Apr 10, 2015 at