Re: [dev] [PATCH][st] Refactor the innermost loop of the xdraws function

2014-06-07 Thread Christoph Lohmann
Greetings. On Sat, 07 Jun 2014 08:46:37 +0200 FRIGN d...@frign.de wrote: On Fri, 06 Jun 2014 21:27:33 +0200 Christoph Lohmann 2...@r-36.net wrote: This will introduce the notion that gotos are allowed. Won’t be applied. A refactoring without goto would be applied. What's the problem

Re: [dev] [PATCH][st] Refactor the innermost loop of the xdraws function

2014-06-07 Thread FRIGN
On Fri, 6 Jun 2014 17:12:15 -0700 Charlie Kester corky1...@comcast.net wrote: In fairness to the Java fanatics, prohibitions against goto's predate Java by many years. Dijkstra's letter Go To Statement Considered Harmful was published in 1968, while the Java project wasn't begun until 1991.

Re: [dev] [PATCH][st] Refactor the innermost loop of the xdraws function

2014-06-07 Thread Roberto E. Vargas Caballero
Still doesn't deny the fact goto has powers you never have with if-statements. It can be misused (of course), but if handled well, it is definitely a great tool to handle errors for instance (no need to Yes, it is a very good example of a goto usage, but I think the patch was about something

Re: [dev] [PATCH][st] Refactor the innermost loop of the xdraws function

2014-06-07 Thread Christoph Lohmann
Greetings. On Sat, 07 Jun 2014 11:27:40 +0200 Roberto E. Vargas Caballero k...@shike2.com wrote: However, I agree with Christoph that this topic and debate are very old. Let's focus on more relevant stuff instead and do some work ;). Yeah, I totally agree with you. Christoph, are you

[dev] [st] [PATCH] Refactor xdraws()

2014-06-07 Thread FRIGN
Hello, this has been bugging me for a while now, given the confusing logic at the beginning of xdraws() didn't really invite going on. This patch removes 13 lines and additionally makes the code much easier to read. Cheers FRIGN -- FRIGN d...@frign.de From

[dev] [st] [PATCH 2] Refactor xdraws() - Episode II

2014-06-07 Thread FRIGN
Just use one RenderColor-object. We don't need a round-trip. Stay tuned for Episode III. ;) -- FRIGN d...@frign.de From 48205a6cd122717671f051209b8d1a73c4c5e2f4 Mon Sep 17 00:00:00 2001 From: FRIGN d...@frign.de Date: Sat, 7 Jun 2014 18:55:20 +0200 Subject: [PATCH] Refactor xdraws() - Episode