Re: [dev] [st] [PATCH 4/3] tresize: remove unnecessary if

2015-04-15 Thread Omar Sandoval
On Tue, Apr 14, 2015 at 04:39:44PM +0100, Dimitris Papastamos wrote: On Tue, Apr 14, 2015 at 04:33:56PM +0100, Connor Lane Smith wrote: On 14 April 2015 at 13:50, Dimitris Papastamos s...@2f30.org wrote: dst and src are required to be valid objects even if n is 0, otherwise this is

Re: [dev] [PATCH st] Make DECSCUSR thickness configurable

2015-04-15 Thread Omar Sandoval
On Fri, Apr 10, 2015 at 05:44:45PM +0200, Roberto E. Vargas Caballero wrote: Applied with small style change. Thanks. Regards, Ah, I was going by the surrounding style in the function and didn't realize that it was wrong ;) Anyways, thanks! -- Omar

Re: [dev] [st] [PATCH 4/3] tresize: remove unnecessary if

2015-04-15 Thread Roberto E. Vargas Caballero
This should be reverted. Yeah, I agree. I also think we should put some comment saying that if i == 0 then it is possible to have some of the undefined cases where src == NULL || dst == NULL || src == dst. Some volunter to write the patch?

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

2015-04-15 Thread Nick
Quoth tauto...@gmail.com: The disk cache is disabled by default, so it is probably not an issue. If someone enables it, it is their decision. Actually the disk cache is enabled by default; it's set to true in config.def.h

Re: [dev] [vis] [PATCH] Fix handling of file load errors

2015-04-15 Thread Marc André Tanner
On Tue, Apr 14, 2015 at 05:25:15PM +0200, Willem van de Krol wrote: This fixes a segmentation fault when opening a directory. Also, opening a file you are not permitted to read, will now give an error, instead of showing the file as empty. Yes this needs improving, however your patch breaks

Re: [dev] [st] [PATCH 4/3] tresize: remove unnecessary if

2015-04-15 Thread Dimitris Papastamos
See attached patch. From f6c18450a99875647d85f633fef00e72a0c1577b Mon Sep 17 00:00:00 2001 From: sin s...@2f30.org Date: Wed, 15 Apr 2015 09:43:06 +0100 Subject: [PATCH] Fix memmove() invocation with src/dst being NULL This fixes a segmentation fault on some systems. --- st.c | 7 +-- 1 file

Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

2015-04-15 Thread tautolog
You are right, Nick. My patch had left it enabled. It looks like nearly everything is enabled by default. ‎ Tomorrow, or whenever I can get to it, I will submit a new patch derived from yours that uses the version testing macro, and submit the unstable hack as a patch to the website, unless

Re: [dev] [vis] [PATCH] Highlight null directive.

2015-04-15 Thread Marc André Tanner
Thanks, applied! -- Marc André Tanner http://www.brain-dump.org/ GPG key: CF7D56C0