, orig, term.col-1, orig+n-1);
tsetdirt(orig+n, term.bot);
Is there any reason to do it in different order?. I think is more
understable if the order is the same in both cases.
Regards,
--
Roberto E. Vargas Caballero
Hi,
I am going to apply the full set of patches. Thanks!!
--
Roberto E. Vargas Caballero
it.
Regards,
--
Roberto E. Vargas Caballero
Applied with a small modification. Thanks
--
Roberto E. Vargas Caballero
dirty bit is set.
Regards,
--
Roberto E. Vargas Caballero
criteria, that is the
more suck criteria I know (I think it is because they come from the
LISP world, and they want to see your code formatted as LISP, and
force you to put a lot of unneded parenthesis ;).
Regards,
--
Roberto E. Vargas Caballero
rule. I accept typedef of struct always
that the new type begins with upper case.
--
Roberto E. Vargas Caballero
will apply it.
Regards,
--
Roberto E. Vargas Caballero
Applied, thanks!
--
Roberto E. Vargas Caballero
The large and repeated expression used in memmove to indirect
the line can be simplified using a pointer, that makes more
clear where begins and where ends the movement.
---
st.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/st.c b/st.c
index 263abaa..e468d73
Hi,
It makes sense with the rest of the code, so I'll apply it.
Regards,
--
Roberto E. Vargas Caballero
- if(sel.alt ^ IS_SET(MODE_ALTSCREEN))
+ if(sel.alt != IS_SET(MODE_ALTSCREEN))
This bit logical operation comes from another age when IS_SET
had not a comparision operator. It does not make sense anymore, so
this change is good.
Regards,
--
Roberto E. Vargas Caballero
,
--
Roberto E. Vargas Caballero
Currently the alternate screen get messed up on resize if it has
different colors or mode.
Good catch, I'll apply it.
Regards,
--
Roberto E. Vargas Caballero
and they are not a second version.
--
Roberto E. Vargas Caballero
- * As seen in selcopy:
+ * As seen in getsel:
Good catch, I'll apply it.
Regards,
--
Roberto E. Vargas Caballero
, so I think the solution is
to remove the function.
Regards,
--
Roberto E. Vargas Caballero
that the best comment is FALLTHROUGH (I used FALLTHRU
in the past because it was used in a project where I worked), that is
the comment that lint understand.
Regards,
--
Roberto E. Vargas Caballero
can
agree on it, I'll write the patch to add break;s for the last switch-cases,
where they are missing.
Yeah, I agree, and I am going to commit the patch of nonamed only with the
break in the beginnig of the switch.
Regards,
--
Roberto E. Vargas Caballero
- case 'P': /* DSC -- Device Control String */
+ case 'P': /* DCS -- Device Control String */
I begin to think that you have a very good eyes, because we didn't realise
this stupid typo. Thanks!!!
--
Roberto E. Vargas Caballero
Applied to, thanks!!!
--
Roberto E. Vargas Caballero
, control sequence, or device control string in
progress.
So I understand CAN should also cancel the sequence.
I am going to apply your patch, but I am going to write a patch serie
for the rest of cases.
Regards,
[1] http://www.vt100.net/docs/vt510-rm/chapter4
--
Roberto E
From http://www.vt100.net/docs/vt510-rm/chapter4:
*The VT510 ignores all following characters until it receives a
SUB, ST, or any other C1 control character.
So OSC, PM and APC sequence ends with a SUB (it cancels the sequence
and show a question mark as error), ST or any
From http://www.vt100.net/docs/vt510-rm/chapter4:
*The VT510 ignores all following characters until it receives a
SUB, ST, or any other C1 control character.
So OSC, PM and APC sequence ends with a SUB (it cancels the sequence
and show a question mark as error), ST or any
,
(uchar) ascii, isprint(ascii)?
ascii:'.');
term.esc = 0;
+ break;
}
}
/*
--
1.8.3.2
--
Roberto E. Vargas Caballero
From http://www.vt100.net/docs/vt510-rm/chapter4:
*The VT510 ignores all following characters until it receives a
SUB, ST, or any other C1 control character.
So OSC, PM and APC sequence ends with a SUB (it cancels the sequence
and show a question mark as error), ST or any
---
st.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/st.c b/st.c
index 339d8a9..470a34e 100644
--- a/st.c
+++ b/st.c
@@ -2450,6 +2450,7 @@ tputc(char *c, int len) {
bool control;
long unicodep;
int width;
+ Glyph *gp;
I'll apply it, thanks.
--
Roberto E. Vargas Caballero
I'll apply it, thanks.
--
Roberto E. Vargas Caballero
I'll apply it, thanks.
--
Roberto E. Vargas Caballero
I think instead of removing the return value, we should check
the value returned, and in case of not being possible the resize
command then print a warning in stderr.
Regards,
--
Roberto E. Vargas Caballero
it is implementation defined
when side effects of expressions are applied, so x of !term.tabs[x] can
be x before decrement, or x after decrement.
Regards,
--
Roberto E. Vargas Caballero
that are in the range of
C0 are wrong drawn. I will look also this problem.
--
Roberto E. Vargas Caballero
with sequences.
*/
if(control) {
- if (tcontrolcode(ascii))
+ if (tcontrolcode(unicodep))
return;
} else if(term.esc ESC_START) {
if(term.esc ESC_CSI) {
--
Roberto E. Vargas Caballero
{
term.c.state |= CURSOR_WRAPNEXT;
}
but you also can find:
if(xwrite(cmdfd, s, n) == -1)
die(write error on tty: %s\n, strerror(errno));
So, is it mandatory parenthesis in one line if? I don't know it.
Regards,
--
Roberto E. Vargas Caballero
+ while(frclen 0)
+ XftFontClose(xw.dpy, frc[--frclen].font);
I'll apply the patch.
--
Roberto E. Vargas Caballero
repository). Sorry
for delay, but I have too much reviewing job lately.
Regards,
--
Roberto E. Vargas Caballero
Applied, thanks
--
Roberto E. Vargas Caballero
If you select rectangle, then y should be between first and last line
and x should between first and last column.
As nobody, except you, have answer, I have applied the patch.
--
Roberto E. Vargas Caballero
term.trantbl[term.icharset] = vcs[p - cs];
}
I think it is a common implementation for this kind of problems.
Regards,
--
Roberto E. Vargas Caballero
Otherwise, the rest of the input is interpreted as a new escape
sequence.
For the ESC character, ESC_START is re-set in tcontrolcode.
Good catch, I'll apply it (and sorry for this error ;)).
Regards,
--
Roberto E. Vargas Caballero
The strhandle() in the case '\\' below (line 2565) couldn’t be reached.
I think this patch is incorrect, because '\\' doesn't end a string command.
ESC \ ends it. Let me know if I am wrong.
--
Roberto E. Vargas Caballero
+ term.esc = ~(ESC_STR_END|ESC_STR);
Shouldn’t these flags be cleared only on SUB, CAN, ST, C1s and \a ?
You are right. There are some 'break' that should be a return.
Regards,
--
Roberto E. Vargas Caballero
), do you remember why you removed
tfulldirt in 0dbf9c?
--
Roberto E. Vargas Caballero
blow proccess.
Regards,
--
Roberto E. Vargas Caballero
Yes, and it says use at your own risk. Possibly because that update
only fixed compilation problems on current platforms.
It is also said in all the GNU programs, did you read the GPL?
Regards,
--
Roberto E. Vargas Caballero
Fine. Sorry. But i still doubt that implementation to be a reasonable
choice:
http://www.cs.princeton.edu/~bwk/btl.mirror/index.html
I wanted to remark that your assertion about awk authors and awk is not true
(you know, k of awk comes from Kernighan).
Regards,
--
Roberto E. Vargas
to avoid
these bloated versions.
From our point of view an implementation of awk with 6 lines is a
really horrible implementation, and it is one of the next candidates for
sbase.
--
Roberto E. Vargas Caballero
plumber and plan9's awk for me i might chime in and help you.
Yes, it is really useful for st for example. St can write selected
areas to stdout using PrintScr, so using a plumber with it can be
a really good idea. Did you test it?
--
Roberto E. Vargas Caballero
fetchmail and procmail
both the TX and RX sides are over an ipsec tunnel.
I use this solution to. I like the approach of fetchmail, that inserts my
pop3 and imap into the local mail system.
--
Roberto E. Vargas Caballero
A recursive descent parser is probably sufficient.
I have written a lot of recursive descent parsers (even one of C language),
but I prefer yacc for mini languages.
--
Roberto E. Vargas Caballero
. Probably my fault. Please share and enlighten us.
It can be useful, for example, select the name a file in the terminal and
launch an application that show you the content of the file, or you select
an url and want to see it a web navigator. I think is the common usage
of a plumber, no?
--
Roberto E
away again. You never feel caged in your
plumber setup? What am i missing?
I'm sorry, but I don't understand your question or where you are missed.
--
Roberto E. Vargas Caballero
I'm answering you in private, because I don't want to generate more
noise in the list. I have some problems reading your mail (I think we have
some understanding problem, maybe my english is not good enough).
I'm a asshole, I didn't remove the CC line. Sorry people.
--
Roberto E. Vargas
to duplicate this functionality in all the programs.
Regards,
--
Roberto E. Vargas Caballero
, but it is the only thing we can do if
we want multisession in terminals.
--
Roberto E. Vargas Caballero
interesting point.
--
Roberto E. Vargas Caballero
Is this a bug or deliberate design decision?
A bug, presumably.
Yes, I agree. The copy part could be improved a lot, because we have some
problems with it now (for example the tab to space conversion is ugly).
--
Roberto E. Vargas Caballero
. Or better, try to find
a solution to this problem that another suckless develepers would
like to accept.
Regards,
--
Roberto E. Vargas Caballero
it could be implemented.
Regards,
--
Roberto E. Vargas Caballero
systems I only use st, but I have to use another systems (some of
them a bit legacy) where I use another terminals.
--
Roberto E. Vargas Caballero
it
in the FAQ.
Regards.
[0] http://lists.suckless.org/dev/1404/20697.html
--
Roberto E. Vargas Caballero
This patch (and anothers from nonamed) is waiting a reply from nonamed.
If in the next days there is not a reply I will apply the modifications
that I considerer better.
Regards,
--
Roberto E. Vargas Caballero
please notice me about it.
Thanks,
--
Roberto E. Vargas Caballero
This patch makes sense to me, so I'll apply it unless someone has a problem
with it.
Regards,
--
Roberto E. Vargas Caballero
This patch conflicts with your previous patch, so I think there is
some kind of error here, isn't it?
Regards,
--
Roberto E. Vargas Caballero
it.
Thanks.
--
Roberto E. Vargas Caballero
in another part of the system.
--
Roberto E. Vargas Caballero
be applied today (there is also a technical paper, but
the novel is really good and less boring ;)).
Regards,
--
Roberto E. Vargas Caballero
[1], which explains how some guys defeated
apache.org server long, long time ago. Very good.
Regards,
[1]
http://archives.neohapsis.com/archives/php/2000-05/att-0030/51-how_defaced_apache_org.txt
--
Roberto E. Vargas Caballero
Yeah, I made this so that it apply cleanly on the head but forgot to
rebase it on my other patch. Here is the fixed version, sorry!
Applied, thanks!
--
Roberto E. Vargas Caballero
+ !strchr(worddelimiters,
term.line[*y+1][0].c[0])) {
The same here.
Maybe the use of to allow sequential code in a 'if' is not a good idea,
and maybe some refactoring could be done here to avoid so long lines and
the ugly sequential .
--
Roberto E. Vargas
The code was assuming that empty lines have implicit wrap-around attribute.
Was this issue considered a bug after all?
Yes, and the patch was applied in 2411308bd.
Regards.
--
Roberto E. Vargas Caballero
:01 2014 +0200
Refactor selsnap SNAP_WORD.
Refactor the SNAP_WORD part in selsnap, and fix a bug that caused the word
delimiters to be ignored if it was at the very beginning or end of a wrapped
line.
Signed-off-by: Roberto E. Vargas Caballero k...@shike2.com
diff
: error: redefinition of typedef 'Colormap'
/usr/X11R6/include/X11/X.h:104: error: previous declaration of 'Colormap'
was here
I had the same problem. I have just removed the typedef.
Yeah, the same here. I am going to apply the patch of FRIGN.
Regards,
--
Roberto E. Vargas Caballero
Yeah, you’re right, yours is definitely better, I’m totally fine with
it!
Applied!
--
Roberto E. Vargas Caballero
totally agree with you. Christoph, are you going to apply the
revised version of the patch?
Regards,
--
Roberto E. Vargas Caballero
This fixes 2 small typos in the FAQ.
Applied,
--
Roberto E. Vargas Caballero
?
Regards,
--
Roberto E. Vargas Caballero
On font zooming (i.e. xzoom()), window size hints are not updated. This
patch does that.
Applied, thanks!
--
Roberto E. Vargas Caballero
While you’re at it, line 140:
- * Be careful with the order of the definitons because st searchs in
+ * Be careful with the order of the definitions because st searches in
I will apply the first patch with this addition.
--
Roberto E. Vargas Caballero
,
--
Roberto E. Vargas Caballero
of the commit was Eric Pruitt, so if he send
again the patch with this version of CEIL I will commit it.
Regards,
--
Roberto E. Vargas Caballero
CEIL(x) ((int)(x) + ((x) 0 ((x) - (int)(x)) FLT_EPSILON))
This solution begins to be too much complex. In this case I begin to
agree with Martti, and I think the best solution is to use ceil.
Regards,
--
Roberto E. Vargas Caballero
work for solving our stupid code.
Regards,
--
Roberto E. Vargas Caballero
,
--
Roberto E. Vargas Caballero
words or for getting bold characters.
Regards,
--
Roberto E. Vargas Caballero
if it does with this patch, but,
well, it's at least a conversation piece.
I totally agree with you. The main loop is one of the aspect of st that
need more work.
Regards,
--
Roberto E. Vargas Caballero
This is not good practice[0], given gettimeofday is inaccurate for this
matter (take time-jumps for instance). POSIX.1-2008 even marks it as
obsolete!
I agree with you and I like the patch. If nobody have problems with
it I will apply it.
Regards,
--
Roberto E. Vargas Caballero
of another terminal,
so I am not sure if it is a good idea to have two different
blinking speeds or to have only one.
Regards,
--
Roberto E. Vargas Caballero
complaint about
use ceilf I will apply my proposal.
Regards,
--
Roberto E. Vargas Caballero
I will apply this patch. Even if we don't implement at the end any
difference between fast and slow blinking, I think is a good idea at least
have different bits for them. The same criteria apply to faint, struck
and invisible bits.
Regards,
--
Roberto E. Vargas Caballero
The implementation is far simple, so I think it is a good idea apply
this patch. Are you sure that is not there any terminfo capability
related to this feature? I am not sure, but I think there is one.
--
Roberto E. Vargas Caballero
, so forget all my previous comments about
struck. I like the idea and I will apply the patch (as it is common I'll
wait some days to allow people complaint if they disagree with the patch)
--
Roberto E. Vargas Caballero
of the code (colors), so I think he should take the decision about it.
Regards,
--
Roberto E. Vargas Caballero
that if you use a symbolic name
(for example default_cols or default_rows), because they are values
that directly indicate me they are related to the default number of
columns and rows.
Regards,
--
Roberto E. Vargas Caballero
underscore for names (I am not an maniatic about it,
but there is a style police that catch all the fails!).
Regards,
--
Roberto E. Vargas Caballero
NEL version for 7 bits environments already was implemented in st.
This patch adds the 8 bit version of it.
---
st.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/st.c b/st.c
index 4813524..85e1e0f 100644
--- a/st.c
+++ b/st.c
@@ -2412,7 +2412,9 @@ tcontrolcode(uchar
DCS, APC, PM, OSC version for 7 bits environments already was implemented
in st. This patch adds the 8 bit version of it.
---
st.c | 39 ---
1 file changed, 32 insertions(+), 7 deletions(-)
diff --git a/st.c b/st.c
index e4fab61..982f0f6 100644
--- a/st.c
+++
DECID version for 7 bits environments already was implemented in st.
This patch adds the 8 bit version of it.
---
st.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/st.c b/st.c
index f8f262a..4813524 100644
--- a/st.c
+++ b/st.c
@@ -2419,7 +2419,9 @@ tcontrolcode(uchar
301 - 400 of 700 matches
Mail list logo
