Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Страхиња Радић
On 23/10/29 08:49PM, Markus Wichmann wrote: > Am Sun, Oct 29, 2023 at 06:00:18PM +0100 schrieb Страхиња Радић: > > mkdir returning EISDIR is definitely not a part of POSIX.[1] > > > > [1]: > > https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkdir.html#tag_16_325_05 > > That's where

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Markus Wichmann
Am Sun, Oct 29, 2023 at 06:00:18PM +0100 schrieb Страхиња Радић: > mkdir returning EISDIR is definitely not a part of POSIX.[1] > > [1]: > https://pubs.opengroup.org/onlinepubs/9699919799/functions/mkdir.html#tag_16_325_05 That's where you're wrong. Any function can fail for any reason unless

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Страхиња Радић
On 23/10/29 07:59AM, Randy Palamar wrote: > > Plus I didn't know mkdir could fail with EISDIR. My manpage is not > > documenting that case. > > It's probably legacy nonsense or from some obscure platform that I > noticed when checking other implementations [0]. mkdir returning EISDIR is

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Randy Palamar
> That is one of the jobs of the -p switch to mkdir. However, without -p, > mkdir is not allowed to ignore failure like that. Once I looked in more detail I realized that was the case so I didn't send the patch. It was not how I previously thought about the -p switch though. > Plus I didn't know

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Rene Kita
On Sun, Oct 29, 2023 at 10:58:26AM +0100, Quentin Rameau wrote: > I pushed a patch to hackers@, you can test it and confirm that fixes > the issue, thanks! Works now, thanks!

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Quentin Rameau
Hi Rene, > I can't find the patch in the mail archives, but git://git.suckless.org/sbase > has commit ddde8021 (Simplify install/uninstall). With this commit > trying to install gives the following result: > > % make install > scripts/mkproto install /usr/local /usr/local/share/man proto >

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-29 Thread Markus Wichmann
Am Sat, Oct 28, 2023 at 01:48:07PM -0600 schrieb Randy Palamar: > This is a problem with mkdir in sbase. It probably shouldn't error out > when mkdir(3p) fails and sets errno to EEXIST or EISDIR. I'll send a > patch to hackers@ soon. > > - Randy > That is one of the jobs of the -p switch to

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-28 Thread Randy Palamar
> scripts/mkproto: 15: cannot create /usr/local/share/man: Is a directory Actually, looking at it again this is just a problem in the makefile. scripts/mkproto has too many args. Though fixing that exposes a separate issue with the way `find` is being invoked. - Randy

Re: [dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-28 Thread Randy Palamar
Hi, > scripts/mkproto: 15: cannot create /usr/local/share/man: Is a directory This is a problem with mkdir in sbase. It probably shouldn't error out when mkdir(3p) fails and sets errno to EEXIST or EISDIR. I'll send a patch to hackers@ soon. - Randy

[dev] [Bug][sbase] make install borked since commit ddde8021

2023-10-28 Thread Rene Kita
I can't find the patch in the mail archives, but git://git.suckless.org/sbase has commit ddde8021 (Simplify install/uninstall). With this commit trying to install gives the following result: % make install scripts/mkproto install /usr/local /usr/local/share/man proto scripts/mkproto: 15: cannot