Re: [dev] [PATCH] Add RGB color definition

2013-07-20 Thread Alexander Sedov
2013/7/19 Roberto E. Vargas Caballero k...@shike2.com: From: Roberto E. Vargas Caballero k...@shike2.com It is impossible allocate all the RGB colors using a static array, so it is necessary move DC.col into a pointer and use dinamic memory. Since the color definition is not used to much is

Re: [dev] [PATCH] Add RGB color definition

2013-07-20 Thread Roberto E. Vargas Caballero
I disapprove of this patch, since it does not work the way advertised. Particularly, added colors can be palette-swapped with another sequence. Also, replacing static memory with malloc() feels dirty. I don't see how you can swapped them, and I agree with you that the malloc can be a big

[dev] [PATCH] Add RGB color definition

2013-07-19 Thread Roberto E. Vargas Caballero
From: Roberto E. Vargas Caballero k...@shike2.com It is impossible allocate all the RGB colors using a static array, so it is necessary move DC.col into a pointer and use dinamic memory. Since the color definition is not used to much is not a bad idea use realloc each time. It means the color