Re: [dev] [sbase] [patch v2] Add strings(1)

2013-08-15 Thread Roberto E. Vargas Caballero
+ buf[i] = '\0'; + printf(%8ld: %s\n, (long)offset - i - 1, buf); I can see you are also printing the offset of the string in the file. It seems a bit strange to me, when by default strings output format is only the string detected [1],

Re: [dev] [sbase] [patch v2] Add strings(1)

2013-08-15 Thread sin
On Thu, Aug 15, 2013 at 10:44:51AM +0200, Roberto E. Vargas Caballero wrote: + buf[i] = '\0'; + printf(%8ld: %s\n, (long)offset - i - 1, buf); I can see you are also printing the offset of the string in the file. It seems a bit strange

Re: [dev] [sbase] [patch v2] Add strings(1)

2013-08-15 Thread Roberto E. Vargas Caballero
Yeah I should have mentioned, my implementation mirrors strings from Plan9. My understanding is that sbase is not necessarily posix compliant. Personally I'm used to this implementation. If you guys think it makes more sense to switch to the standard output then I can do that. We should

[dev] [sbase] [patch v2] Add strings(1)

2013-08-14 Thread sin
Hi, Fixed to use libc I/O. No manpage yet. David, what you think of my other id(1) patch? Thanks, sin From 520d7a64cd2c40c1c63ce7ea1d954b5efb166c98 Mon Sep 17 00:00:00 2001 From: sin s...@2f30.org Date: Wed, 14 Aug 2013 10:41:55 +0100 Subject: [PATCH] Add strings(1) --- Makefile | 1 +