Re: [dev] [st PATCH] Simplify tdeftran.

2014-06-02 Thread Roberto E. Vargas Caballero
This patch (and anothers from nonamed) is waiting a reply from nonamed. If in the next days there is not a reply I will apply the modifications that I considerer better. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] Simplify tdeftran.

2014-05-02 Thread Roberto E. Vargas Caballero
Idea behind tdeftran is allowing to users create new charsets if they want, and it is the reason why it is built as a data driven function. I don't think is a good idea implement a lookup table using a switch statement, but it is true that it can be written better. What do you think about this