Re: [dev] [st patch queue 05/12] Consistent FALLTHROUGH comments.

2014-04-30 Thread noname
On Fri, Apr 25, 2014 at 06:21:10PM +0200, Roberto E. Vargas Caballero wrote: It is true that it is ugly to have different styles in fall through, but it is also true that we have a lot of fall through where we don't put any comment. Put a comment in all these places is a very bad idea, but I

[dev] [st patch queue 05/12] Consistent FALLTHROUGH comments.

2014-04-25 Thread noname
--- st.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/st.c b/st.c index fd342aa..dae23c5 100644 --- a/st.c +++ b/st.c @@ -1839,7 +1839,7 @@ tsetmode(bool priv, bool set, int *args, int narg) { if (!allowaltscreen)

Re: [dev] [st patch queue 05/12] Consistent FALLTHROUGH comments.

2014-04-25 Thread Roberto E. Vargas Caballero
It is true that it is ugly to have different styles in fall through, but it is also true that we have a lot of fall through where we don't put any comment. Put a comment in all these places is a very bad idea, but I think maybe there are more places where we should put a comment. I agree with you