[dev] [st patch queue 07/12] Remove unnecessary break;s

2014-04-25 Thread noname
--- st.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/st.c b/st.c index 9de7f81..061dafd 100644 --- a/st.c +++ b/st.c @@ -1778,7 +1778,6 @@ tsetmode(bool priv, bool set, int *args, int narg) { for(lim = args + narg; args lim; ++args) { if(priv) {

Re: [dev] [st patch queue 07/12] Remove unnecessary break;s

2014-04-25 Thread Markus Teich
noname wrote: @@ -1897,7 +1896,6 @@ tsetmode(bool priv, bool set, int *args, int narg) { fprintf(stderr, erresc: unknown set/reset mode %d\n, *args); - break;

Re: [dev] [st patch queue 07/12] Remove unnecessary break;s

2014-04-25 Thread Roberto E. Vargas Caballero
although a break statement in the last case is unnecessary, I think it should be left there. If someone appends a new case, he could forget to break this one and get an unwanted fallthrough. The style in st.c is not consistent, there are multiple places without the break in the last case