Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Maxime Beauchemin
+1 On Thu, Nov 8, 2018 at 3:53 PM John Bodley wrote: > +1 > > > On Nov 8, 2018, at 3:05 PM, Grace Guo > wrote: > > > > +1 > > > > - Grace > > > > > >> On Nov 8, 2018, at 10:59 AM, Krist Wongsuphasawat < > krist.wo...@gmail.com> wrote: > >> > >> Hi dev@superset, > >> > >> I would like to call a

Regarding [SIP-3] Scheduled email reports for Slices / Dashboards

2018-11-08 Thread Abhishek Sarangan
Greetings Superset Supers, Apologies if this is a question that's been asked repeatedly, but would the PR for SIP-3: Scheduled email reports be merged anytime soon? We at Oath have been using Superset for the past two years, and our users have been recently asking for the email functionality,

Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread John Bodley
+1 > On Nov 8, 2018, at 3:05 PM, Grace Guo wrote: > > +1 > > - Grace > > >> On Nov 8, 2018, at 10:59 AM, Krist Wongsuphasawat >> wrote: >> >> Hi dev@superset, >> >> I would like to call a vote on *SIP-13: Proposal for Code Review Process*. >> >> The proposal details and discussion can be found

Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Grace Guo
+1 - Grace > On Nov 8, 2018, at 10:59 AM, Krist Wongsuphasawat > wrote: > > Hi dev@superset, > > I would like to call a vote on *SIP-13: Proposal for Code Review Process*. > > The proposal details and discussion can be found here. > https://github.com/apache/incubator-superset/issues/6132

Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Timi Fasubaa
+1 On Thu, Nov 8, 2018 at 1:15 PM Chris Williams wrote: > +1 > > Chris > > Data Visualization > San Francisco > > > On Thu, Nov 8, 2018 at 11:04 AM Krist Wongsuphasawat < > krist.wo...@gmail.com> > wrote: > > > Hi dev@superset, > > > > I would like to call a vote on *SIP-13: Proposal for Code

Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Eli Brumbaugh
+1 On Thu, Nov 8, 2018 at 1:15 PM Chris Williams wrote: > +1 > > Chris > > Data Visualization > San Francisco > > > On Thu, Nov 8, 2018 at 11:04 AM Krist Wongsuphasawat < > krist.wo...@gmail.com> > wrote: > > > Hi dev@superset, > > > > I would like to call a vote on *SIP-13: Proposal for Code

[Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Krist Wongsuphasawat
Hi dev@superset, I would like to call a vote on *SIP-13: Proposal for Code Review Process*. The proposal details and discussion can be found here. https://github.com/apache/incubator-superset/issues/6132 One small modification from the original proposal is I have dropped the stale branch check.

Re: [Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Chris Williams
+1 Chris Data Visualization San Francisco On Thu, Nov 8, 2018 at 11:04 AM Krist Wongsuphasawat wrote: > Hi dev@superset, > > I would like to call a vote on *SIP-13: Proposal for Code Review Process*. > > The proposal details and discussion can be found here. >

[Vote] SIP-13: Proposal for Code Review Process

2018-11-08 Thread Krist Wongsuphasawat
Hi dev@superset, I would like to call a vote on *SIP-13: Proposal for Code Review Process*. The proposal details and discussion can be found here. https://github.com/apache/incubator-superset/issues/6132 One small modification from the original proposal is I have dropped the stale branch check.