[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228460 ## File path: superset/viz.py ## @@ -1693,6 +1693,8 @@ def run_extra_queries(self):

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181227743 ## File path: superset/connectors/base/models.py ## @@ -185,6 +186,34 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228586 ## File path: tests/druid_func_tests.py ## @@ -119,14 +119,15 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228549 ## File path: tests/druid_func_tests.py ## @@ -119,14 +119,15 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228300 ## File path: superset/connectors/druid/models.py ## @@ -1322,40 +1339,30 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228386 ## File path: superset/connectors/sqla/models.py ## @@ -565,28 +564,20 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181227279 ## File path: superset/connectors/base/models.py ## @@ -185,6 +186,34 @@ def

[GitHub] betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and ''

betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228007 ## File path: superset/connectors/base/models.py ## @@ -185,6 +186,34 @@ def