hughhhh commented on a change in pull request #4572: Legend for deck.gl
scatterplot
URL:
https://github.com/apache/incubator-superset/pull/4572#discussion_r173236890
##########
File path: superset/assets/visualizations/Legend.jsx
##########
@@ -0,0 +1,42 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+ categories: PropTypes.object,
+ toggleCategory: PropTypes.func,
+};
+
+const defaultProps = {
+ categories: {},
+ toggleCategory: () => {},
+};
+
+export default class Legend extends React.PureComponent {
Review comment:
Can we name this `MapLegend` or do you seeing this being extended to all
visualizations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
