jeffreythewang opened a new pull request #4520: Allow users to view dashboards 
they own
URL: https://github.com/apache/incubator-superset/pull/4520
 
 
   This change allows users to see the dashboards they own listed in the 
dashboard list. Previously, users could only see dashboards in the list if the 
dashboard contained at least 1 chart that they have access to. This means that 
a user cannot find their dashboard in the list if they create an empty 
dashboard (either by mistake, or as a blank template to start adding charts).
   
   For the case where they are the owner of a dashboard, but their dashboard 
has charts they do not have access to (which can only happen if an additional 
owner adds an inaccessible chart to the dashboard), they will be prompted with 
the request access error. I think this is okay, as it is the same behavior as 
when a user has access to some but not all charts in a dashboard. Feel free to 
comment otherwise, and I can add an additional check for this to be applied to 
empty dashboards only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to