[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-08 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-379573029 @mistercrunch per our conversation last week, I updated `CONTRIBUTING.md` regarding maintaining `setup.py` and

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-08 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-379573029 @mistercrunch per our conversation last week, I updated CONTRIBUTING.md regarding maintaining setup.py and

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-05 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files (though your hypothesis seems

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-05 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files and I can explore pipenv,

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-05 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378831814 @mistercrunch I definitely explored the `pip-compile` route as it would be great to have `requirements.txt`

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-04 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378790730 @mistercrunch sorry I was wondering what your thoughts were on this? Additionally having a `requirements.txt` with

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-03-23 Thread GitBox
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-375824124 @mistercrunch @betodealmeida per the conservation regarding pinning earlier today what are your thoughts on this