mistercrunch closed pull request #4358: [druid] fix bug around handling NULLs
URL: https://github.com/apache/incubator-superset/pull/4358
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index 6fc8cf9887..c50027627c 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -68,10 +68,10 @@ def __init__(self, datasource, form_data):
self.status = None
self.error_message = None
- def get_fillna_for_type(self, col_type):
+ def get_fillna_for_col(self, col):
"""Returns the value for use as filler for a specific Column.type"""
- if col_type:
- if col_type == 'TEXT' or col_type.startswith('VARCHAR'):
+ if col:
+ if col.is_string:
return ' NULL'
return self.default_fillna
@@ -79,8 +79,11 @@ def get_fillna_for_columns(self, columns=None):
"""Returns a dict or scalar that can be passed to DataFrame.fillna"""
if columns is None:
return self.default_fillna
- columns_types = self.datasource.columns_types
- fillna = {c: self.get_fillna_for_type(columns_types.get(c)) for c in
columns}
+ columns_dict = {col.column_name: col for col in
self.datasource.columns}
+ fillna = {
+ c: self.get_fillna_for_col(columns_dict.get(c))
+ for c in columns
+ }
return fillna
def get_df(self, query_obj=None):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
