[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-27 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177569264 ## File path: superset/cli.py ## @@ -28,7 +28,8 @@ @manager.command

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-27 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177510468 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177290855 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177290855 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177267268 ## File path: superset/__init__.py ## @@ -149,12 +150,16 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177267268 ## File path: superset/__init__.py ## @@ -149,12 +150,16 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177277681 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177277941 ## File path: superset/security.py ## @@ -77,177 +78,303 @@ ])

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177277692 ## File path: superset/security.py ## @@ -77,177 +78,303 @@ ])

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177277681 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177266990 ## File path: superset/__init__.py ## @@ -19,7 +19,8 @@ from

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177267268 ## File path: superset/__init__.py ## @@ -149,12 +150,16 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177276966 ## File path: superset/security.py ## @@ -77,177 +78,303 @@ ])

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177268331 ## File path: superset/data/__init__.py ## @@ -71,7 +70,7 @@ def

[GitHub] timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager

2018-03-26 Thread GitBox
timifasubaa commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager URL: https://github.com/apache/incubator-superset/pull/4565#discussion_r177276922 ## File path: superset/security.py ## @@ -77,177 +78,303 @@ ])