timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-324475144
@xrmx how about now?
This is an automated message
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-324466021
@xrmx You're right. I reviewed and updated it. What do you think of the
current state?
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-323564104
@john-bodley I was in agreement until @xrmx 's comment above. The reason I
changed it is that in the event there is not
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-323564104
@john-bodley I was in agreement until @xrmx 's comment above. The reason I
changed it is that in the event there is not
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-323543208
@mistercrunch I don't know why nosetests came to mind when I was on the
terminal. I tried out ./run_specific_test.sh
timifasubaa commented on issue #3339: [explore] Fix and test slice id logging
issue
URL:
https://github.com/apache/incubator-superset/pull/3339#issuecomment-323492169
I took inspiration from test_user_profile and test_fetch_datasource_metadata
and what I have as far as I can see is
