[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-05-01 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385761026 PING Quick update on the state of the logic. What is really happening is that the frontend ceases to poll for

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-04-27 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385121306 @john-bodley @mistercrunch @graceguo-supercat ready for review

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-04-23 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-383770673 I changed the logic to update the db's sate to timeout before it responds to polls.

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-04-20 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-383190144 There is a lot of repeated logic with stop_query for the new timedout query logic.

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-04-18 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382532775 Okay, I will change the logic to set all pending or running queries older than 6 hours old to failed.

[GitHub] timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history

2018-04-18 Thread GitBox
timifasubaa commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-382532775 Okay, I will change the logic to set all pengind or running queries more than 6 hours old to failed.