timifasubaa opened a new pull request #3339: [explore] Fix and test slice id logging issue URL: https://github.com/apache/incubator-superset/pull/3339 This PR fixes and tests the slice_id logging issue (https://github.com/apache/incubator-superset/issues/3311) @mistercrunch @john-bodley I was able to successfully test the /explore case but I had issues with the ajax call (or /explore_json) case. The error was CSRF token is missing. I might be missing something either in the login or in the process of making the request for JSON. The login call triggers the error. This is the same way other functions that needed to login did so. If you want to dig in, the stack trace I get is : Traceback (most recent call last): File "/Users/timi_fasubaa/Desktop/incubator-superset/tests/core_tests.py", line 739, in test_slice_id_is_always_logged_correctly_on_ajax_request self.login(username="admin") File "/Users/timi_fasubaa/Desktop/incubator-superset/tests/base_tests.py", line 131, in login self.assertIn('Welcome', resp) AssertionError: u'Welcome' not found in u'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>400 Bad Request</title>\n<h1>Bad Request</h1>\n<p>The CSRF token is missing.</p>\n' """Fail immediately, with the given message.""" >> raise self.failureException('u\'Welcome\' not found in u\'<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\\n<title>400 Bad Request</title>\\n<h1>Bad Request</h1>\\n<p>The CSRF token is missing.</p>\\n\'') ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
