williaster commented on a change in pull request #4579: Removing [dashboard]
and [slice] titles to show name
URL:
https://github.com/apache/incubator-superset/pull/4579#discussion_r173318329
##########
File path: superset/views/core.py
##########
@@ -1297,7 +1297,7 @@ def explore(self, datasource_type=None,
datasource_id=None):
if datasource_type == 'table' \
else datasource.datasource_name
if slc:
- title = '[slice] ' + slc.slice_name
+ title = slc.slice_name
else:
title = '[explore] ' + table_name
Review comment:
do you think we should change this as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
