[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

2018-04-26 Thread GitBox
xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184539575 ## File path: tests/model_tests.py ## @@ -105,3 +105,9 @@ def test_grains_dict(self):

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

2018-04-26 Thread GitBox
xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661 ## File path: superset/connectors/sqla/models.py ## @@ -130,8 +131,9 @@ def

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

2018-04-26 Thread GitBox
xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661 ## File path: superset/connectors/sqla/models.py ## @@ -130,8 +131,9 @@ def

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

2018-04-26 Thread GitBox
xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661 ## File path: superset/connectors/sqla/models.py ## @@ -130,8 +131,9 @@ def

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

2018-04-26 Thread GitBox
xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail URL: https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661 ## File path: superset/connectors/sqla/models.py ## @@ -130,8 +131,9 @@ def