xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365217960
@villebro please open a PR so it can be reviewed and merged.
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207900
Looking again at the code we may want to clean the sql *after* poking with
the template processor.
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207248
Looks good to me, bonus points for adding a test :)
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288
sqlparse.format has an option for removing comments
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288
sqlparse.format has an option for striping comments
