[GitHub] mistercrunch commented on issue #4193: Init docker for local development environment.

2018-02-08 Thread GitBox
mistercrunch commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-364192852 I agree @brylie, I'm just wondering where it fits in the project. Anything that the maintainer can't commit to maintain

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364209847 I am not using a post agg. I am using COUNT(*) This is an automated

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364142896 ``` {"status": "failed", "stacktrace": "Traceback (most recent call last):\n File

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364142896 ```{"status": "failed", "stacktrace": "Traceback (most recent call last):\n File

[GitHub] mistercrunch closed pull request #4351: use enum.Enum to rewrite querystatus

2018-02-08 Thread GitBox
mistercrunch closed pull request #4351: use enum.Enum to rewrite querystatus URL: https://github.com/apache/incubator-superset/pull/4351 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mistercrunch commented on issue #4351: use enum.Enum to rewrite querystatus

2018-02-08 Thread GitBox
mistercrunch commented on issue #4351: use enum.Enum to rewrite querystatus URL: https://github.com/apache/incubator-superset/pull/4351#issuecomment-364191221 I just had to re-release `pydruid` because of some issue around using `Enum` conditionally in py2/py3 which tripped setuptools. I

[GitHub] maver1ck commented on issue #4370: Two user profile pages - let's make it one

2018-02-08 Thread GitBox
maver1ck commented on issue #4370: Two user profile pages - let's make it one URL: https://github.com/apache/incubator-superset/issues/4370#issuecomment-364198319 So idea is to merge information from /superset/profile/admin/ to /welcome ?

[GitHub] mistercrunch commented on issue #4370: Two user profile pages - let's make it one

2018-02-08 Thread GitBox
mistercrunch commented on issue #4370: Two user profile pages - let's make it one URL: https://github.com/apache/incubator-superset/issues/4370#issuecomment-364192204 `/users/userinfo/` is the page we get out of the web framework we use. It'd be hard to customize, the vision is to

[GitHub] mistercrunch commented on issue #4346: Add permission checks to save_or_overwrite_slice

2018-02-08 Thread GitBox
mistercrunch commented on issue #4346: Add permission checks to save_or_overwrite_slice URL: https://github.com/apache/incubator-superset/pull/4346#issuecomment-364184601 Sorry our linter configuration is picky about `'` over `"`. As a sidenote (may be out-of-scope for this PR) we

[GitHub] vylc opened a new pull request #4386: Canada

2018-02-08 Thread GitBox
vylc opened a new pull request #4386: Canada URL: https://github.com/apache/incubator-superset/pull/4386 Adding Canada to the list of countries - geojson file This is an automated message from the Apache Git Service. To

[GitHub] mistercrunch opened a new issue #4385: Create an integration test around data accessibility

2018-02-08 Thread GitBox
mistercrunch opened a new issue #4385: Create an integration test around data accessibility URL: https://github.com/apache/incubator-superset/issues/4385 In this unit test, create a set of users with different access profiles, include a set of `Gamma` users that have access to an

[GitHub] mistercrunch commented on issue #4384: Fix the bug of chord diagram shows incorrect flow from target to source

2018-02-08 Thread GitBox
mistercrunch commented on issue #4384: Fix the bug of chord diagram shows incorrect flow from target to source URL: https://github.com/apache/incubator-superset/pull/4384#issuecomment-364189209 Mmmh. We probably need a database migration script to flip things up in people's charts.

[GitHub] vylc opened a new issue #4387: Time filter - remove infinity for end date

2018-02-08 Thread GitBox
vylc opened a new issue #4387: Time filter - remove infinity for end date URL: https://github.com/apache/incubator-superset/issues/4387 Default infinity to now for time filter end date. Also, time shift does not work when end date is infinity - [ ] I have checked the superset logs

[GitHub] mistercrunch commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
mistercrunch commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364191648 I mean the JSON expression for your post aggregation definition, also not that you can use triple backticks for better multi line

[GitHub] mistercrunch commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
mistercrunch commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364191648 I mean the JSON expression for your post aggregation definition, also not that you can use triple backticks for better multi line

[GitHub] mistercrunch commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
mistercrunch commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364191648 I meant the JSON expression for your post aggregation definition, also not that you can use triple backticks for better multi line

[GitHub] SpyderRivera commented on issue #4370: Two user profile pages - let's make it one

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4370: Two user profile pages - let's make it one URL: https://github.com/apache/incubator-superset/issues/4370#issuecomment-364226090 @mistercrunch Maybe then not use `/users/userinfo` and put that information on the other page ignoring `/users/userinfo`

[GitHub] graceguo-supercat opened a new pull request #4388: Remove permission check for frontend logging API

2018-02-08 Thread GitBox
graceguo-supercat opened a new pull request #4388: Remove permission check for frontend logging API URL: https://github.com/apache/incubator-superset/pull/4388 it seems no permission check for logging. @john-bodley @mistercrunch

[GitHub] michellethomas commented on issue #4388: Remove permission check for frontend logging API

2018-02-08 Thread GitBox
michellethomas commented on issue #4388: Remove permission check for frontend logging API URL: https://github.com/apache/incubator-superset/pull/4388#issuecomment-364223012 lgtm This is an automated message from the Apache

[GitHub] graceguo-supercat closed pull request #4388: Remove permission check for frontend logging API

2018-02-08 Thread GitBox
graceguo-supercat closed pull request #4388: Remove permission check for frontend logging API URL: https://github.com/apache/incubator-superset/pull/4388 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] john-bodley commented on issue #4388: Remove permission check for frontend logging API

2018-02-08 Thread GitBox
john-bodley commented on issue #4388: Remove permission check for frontend logging API URL: https://github.com/apache/incubator-superset/pull/4388#issuecomment-364224098 Note @mistercrunch for context we've been running into possible FAB race permission issues again even though we've

[GitHub] rahulsingh303 commented on issue #3729: Added multi-tenancy support.

2018-02-08 Thread GitBox
rahulsingh303 commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-364232598 I tried doing this , it doesn't work , anyone was able to do this successfully ? Idea is that , this should solve the issue of dynamic

[GitHub] ahsanshah commented on issue #4283: [FilterBox] Select single value

2018-02-08 Thread GitBox
ahsanshah commented on issue #4283: [FilterBox] Select single value URL: https://github.com/apache/incubator-superset/issues/4283#issuecomment-364266168 This would be great. We sometimes have cases where having a multi select results in double counting values so the ability to

[GitHub] rahulsingh303 commented on issue #4127: How can I only authorize users to dashboards?

2018-02-08 Thread GitBox
rahulsingh303 commented on issue #4127: How can I only authorize users to dashboards? URL: https://github.com/apache/incubator-superset/issues/4127#issuecomment-364229591 Create user and the assign roles . You can start with Gamma , and create additional roles with custom access to data

[GitHub] maver1ck commented on issue #4376: Landing Page for Superset

2018-02-08 Thread GitBox
maver1ck commented on issue #4376: Landing Page for Superset URL: https://github.com/apache/incubator-superset/issues/4376#issuecomment-364034354 I think also related. https://github.com/apache/incubator-superset/issues/4370

[GitHub] FloPit commented on issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source

2018-02-08 Thread GitBox
FloPit commented on issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source URL: https://github.com/apache/incubator-superset/issues/4332#issuecomment-364031902 Hi, Update: with 0.22.1, it is now working!

[GitHub] FloPit closed issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source

2018-02-08 Thread GitBox
FloPit closed issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source URL: https://github.com/apache/incubator-superset/issues/4332 This is an automated message from

[GitHub] mistercrunch commented on issue #4386: Canada

2018-02-08 Thread GitBox
mistercrunch commented on issue #4386: Canada URL: https://github.com/apache/incubator-superset/pull/4386#issuecomment-364281640 Ooops merge conflicts, let me know if I can help with the git workflow. This is an automated

[GitHub] darylerwin closed issue #4392: bigquery select putting in extra "schema" in the column names.

2018-02-08 Thread GitBox
darylerwin closed issue #4392: bigquery select putting in extra "schema" in the column names. URL: https://github.com/apache/incubator-superset/issues/4392 This is an automated message from the Apache Git Service. To

[GitHub] darylerwin commented on issue #4392: bigquery select putting in extra "schema" in the column names.

2018-02-08 Thread GitBox
darylerwin commented on issue #4392: bigquery select putting in extra "schema" in the column names. URL: https://github.com/apache/incubator-superset/issues/4392#issuecomment-364316494 Deleting the "table" from superset and recreating it with dataset.tablename from the initial create

[GitHub] mistercrunch closed pull request #4346: Add permission checks to save_or_overwrite_slice

2018-02-08 Thread GitBox
mistercrunch closed pull request #4346: Add permission checks to save_or_overwrite_slice URL: https://github.com/apache/incubator-superset/pull/4346 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] darylerwin opened a new issue #4392: bigquery select putting in extra "schema" in the column names.

2018-02-08 Thread GitBox
darylerwin opened a new issue #4392: bigquery select putting in extra "schema" in the column names. URL: https://github.com/apache/incubator-superset/issues/4392 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for

[GitHub] xrmx commented on issue #4355: Superset issue #4354 - Properly filter datasources

2018-02-08 Thread GitBox
xrmx commented on issue #4355: Superset issue #4354 - Properly filter datasources URL: https://github.com/apache/incubator-superset/pull/4355#issuecomment-364044168 @maver1ck AFAIR access_tests are specfic to inviting people to access a dashboard

[GitHub] xiaohanyu opened a new pull request #4383: Typo fix: dashbaord -> dashboard.

2018-02-08 Thread GitBox
xiaohanyu opened a new pull request #4383: Typo fix: dashbaord -> dashboard. URL: https://github.com/apache/incubator-superset/pull/4383 Just some small typo fix. This is an automated message from the Apache Git Service. To

[GitHub] thakur00mayank opened a new pull request #3729: Added multi-tenancy support.

2018-02-08 Thread GitBox
thakur00mayank opened a new pull request #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729 Issue: apache/incubator-superset#1089 To achieve multi-tenancy: 1. set "ENABLE_MULTI_TENANCY = True" in superset_config file. 2. add column

[GitHub] thakur00mayank closed pull request #3729: Added multi-tenancy support.

2018-02-08 Thread GitBox
thakur00mayank closed pull request #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] thakur00mayank commented on issue #3729: Added multi-tenancy support.

2018-02-08 Thread GitBox
thakur00mayank commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-364337378 For us, it is working. Can you please tell us what steps you have taken to achieve this(please mention whether you are doing it in the

[GitHub] goldymanikoth opened a new issue #4393: Bypassing the login for Supreset using iframe

2018-02-08 Thread GitBox
goldymanikoth opened a new issue #4393: Bypassing the login for Supreset using iframe URL: https://github.com/apache/incubator-superset/issues/4393 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python

[GitHub] mistercrunch opened a new pull request #4389: [geo] introduce "Auto Zoom" control

2018-02-08 Thread GitBox
mistercrunch opened a new pull request #4389: [geo] introduce "Auto Zoom" control URL: https://github.com/apache/incubator-superset/pull/4389 On geospatial visualization, checking the "Auto Zoom" control makes it such that the viewport is fitted to the data upon rendering the chart.

[GitHub] ddworken-sc opened a new pull request #4390: Fix 4 security vulnerabilities

2018-02-08 Thread GitBox
ddworken-sc opened a new pull request #4390: Fix 4 security vulnerabilities URL: https://github.com/apache/incubator-superset/pull/4390 As discussed with @mistercrunch privately, here are patches for 4 different security vulnerabilities. The fixed vulnerabilities are: 1. Code

[GitHub] raffas opened a new issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

2018-02-08 Thread GitBox
raffas opened a new issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/issues/4391 Make sure these boxes are checked before submitting your issue - thank

[GitHub] brylie commented on issue #4193: Init docker for local development environment.

2018-02-08 Thread GitBox
brylie commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-364105468 A `docker-compose.yml` file would be a great step to make Superset deployment easier! :-)

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364140796 that doesn't come up ![screen shot 2018-02-08 at 8 09 05

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364142896 `{"status": "failed", "stacktrace": "Traceback (most recent call last):\n File

[GitHub] SpyderRivera commented on issue #4371: Mapbox isn't working on Druid

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4371: Mapbox isn't working on Druid URL: https://github.com/apache/incubator-superset/issues/4371#issuecomment-364140796 that doesn't come up ![screen shot 2018-02-08 at 8 09 05

[GitHub] SpyderRivera commented on issue #4370: Two user profile pages - let's make it one

2018-02-08 Thread GitBox
SpyderRivera commented on issue #4370: Two user profile pages - let's make it one URL: https://github.com/apache/incubator-superset/issues/4370#issuecomment-364145118 I would say the `/users/userinfo/` page should be linked to on `/superset/profile/admin/` as a tab. Similar to the recent