[GitHub] mistercrunch opened a new pull request #4651: [WiP] [explore] proper filtering of NULLs and ''

2018-03-20 Thread GitBox
mistercrunch opened a new pull request #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651 TODO: handling of Druid equivalents This is an automated message from

[GitHub] sunyongmofang closed pull request #4614: Add sql editor

2018-03-20 Thread GitBox
sunyongmofang closed pull request #4614: Add sql editor URL: https://github.com/apache/incubator-superset/pull/4614 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo

2018-03-20 Thread GitBox
williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-374506307 @graceguo-supercat I think this is ready to merge into the `dashboard-builder`

[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo

2018-03-20 Thread GitBox
williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-374506307 @graceguo-supercat I think this is ready to merge into the `dashboard-builder`

[GitHub] leehwmj-junta commented on issue #4650: Have to repeat build and install each time when I modify and test jsx in superset/assets/javascript

2018-03-20 Thread GitBox
leehwmj-junta commented on issue #4650: Have to repeat build and install each time when I modify and test jsx in superset/assets/javascript URL: https://github.com/apache/incubator-superset/issues/4650#issuecomment-374535916 @mistercrunch , I tried with the suggested method. But

[GitHub] ccl0326 opened a new issue #4652: add group by parameters into filter box

2018-03-20 Thread GitBox
ccl0326 opened a new issue #4652: add group by parameters into filter box URL: https://github.com/apache/incubator-superset/issues/4652 now we can use filter box to filter fields, but if we can make filter box control group by parameters we can make it more free. we can select some fields

[GitHub] SpyderRivera commented on issue #4545: add two more number formats, add number formats to table

2018-03-20 Thread GitBox
SpyderRivera commented on issue #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545#issuecomment-374615510 @Pek1s can you fix the conflict? This is an

[GitHub] SpyderRivera commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0

2018-03-20 Thread GitBox
SpyderRivera commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374737666 I don't know what all the extra differences are from... like RonanW to ronanw

[GitHub] jeffreythewang commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374697547 I've added the fix for `groupby` queries as well, and only scoped the query field updates (with

[GitHub] codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0

2018-03-20 Thread GitBox
codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374747816 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=h1) Report > Merging

[GitHub] kuvsh commented on issue #1231: Support for emailing reports at regular intervals?

2018-03-20 Thread GitBox
kuvsh commented on issue #1231: Support for emailing reports at regular intervals? URL: https://github.com/apache/incubator-superset/issues/1231#issuecomment-374772525 Hello. We also need this feature badly. This is an

[GitHub] darylerwin commented on issue #4644: Superset has no plain number format for Table chart type

2018-03-20 Thread GitBox
darylerwin commented on issue #4644: Superset has no plain number format for Table chart type URL: https://github.com/apache/incubator-superset/issues/4644#issuecomment-374760158 New to all this github stuff but what are the steps to getting a PR into the released code - seems like there

[GitHub] codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0

2018-03-20 Thread GitBox
codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374747816 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4633: Cache the query string

2018-03-20 Thread GitBox
codecov-io commented on issue #4633: Cache the query string URL: https://github.com/apache/incubator-superset/pull/4633#issuecomment-374794885 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=h1) Report > Merging

[GitHub] betodealmeida opened a new pull request #4654: Expose metrics to JS

2018-03-20 Thread GitBox
betodealmeida opened a new pull request #4654: Expose metrics to JS URL: https://github.com/apache/incubator-superset/pull/4654 @vylc requested the ability of exposing the metrics to the JS advanced tooltip:

[GitHub] jeffreythewang commented on a change in pull request #4646: [BugFix] Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7

[GitHub] codecov-io commented on issue #4654: Expose metrics to JS

2018-03-20 Thread GitBox
codecov-io commented on issue #4654: Expose metrics to JS URL: https://github.com/apache/incubator-superset/pull/4654#issuecomment-374777021 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=h1) Report > Merging

[GitHub] john-bodley opened a new pull request #4655: [druid] Updating refresh logic

2018-03-20 Thread GitBox
john-bodley opened a new pull request #4655: [druid] Updating refresh logic URL: https://github.com/apache/incubator-superset/pull/4655 Though the term "refresh" is somewhat vague from a Druid metadata perspective I sense this translates to create or update. Previously we were creating or

[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands

2018-03-20 Thread GitBox
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT =

[GitHub] jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175957193 ## File path: docs/installation.rst ## @@ -125,10 +125,7 @@ Follow

[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands

2018-03-20 Thread GitBox
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT =

[GitHub] codecov-io commented on issue #4643: Added option to add fill to area line charts

2018-03-20 Thread GitBox
codecov-io commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-374139725 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=h1) Report > Merging

[GitHub] jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175957908 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT =

[GitHub] ktong opened a new issue #4656: the schema of short url is hard code to http

2018-03-20 Thread GitBox
ktong opened a new issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656 https://github.com/apache/incubator-superset/blob/93ec76f7570dcd53d110498cc18ec0f15dd9854b/superset/views/core.py#L750

[GitHub] hughhhh commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''

2018-03-20 Thread GitBox
hug commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374833997 Definitely need this!! This is an automated message from

[GitHub] syzuhdi commented on issue #3447: 'twophase' is an invalid keyword errors connecting to Oracle

2018-03-20 Thread GitBox
syzuhdi commented on issue #3447: 'twophase' is an invalid keyword errors connecting to Oracle URL: https://github.com/apache/incubator-superset/issues/3447#issuecomment-374836004 rahul, what is your cx_Oracle version ?

[GitHub] codecov-io commented on issue #4631: Fix flower broker configuration

2018-03-20 Thread GitBox
codecov-io commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-373852220 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=h1) Report > Merging

[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@

[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@

[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@

[GitHub] jeffreythewang commented on issue #4646: Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
jeffreythewang commented on issue #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374697547 I've added the fix for `groupby` queries as well, and only limited the query field updates (with `.update` as

[GitHub] michellethomas commented on issue #4649: Use one library for table components

2018-03-20 Thread GitBox
michellethomas commented on issue #4649: Use one library for table components URL: https://github.com/apache/incubator-superset/issues/4649#issuecomment-374683340 Thanks for the information Max. This is super useful. This is

[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''

2018-03-20 Thread GitBox
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''

2018-03-20 Thread GitBox
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging

[GitHub] leorochael commented on issue #4631: Fix flower broker configuration

2018-03-20 Thread GitBox
leorochael commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-374687104 > In terms of enforcing that the BROKER_URL is present isn't this required by the Celery worker? It seems that the convention is that

[GitHub] mistercrunch commented on issue #4297: [Filter Box] Boolean values show up blank in selector

2018-03-20 Thread GitBox
mistercrunch commented on issue #4297: [Filter Box] Boolean values show up blank in selector URL: https://github.com/apache/incubator-superset/issues/4297#issuecomment-374489750 related as prerequisite: https://github.com/apache/incubator-superset/pull/4651

Sessions still active on Datasource

2018-03-20 Thread Mohammed amine TAYABI -BTWIN VILLAGE LILLE-
Hello, My name is Amine and I am working for Decathlon. I am contacting you concerning a problem found when using superset. We have several session still running on our datasource (Postgres Database) even when superset dashboard is closed or cached on redis. How can we make sure that superset

[GitHub] codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics

2018-03-20 Thread GitBox
codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374430478 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=h1) Report > Merging