[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179854743 ## File path: superset/assets/javascripts/explore/stores/visTypes.js ## @@ -1,3 +1,7 @@ +/** + * This file defines how controls (defined in controls.js) are structured into sections Review comment: `control.jsx` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855872 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1,3 +1,43 @@ +/** + * This file exports all controls available for use in the different visualization types + * + * While the React components located in `controls/components` represent different + * types of controls (CheckboxControl, SelectControl, TextControl, ...), the controls here + * represent instances of control types, that can be reused across visualisation types. + * + * When controls are reused across viz types, their values are carried over as a user + * changes the chart types. + * + * While the keys defined in the control itself get passed to the controlType as props, + * here's a list of the keys that are common to all controls, + * and as a result define the control interface: + * + * - type: the control type, referencing a React component of the same name + * - label: the label as shown in the control's header + * - description: shown in the info tooltip of the control's header + * - default: the default value when opening a new chart, or changing visualization type + * - renderTrigger: a bool that defines whether the visualization should be re-rendered + when changed. This should `true` for controls that only affect the rendering (client side) + and don't affect the query or backend data processing as those require to re run a query + and fetch the data + * - validators: an array of functions that will receive the value of the component and + should return error messages when the value is not valid. The error message gets + bubble up to the control header, section header and query panel header. + * - warning: text shown as a tooltip on a warning icon in the control's header + * - error: text shown as a tooltip on a error icon in the control's header + * - mapStateToProps: a function that receives the App's state and return an object of k/v + to overwrite configuration at runtime. This is useful to alter a component based on + anything external to it, like another control's value. For instance it's possible to + show a warning based on the value of another component. It's also possible to bind + arbitrary data from the redux store to the component this way. + * - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data` + tab, otherwise `renderTrigger: true` components will show up on the `Style` tab. + * + * Note that the keys defined in controls in this file that are not listed above represent + * props specific for the React component defined as `type`. Also note that this module work + * in tandem with `visTypes.js` that defines how controls are composed into sections for + * each and every visualization types. Review comment: each and every visualization type This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration
betodealmeida commented on a change in pull request #4755: Pass granularity
from backend to frontend as ISO duration
URL:
https://github.com/apache/incubator-superset/pull/4755#discussion_r179837129
##
File path: superset/assets/javascripts/explore/stores/controls.jsx
##
@@ -699,21 +699,21 @@ export const controls = {
freeForm: true,
label: t('Time Granularity'),
default: 'one day',
-choices: formatSelectOptions([
- 'all',
- '5 seconds',
- '30 seconds',
- '1 minute',
- '5 minutes',
- '1 hour',
- '6 hour',
- '1 day',
- '7 days',
- 'week',
- 'week_starting_sunday',
- 'week_ending_saturday',
- 'month',
-]),
+choices: [
+ [null, 'all'],
+ ['PT5S', '5 seconds'],
Review comment:
It does, it loads with the saved value as freeform:
https://user-images.githubusercontent.com/1534870/38437359-0cd5cc42-398c-11e8-865b-32c646d21699.png;>
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4772: [dashboard] open in edit mode when adding a chart
betodealmeida commented on a change in pull request #4772: [dashboard] open in
edit mode when adding a chart
URL:
https://github.com/apache/incubator-superset/pull/4772#discussion_r179858801
##
File path: superset/assets/javascripts/explore/components/SaveModal.jsx
##
@@ -107,7 +107,7 @@ class SaveModal extends React.Component {
.then((data) => {
// Go to new slice url or dashboard url
if (gotodash) {
- window.location = data.dashboard;
+ window.location = data.dashboard + '=true';
Review comment:
We might wanna use the `URL` object every where we manipulate URLs to make
it more robust, eg:
```javascript
const url = new URL(data.dashboard);
url.searchParams.set('edit', 'true');
window.location = url.href;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855498 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1,3 +1,43 @@ +/** + * This file exports all controls available for use in the different visualization types + * + * While the React components located in `controls/components` represent different + * types of controls (CheckboxControl, SelectControl, TextControl, ...), the controls here + * represent instances of control types, that can be reused across visualisation types. + * + * When controls are reused across viz types, their values are carried over as a user + * changes the chart types. + * + * While the keys defined in the control itself get passed to the controlType as props, + * here's a list of the keys that are common to all controls, + * and as a result define the control interface: + * + * - type: the control type, referencing a React component of the same name + * - label: the label as shown in the control's header + * - description: shown in the info tooltip of the control's header + * - default: the default value when opening a new chart, or changing visualization type + * - renderTrigger: a bool that defines whether the visualization should be re-rendered + when changed. This should `true` for controls that only affect the rendering (client side) + and don't affect the query or backend data processing as those require to re run a query + and fetch the data + * - validators: an array of functions that will receive the value of the component and + should return error messages when the value is not valid. The error message gets + bubble up to the control header, section header and query panel header. Review comment: bubbled up This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx
betodealmeida commented on a change in pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#discussion_r179855277 ## File path: superset/assets/javascripts/explore/stores/controls.jsx ## @@ -1,3 +1,43 @@ +/** + * This file exports all controls available for use in the different visualization types + * + * While the React components located in `controls/components` represent different + * types of controls (CheckboxControl, SelectControl, TextControl, ...), the controls here + * represent instances of control types, that can be reused across visualisation types. + * + * When controls are reused across viz types, their values are carried over as a user + * changes the chart types. + * + * While the keys defined in the control itself get passed to the controlType as props, + * here's a list of the keys that are common to all controls, + * and as a result define the control interface: Review comment: The flow of text in lines 12/13 is weird, you might wanna move some of the text in line 13 to line 12. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift
betodealmeida commented on a change in pull request #4765: [line] fix verbose
names in time shift
URL:
https://github.com/apache/incubator-superset/pull/4765#discussion_r179863054
##
File path: superset/assets/spec/javascripts/visualizations/nvd3_viz_spec.jsx
##
@@ -0,0 +1,28 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+
+import { formatLabel } from '../../../visualizations/nvd3_vis';
+
+describe('nvd3 viz', () => {
+ const verboseMap = {
+foo: 'Foo',
+bar: 'Bar',
+ };
+ describe('formatLabel', () => {
+it('is formats simple labels', () => {
Review comment:
Nit, drop the "is"?
`it('formats simple labels', () => {`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4765: [line] fix verbose names in time shift
betodealmeida commented on a change in pull request #4765: [line] fix verbose
names in time shift
URL:
https://github.com/apache/incubator-superset/pull/4765#discussion_r179863177
##
File path: superset/assets/visualizations/nvd3_vis.js
##
@@ -83,23 +83,24 @@ function getMaxLabelSize(container, axisClass) {
return Math.max(...labelDimensions);
}
-/* eslint-disable camelcase */
-function formatLabel(column, verbose_map) {
+export function formatLabel(input, verboseMap = {}) {
+ // The input for label may be a string or an array of string
+ // When using the time shift feature, the label contains a '---' in the array
+ const verboseLkp = s => verboseMap[s] || s;
let label;
- if (Array.isArray(column) && column.length) {
-label = verbose_map[column[0]] || column[0];
-if (column.length > 1) {
- label += ', ';
+ if (Array.isArray(input) && input.length) {
+const verboseLabels = input.filter(s => s !== '---').map(verboseLkp);
+label = verboseLabels.join(', ');
+if (input.length > verboseLabels.length) {
+ label += '---';
Review comment:
Did you test leaving a space between the label and the dashes? Seems a bit
cluttered to me without the space there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4773: Fix brush with annotations
codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging [#4773](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4773 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=footer). Last update [92230b8...b223abe](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4768: [Bug fix] Resolving key conflicts in Timeseries Annotation Layer when key is a string
mistercrunch closed pull request #4768: [Bug fix] Resolving key conflicts in
Timeseries Annotation Layer when key is a string
URL: https://github.com/apache/incubator-superset/pull/4768
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/visualizations/nvd3_vis.js
b/superset/assets/visualizations/nvd3_vis.js
index 9ce02bd031..36da5794d9 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -543,7 +543,7 @@ function nvd3Vis(slice, payload) {
return {};
}
const key = Array.isArray(series.key) ?
-`${a.name}, ${series.key.join(', ')}` : a.name;
+`${a.name}, ${series.key.join(', ')}` : `${a.name}, ${series.key}`;
return {
...series,
key,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch closed pull request #4778: Add notes to contrib file about testing and code coverage
mistercrunch closed pull request #4778: Add notes to contrib file about testing
and code coverage
URL: https://github.com/apache/incubator-superset/pull/4778
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index fbc090c5b0..6034b571c8 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -61,15 +61,21 @@ meets these guidelines:
1. The pull request should include tests, either as doctests,
unit tests, or both.
-2. If the pull request adds functionality, the docs should be updated
+2. Run `npm run lint` and resolve all errors. Run `npm run test` and
+resolve all test failures.
+3. Check code coverage by running the following commands in the `assets`
+directory. Run `npm run cover` to check code coverage on `.js` work, and
+run `nosetests --with-coverage` to check code coverage on `.py` work. You
+may have to first run `pip install nose coverage`.
+4. If the pull request adds functionality, the docs should be updated
as part of the same PR. Doc string are often sufficient, make
sure to follow the sphinx compatible standards.
-3. The pull request should work for Python 2.7, and ideally python 3.4+.
+5. The pull request should work for Python 2.7, and ideally python 3.4+.
``from __future__ import`` will be required in every `.py` file soon.
-4. Code will be reviewed by re running the unittests, flake8 and syntax
+6. Code will be reviewed by re running the unittests, flake8 and syntax
should be as rigorous as the core Python project.
-5. Please rebase and resolve all conflicts before submitting.
-6. If you are asked to update your pull request with some changes there's
+7. Please rebase and resolve all conflicts before submitting.
+8. If you are asked to update your pull request with some changes there's
no need to create a new one. Push your changes to the same branch.
## Documentation
@@ -421,10 +427,10 @@ https://github.com/apache/incubator-superset/pull/3013
We create a branch that goes along each minor release `0.24`
and micro releases get corresponding tags as in `0.24.0`. Git history should
never be altered in release branches.
- Bug fixes and security-related patches get cherry-picked
+ Bug fixes and security-related patches get cherry-picked
(usually from master) as in `git cherry-pick -x {SHA}`.
-
- Following a set of cherries being picked, a release can be pushed to
+
+ Following a set of cherries being picked, a release can be pushed to
Pypi as follows:
.. code::
@@ -461,11 +467,11 @@ https://github.com/apache/incubator-superset/pull/3013
# looking the latest CHANGELOG entry for the second argument
./gen_changelog.sh 0.22.1 0.25.0
# this will overwrite the CHANGELOG.md with only the version range
-# so you'll want to copy paste that on top of the previous CHANGELOG.md
+# so you'll want to copy paste that on top of the previous CHANGELOG.md
# open a PR against `master`
In the future we'll start publishing release candidates for minor releases
- only, but typically not for micro release.
+ only, but typically not for micro release.
The process will be similar to the process described above, expect the
tags will be formated `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
is reached.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards
Tresdon commented on issue #4725: [WIP] Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-379393919 Thanks for such useful and quick feedback on this, A couple thoughts and things to do yet - Ah yeah the `yarn.lock` did creep in there. This is probably a silly question but what would the best way be to go about getting the proper version of this? Probably just using the one from the commit before or should redoing the `yarn install` set it straight? - Releasing the feature: Perhaps it'd be fine to just have a script that sets all dashboards to published since this wouldn't affect the system at all and then people would just be able to modify it from then on? Even though 28 days-ish seems like a reasonable cutoff, this just seems minimally invasive. - Toggling status in dashboard view and not just CRUD: Great idea, this commit adds some of that functionality. I've added an icon right next to the favorite icon to show whether or not it's published. I built it primarily off of the FavStar component as well. It's not currently working completely. - About chart privacy: The charts do get more cluttered but I don't know if they're browsed as a final product in the same way as dashboards. Also wondering how this would interact with adding charts to dashboards, would people only be able to see published charts? - SQL Generated: I'd be interested in knowing this too. I know that I can go to each of the `Filter`s and print out the query before and after any transformations but am not sure how to find out what things look like before applying either filter and afterwards. Any quick ideas on how to do this? I haven't looked into it much. Things to do: - The route I created for modifying the status `superset/dashboard//published/` returns a 302. I haven't dug into it too much yet but perhaps you know what I need to do to address this. - Show user their favorited dashboards in the list. - Test non-owners trying to modify the published status - Show generated SQL from using multiple base_filters Thanks again for your feedback! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4766: [explore] set control default for *showminmax = false
mistercrunch closed pull request #4766: [explore] set control default for
*showminmax = false
URL: https://github.com/apache/incubator-superset/pull/4766
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index 72baf1ff35..65dd2f64a2 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1399,7 +1399,7 @@ export const controls = {
type: 'CheckboxControl',
label: t('X bounds'),
renderTrigger: true,
-default: true,
+default: false,
description: t('Whether to display the min and max values of the X axis'),
},
@@ -1407,7 +1407,7 @@ export const controls = {
type: 'CheckboxControl',
label: t('Y bounds'),
renderTrigger: true,
-default: true,
+default: false,
description: t('Whether to display the min and max values of the Y axis'),
},
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch closed pull request #4773: Fix brush with annotations
mistercrunch closed pull request #4773: Fix brush with annotations
URL: https://github.com/apache/incubator-superset/pull/4773
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/visualizations/nvd3_vis.js
b/superset/assets/visualizations/nvd3_vis.js
index 9ce02bd031..c5b2433b8b 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -586,6 +586,7 @@ function nvd3Vis(slice, payload) {
xMax = chart.xAxis.scale().domain()[1].valueOf();
xScale = chart.xScale ? chart.xScale() : d3.scale.linear();
}
+xScale.clamp(true);
if (Array.isArray(formulas) && formulas.length) {
const xValues = [];
@@ -622,7 +623,9 @@ function nvd3Vis(slice, payload) {
}));
data.push(...formulaData);
}
+const xAxis = chart.xAxis1 ? chart.xAxis1 : chart.xAxis;
const yAxis = chart.yAxis1 ? chart.yAxis1 : chart.yAxis;
+const chartWidth = xAxis.scale().range()[1];
const annotationHeight = yAxis.scale().range()[0];
const tipFactory = layer => d3tip()
.attr('class', 'd3-tip')
@@ -663,19 +666,7 @@ function nvd3Vis(slice, payload) {
};
}).filter(record =>
!Number.isNaN(record[e.timeColumn].getMilliseconds()));
-// account for the annotation in the x domain
-records.forEach((record) => {
- const timeValue = record[e.timeColumn];
-
- xMin = Math.min(...[xMin, timeValue]);
- xMax = Math.max(...[xMax, timeValue]);
-});
-
if (records.length) {
- const domain = [xMin, xMax];
- xScale.domain(domain);
- chart.xDomain(domain);
-
annotations.selectAll('line')
.data(records)
.enter()
@@ -693,6 +684,22 @@ function nvd3Vis(slice, payload) {
.on('mouseout', tip.hide)
.call(tip);
}
+
+// update annotation positions on brush event
+chart.focus.dispatch.on('onBrush.event-annotation', function () {
+ annotations.selectAll('line')
+.data(records)
+.attr({
+ x1: d => xScale(new Date(d[e.timeColumn])),
+ y1: 0,
+ x2: d => xScale(new Date(d[e.timeColumn])),
+ y2: annotationHeight,
+ opacity: (d) => {
+const x = xScale(new Date(d[e.timeColumn]));
+return (x > 0) && (x < chartWidth) ? 1 : 0;
+ },
+});
+});
});
// Interval annotations
@@ -721,20 +728,7 @@ function nvd3Vis(slice, payload) {
!Number.isNaN(record[e.intervalEndColumn].getMilliseconds())
));
-// account for the annotation in the x domain
-records.forEach((record) => {
- const timeValue = record[e.timeColumn];
- const intervalEndValue = record[e.intervalEndColumn];
-
- xMin = Math.min(...[xMin, timeValue, intervalEndValue]);
- xMax = Math.max(...[xMax, timeValue, intervalEndValue]);
-});
-
if (records.length) {
- const domain = [xMin, xMax];
- xScale.domain(domain);
- chart.xDomain(domain);
-
annotations.selectAll('rect')
.data(records)
.enter()
@@ -756,6 +750,20 @@ function nvd3Vis(slice, payload) {
.on('mouseout', tip.hide)
.call(tip);
}
+
+// update annotation positions on brush event
+chart.focus.dispatch.on('onBrush.interval-annotation', function ()
{
+ annotations.selectAll('rect')
+.data(records)
+.attr({
+ x: d => xScale(new Date(d[e.timeColumn])),
+ width: (d) => {
+const x1 = xScale(new Date(d[e.timeColumn]));
+const x2 = xScale(new Date(d[e.intervalEndColumn]));
+return x2 - x1;
+ },
+});
+});
});
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'
mistercrunch commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379408597 Oh the idea is that when using a period ratio, we're looking at a % change, so we should change the format should reflect that. Since we know it's a percentage we can just format it on their behalf. There's no precedent into cascading control changes based on rules, here we just force the format to be `.1%`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4755: Pass granularity from backend to frontend as ISO duration
mistercrunch closed pull request #4755: Pass granularity from backend to
frontend as ISO duration
URL: https://github.com/apache/incubator-superset/pull/4755
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index e4a37a20ed..d773ab4768 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -699,21 +699,21 @@ export const controls = {
freeForm: true,
label: t('Time Granularity'),
default: 'one day',
-choices: formatSelectOptions([
- 'all',
- '5 seconds',
- '30 seconds',
- '1 minute',
- '5 minutes',
- '1 hour',
- '6 hour',
- '1 day',
- '7 days',
- 'week',
- 'week_starting_sunday',
- 'week_ending_saturday',
- 'month',
-]),
+choices: [
+ [null, 'all'],
+ ['PT5S', '5 seconds'],
+ ['PT30S', '30 seconds'],
+ ['PT1M', '1 minute'],
+ ['PT5M', '5 minutes'],
+ ['PT1H', '1 hour'],
+ ['PT6H', '6 hour'],
+ ['P1D', '1 day'],
+ ['P7D', '7 days'],
+ ['P1W', 'week'],
+ ['P1W', 'week_starting_sunday'],
+ ['P1W', 'week_ending_saturday'],
+ ['P1M', 'month'],
+],
description: t('The time granularity for the visualization. Note that you
' +
'can type and use simple natural language as in `10 seconds`, ' +
'`1 day` or `56 weeks`'),
diff --git a/superset/assets/package.json b/superset/assets/package.json
index 6b271b4f3a..ba4c1959bf 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -79,6 +79,7 @@
"object.entries": "^1.0.4",
"object.keys": "^0.1.0",
"object.values": "^1.0.4",
+"parse-iso-duration": "^1.0.0",
"po2json": "^0.4.5",
"prop-types": "^15.6.0",
"react": "^15.6.2",
diff --git a/superset/assets/visualizations/deckgl/layers/scatter.jsx
b/superset/assets/visualizations/deckgl/layers/scatter.jsx
index 3d8e99cb76..052a7ab7c1 100644
--- a/superset/assets/visualizations/deckgl/layers/scatter.jsx
+++ b/superset/assets/visualizations/deckgl/layers/scatter.jsx
@@ -4,6 +4,7 @@ import React from 'react';
import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
+import parseIsoDuration from 'parse-iso-duration';
import { ScatterplotLayer } from 'deck.gl';
import AnimatableDeckGLContainer from '../AnimatableDeckGLContainer';
@@ -14,27 +15,6 @@ import { getColorFromScheme, hexToRGB } from
'../../../javascripts/modules/color
import { unitToRadius } from '../../../javascripts/modules/geo';
import sandboxedEval from '../../../javascripts/modules/sandbox';
-function getStep(timeGrain) {
- // grain in milliseconds
- const MINUTE = 60 * 1000;
- const HOUR = 60 * MINUTE;
- const DAY = 24 * HOUR;
- const WEEK = 7 * DAY;
- const MONTH = 30 * DAY;
- const YEAR = 365 * DAY;
-
- const milliseconds = {
-'Time Column': MINUTE,
-min: MINUTE,
-hour: HOUR,
-day: DAY,
-week: WEEK,
-month: MONTH,
-year: YEAR,
- };
-
- return milliseconds[timeGrain];
-}
function getPoints(data) {
return data.map(d => d.position);
@@ -117,7 +97,7 @@ class DeckGLScatter extends React.PureComponent {
/* eslint-disable no-unused-vars */
static getDerivedStateFromProps(nextProps, prevState) {
const fd = nextProps.slice.formData;
-const timeGrain = fd.time_grain_sqla || fd.granularity || 'min';
+const timeGrain = fd.time_grain_sqla || fd.granularity || 'PT1M';
// find start and end based on the data
const timestamps = nextProps.payload.data.features.map(f => f.__timestamp);
@@ -125,7 +105,7 @@ class DeckGLScatter extends React.PureComponent {
let end = Math.max(...timestamps);
// lock start and end to the closest steps
-const step = getStep(timeGrain);
+const step = parseIsoDuration(timeGrain);
start -= start % step;
end += step - end % step;
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index 935cf62f64..ded00d8f2d 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -6567,6 +6567,10 @@ parse-glob@^3.0.4:
is-extglob "^1.0.0"
is-glob "^2.0.0"
+parse-iso-duration@^1.0.0:
+ version "1.0.0"
+ resolved
"https://registry.yarnpkg.com/parse-iso-duration/-/parse-iso-duration-1.0.0.tgz#b923ab898a8ff8f42bdc9ee5db6e22808c48a864;
+
parse-json@^2.1.0, parse-json@^2.2.0:
version "2.2.0"
resolved
"https://registry.yarnpkg.com/parse-json/-/parse-json-2.2.0.tgz#f480f40434ef80741f8469099f8dea18f55a4dc9;
diff --git a/superset/connectors/sqla/models.py
b/superset/connectors/sqla/models.py
index c8ee40269c..7e9a94cfd0 100644
---
[GitHub] mistercrunch closed pull request #4767: Improve controls layout for Table visualization
mistercrunch closed pull request #4767: Improve controls layout for Table
visualization
URL: https://github.com/apache/incubator-superset/pull/4767
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index 72baf1ff35..6523004788 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1105,6 +1105,7 @@ export const controls = {
freeForm: true,
label: t('Table Timestamp Format'),
default: '%Y-%m-%d %H:%M:%S',
+renderTrigger: true,
validators: [v.nonEmpty],
clearable: false,
choices: D3_TIME_FORMAT_OPTIONS,
@@ -1123,6 +1124,7 @@ export const controls = {
page_length: {
type: 'SelectControl',
freeForm: true,
+renderTrigger: true,
label: t('Page Length'),
default: 0,
choices: formatSelectOptions([0, 10, 25, 40, 50, 75, 100, 150, 200]),
@@ -1351,6 +1353,7 @@ export const controls = {
table_filter: {
type: 'CheckboxControl',
label: t('Table Filter'),
+renderTrigger: true,
default: false,
description: t('Whether to apply filter when table cell is clicked'),
},
diff --git a/superset/assets/javascripts/explore/stores/visTypes.js
b/superset/assets/javascripts/explore/stores/visTypes.js
index d848f40e10..b63dc05de6 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -748,12 +748,13 @@ export const visTypes = {
{
label: t('GROUP BY'),
description: t('Use this section if you want a query that aggregates'),
+expanded: true,
controlSetRows: [
['groupby'],
['metrics'],
['percent_metrics'],
- ['include_time'],
- ['timeseries_limit_metric', 'order_desc'],
+ ['timeseries_limit_metric', 'row_limit'],
+ ['include_time', 'order_desc'],
],
},
{
@@ -762,13 +763,15 @@ export const visTypes = {
controlSetRows: [
['all_columns'],
['order_by_cols'],
+ ['row_limit', null],
],
},
{
label: t('Options'),
+expanded: true,
controlSetRows: [
['table_timestamp_format'],
- ['row_limit', 'page_length'],
+ ['page_length', null],
['include_search', 'table_filter'],
['align_pn', 'color_pn'],
],
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vylc opened a new issue #4779: [Heatmap] Time granularity not applied
vylc opened a new issue #4779: [Heatmap] Time granularity not applied URL: https://github.com/apache/incubator-superset/issues/4779 Druid Datasource Timestamp chosen as y-axis (though also doesn't work when chosen as x-axis) Dimension chosen as x-axis Time granularity rolled up to hour Metric is a simple count(*) Result--> chart still shows individual timestamp (which is overkill as each tick mark is one ride) Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011194 +14 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.82% <100%> (+0.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...cd11186](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011194 +14 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.82% <100%> (+0.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...cd11186](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ttannis opened a new pull request #4778: Add notes to contrib file about testing and code coverage
ttannis opened a new pull request #4778: Add notes to contrib file about testing and code coverage URL: https://github.com/apache/incubator-superset/pull/4778 @betodealmeida asked that we add notes about how to check code coverage since we'd want to move towards that getting better. Also added notes about running npm run lint and npm run test...very helpful for newer contributors. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4778: Add notes to contrib file about testing and code coverage
codecov-io commented on issue #4778: Add notes to contrib file about testing and code coverage URL: https://github.com/apache/incubator-superset/pull/4778#issuecomment-379397208 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=h1) Report > Merging [#4778](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4778 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=footer). Last update [92230b8...1fcbfa3](https://codecov.io/gh/apache/incubator-superset/pull/4778?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx
codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#issuecomment-379300038 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=h1) Report > Merging [#4777](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4777 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4777/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4777/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=footer). Last update [92230b8...609d04e](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] emirot opened a new pull request #4780: [i18n] Add French translation
emirot opened a new pull request #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780 I would like to add some french translations but I don't know what to refer to because the navbar_menu is auto generated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging [#4780](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bd2cb9aada1d367ed8883cf6ab4ef33034e6f5b2?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4780 +/- ## === Coverage 72.56% 72.56% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1117511175 Misses 4223 4223 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=footer). Last update [bd2cb9a...1b1a161](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging [#4780](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bd2cb9aada1d367ed8883cf6ab4ef33034e6f5b2?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4780 +/- ## === Coverage 72.56% 72.56% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1117511175 Misses 4223 4223 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=footer). Last update [bd2cb9a...1b1a161](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4780: [i18n] Add French translation
codecov-io commented on issue #4780: [i18n] Add French translation URL: https://github.com/apache/incubator-superset/pull/4780#issuecomment-379434331 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=h1) Report > Merging [#4780](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bd2cb9aada1d367ed8883cf6ab4ef33034e6f5b2?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4780 +/- ## === Coverage 72.56% 72.56% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1117511175 Misses 4223 4223 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=footer). Last update [bd2cb9a...1b1a161](https://codecov.io/gh/apache/incubator-superset/pull/4780?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4774: [explore] forcing .1% number format when using 'Period Ratio'
mistercrunch opened a new pull request #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774 https://user-images.githubusercontent.com/487433/38406333-45bd2d56-3929-11e8-9802-fe9c57dcc613.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'
codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379164432 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=h1) Report > Merging [#4774](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `16.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4774 +/- ## == - Coverage 72.59% 72.57% -0.03% == Files 205 205 Lines 1540115407 +6 Branches 1183 1189 +6 == + Hits1118011181 +1 - Misses 4218 4223 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ipts/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `84.74% <ø> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.12% <0%> (-1.13%)` | :arrow_down: | | [...s/javascripts/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `73.52% <50%> (-1.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=footer). Last update [92230b8...0896a8d](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio'
codecov-io commented on issue #4774: [explore] forcing .1% number format when using 'Period Ratio' URL: https://github.com/apache/incubator-superset/pull/4774#issuecomment-379164432 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=h1) Report > Merging [#4774](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `16.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4774 +/- ## == - Coverage 72.59% 72.57% -0.03% == Files 205 205 Lines 1540115407 +6 Branches 1183 1189 +6 == + Hits1118011181 +1 - Misses 4218 4223 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ipts/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `84.74% <ø> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.12% <0%> (-1.13%)` | :arrow_down: | | [...s/javascripts/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4774/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `73.52% <50%> (-1.48%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=footer). Last update [92230b8...0896a8d](https://codecov.io/gh/apache/incubator-superset/pull/4774?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4747: [WiP] Download Dashboards as PDF
SpyderRivera commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379235250 @abowden-spotx Can you add some detail around the way you are approaching this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhettler opened a new issue #4775: Users should't see databases with no privileges in Upload CSV dialog
jhettler opened a new issue #4775: Users should't see databases with no privileges in Upload CSV dialog URL: https://github.com/apache/incubator-superset/issues/4775 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.24.0 ### Expected results User should see only databases with _database access_ privilege assigned in Upload CSV dialog. ### Actual results User see all databases listed in Upload CSV dialog regardless of privileges. ### Steps to reproduce 1. Create more then one database connection. 2. Assign privileges to one of them and remove privilege all_database_access. 3. Try to open Source/Upload CSV dialog. 4. Check the listbox with databases This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aleksi75 opened a new issue #4776: [Druid] Superset not working with Druid when 'Druid Basic Security' is activated
aleksi75 opened a new issue #4776: [Druid] Superset not working with Druid when 'Druid Basic Security' is activated URL: https://github.com/apache/incubator-superset/issues/4776 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and included it here as text if any - [x ] I have reproduced the issue with at least the latest released version of superset - [x ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.24.0 ### Expected results Data is queried from Druid broker and shown in chart ### Actual results We are using Druid 0.12.0 and testing the new Druid Basic Security extension in our DEV zone. The Feature is new but working well. In connection with Superset we are running into troubles, because there is no (known) possibility to configure the data (user, pwd) for the auth header. We also tested a more old school variation with prepending user and pwd to the url as seen in example below (sry I am not able/allowed to post a screenshot): Coordinator Host:**admin:admin@host1337** Coordinator Port:8081 Coordinator Endpoint: druid/coordinator/v1/metadata Broker Host:**admin:admin@host1337** Broker Port: 8082 Broker Endpoint: druid/v2 This seems to work with coordinator, we are able to scan datasources and refreshing metadata. In case of the broker this approach did not work, after running a query a chart we get: Traceback (most recent call last): File "/opt/venv/lib/python2.7/site-packages/superset/viz.py", line 329, in get_df_payload df = self.get_df(query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/viz.py", line 142, in get_df self.results = self.datasource.query(query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 1238, in query client=client, query_obj=query_obj, phase=2) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 959, in get_query_str return self.run_query(client=client, phase=phase, **query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 1126, in run_query client.timeseries(**qry) File "/opt/venv/lib/python2.7/site-packages/pydruid/client.py", line 167, in timeseries return self._post(query) File "/opt/venv/lib/python2.7/site-packages/pydruid/client.py", line 484, in _post res = urllib.request.urlopen(req) File "/usr/lib64/python2.7/urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "/usr/lib64/python2.7/urllib2.py", line 431, in open response = self._open(req, data) File "/usr/lib64/python2.7/urllib2.py", line 449, in _open '_open', req) File "/usr/lib64/python2.7/urllib2.py", line 409, in _call_chain result = func(*args) File "/usr/lib64/python2.7/urllib2.py", line 1244, in http_open return self.do_open(httplib.HTTPConnection, req) File "/usr/lib64/python2.7/urllib2.py", line 1214, in do_open raise URLError(err) URLError: For us it seems that prepending user and pwd to the url is not possible with urllib2.py. On the other hand, without them we get an auth error. Traceback (most recent call last): File "/opt/venv/lib/python2.7/site-packages/superset/viz.py", line 329, in get_df_payload df = self.get_df(query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/viz.py", line 142, in get_df self.results = self.datasource.query(query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 1238, in query client=client, query_obj=query_obj, phase=2) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 959, in get_query_str return self.run_query(client=client, phase=phase, **query_obj) File "/opt/venv/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 1126, in run_query client.timeseries(**qry) File "/opt/venv/lib/python2.7/site-packages/pydruid/client.py", line 167, in timeseries return self._post(query) File "/opt/venv/lib/python2.7/site-packages/pydruid/client.py", line 498, in _post e, err, json.dumps(query.query_dict, indent=4))) IOError: HTTP Error 401: Unauthorized You may correct me, but at the moment Superset and Druid with auth enabled is not working? ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For
[GitHub] syzuhdi commented on issue #4770: Cannot display Time Series Line Chart
syzuhdi commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379170928 Thank you @jhettler. It works for us. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4777: [doc] module header for controls.jsx and visTypes.jsx
mistercrunch opened a new pull request #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] guillaumewibaux commented on issue #2731: Give users the rights to change their password
guillaumewibaux commented on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-379314959 I am not sure but I am afraid there is a mismatch between ResetMyPasswordView and ResetPasswordView. With the defaults Gamma and Alpha roles, it's not possible to access the user info page (profile page) nor see the reset password button on this page. Maybe it's been fixed in later releases but I haven't found any issue on the matter. I was able to grant access to the profile and reset password pages only by granting permission sthat are more supposed to be admin permissions and yes you can change other user passwords then... E.g: resetPasswordView (get + post) is necessary to see the rest button on the profile page... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4747: [WiP] Download Dashboards as PDF
mistercrunch commented on a change in pull request #4747: [WiP] Download
Dashboards as PDF
URL:
https://github.com/apache/incubator-superset/pull/4747#discussion_r179802837
##
File path: superset/assets/javascripts/dashboard/components/Header.jsx
##
@@ -68,6 +69,19 @@ class Header extends React.PureComponent {
{btnText}
);
}
+ renderDownloadButton() {
+// TODO: review button style
+const btnText = 'Download';
Review comment:
`t('My translated string')`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4771: [druid] fix 'Unorderable types' when col has nuls
codecov-io commented on issue #4771: [druid] fix 'Unorderable types' when col has nuls URL: https://github.com/apache/incubator-superset/pull/4771#issuecomment-379302137 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=h1) Report > Merging [#4771](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4771 +/- ## = + Coverage 72.59% 72.6% +<.01% = Files 205 205 Lines 15401 15406 +5 Branches 11831183 = + Hits11180 11185 +5 Misses 42184218 Partials3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4771/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.73% <100%> (+0.11%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=footer). Last update [92230b8...5e4888a](https://codecov.io/gh/apache/incubator-superset/pull/4771?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty
mistercrunch commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty URL: https://github.com/apache/incubator-superset/issues/4635#issuecomment-379309387 `0.24.0` is out, closing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration
mistercrunch commented on a change in pull request #4755: Pass granularity from
backend to frontend as ISO duration
URL:
https://github.com/apache/incubator-superset/pull/4755#discussion_r179802253
##
File path: superset/assets/javascripts/explore/stores/controls.jsx
##
@@ -699,21 +699,21 @@ export const controls = {
freeForm: true,
label: t('Time Granularity'),
default: 'one day',
-choices: formatSelectOptions([
- 'all',
- '5 seconds',
- '30 seconds',
- '1 minute',
- '5 minutes',
- '1 hour',
- '6 hour',
- '1 day',
- '7 days',
- 'week',
- 'week_starting_sunday',
- 'week_ending_saturday',
- 'month',
-]),
+choices: [
+ [null, 'all'],
+ ['PT5S', '5 seconds'],
Review comment:
@betodealmeida ^ please confirm and I'll merge
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF
mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379299458 The absolute easiest here would be to 1) hide the menu bar, this can be done with the `=true` URL param, but perhaps could be done in JS on the fly with some JQuery-hack so that we don't have to do a round-trip/full refresh 2) show the user how to `Print as PDF`, maybe just link to a website that explains that well with browser-specific detection and tutorial This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF
mistercrunch commented on issue #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747#issuecomment-379299458 The absolute easiest here would be to 1) hide the menu bar, this can be done with the `=true` URL param, but perhaps could be done in JS on the fly with some JQuery-hack 2) show the user how to `Print as PDF`, maybe just link to a website that explains that well with browser-specific detection and tutorial This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx
codecov-io commented on issue #4777: [doc] module header for controls.jsx and visTypes.jsx URL: https://github.com/apache/incubator-superset/pull/4777#issuecomment-379300038 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=h1) Report > Merging [#4777](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4777 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4777/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4777/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=footer). Last update [92230b8...bb2ea8d](https://codecov.io/gh/apache/incubator-superset/pull/4777?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart
mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379300129 This may help these issues: https://github.com/apache/incubator-superset/pull/4724 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty
mistercrunch closed issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty URL: https://github.com/apache/incubator-superset/issues/4635 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.
lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-379319482 @mistercrunch @vylc, I have tested command + C behaviour. If we double click on column and copy then it copies complete text of wide column. so copying doesn't seems to be issue. Should I just update 100px to 200px ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.
codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging [#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr=desc) will **increase** coverage by `0.2%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4758 +/- ## = + Coverage 72.39% 72.59% +0.2% = Files 205 205 Lines 1539415401 +7 Branches 1182 1183 +1 = + Hits1114411180 +36 + Misses 4247 4218 -29 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=) | `91.95% <100%> (ø)` | :arrow_up: | | [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <0%> (-1.55%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.54% <0%> (-0.05%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.29% <0%> (ø)` | :arrow_up: | | [...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==) | `99.24% <0%> (ø)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.3% <0%> (+0.05%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.48% <0%> (+2.33%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=footer). Last update [9a79d33...e8d5feb](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
