[GitHub] xrmx opened a new pull request #4831: db_engine_specs: use correct sqlite week time grain

2018-04-15 Thread GitBox
xrmx opened a new pull request #4831: db_engine_specs: use correct sqlite week time grain URL: https://github.com/apache/incubator-superset/pull/4831 We want the week of year %W and not the day of week %w when using week as time grain. Reference:

[GitHub] codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file

2018-04-15 Thread GitBox
codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381390257 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4829?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file

2018-04-15 Thread GitBox
codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381390257 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4829?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file

2018-04-15 Thread GitBox
codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381390257 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4829?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file

2018-04-15 Thread GitBox
codecov-io commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381390257 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4829?src=pr=h1) Report > Merging

[GitHub] john-bodley opened a new pull request #4828: [travis] Fixing environments

2018-04-15 Thread GitBox
john-bodley opened a new pull request #4828: [travis] Fixing environments URL: https://github.com/apache/incubator-superset/pull/4828 Apologies I had misconfigured the Travis environments where `py{27,34}-{flake8,pylint}` didn't exist and thus defaulted to running the default `[testenv]`

[GitHub] timifasubaa opened a new pull request #4829: [import csv] ensure directory exists before saving csv file

2018-04-15 Thread GitBox
timifasubaa opened a new pull request #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829 Some users complained of the error while uploading CSV whereby the first uploading phase fails because directory does not

[GitHub] xrmx opened a new issue #4830: time grains broken in sqlite

2018-04-15 Thread GitBox
xrmx opened a new issue #4830: time grains broken in sqlite URL: https://github.com/apache/incubator-superset/issues/4830 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as

[GitHub] codecov-io commented on issue #4828: [travis] Fixing environments

2018-04-15 Thread GitBox
codecov-io commented on issue #4828: [travis] Fixing environments URL: https://github.com/apache/incubator-superset/pull/4828#issuecomment-381410242 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4828?src=pr=h1) Report > Merging

[GitHub] deepak-goel commented on issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG'

2018-04-15 Thread GitBox
deepak-goel commented on issue #4785: Not able to get the debug logs or python stacktrace on errors even after LOG_LEVEL is set to 'DEBUG' URL: https://github.com/apache/incubator-superset/issues/4785#issuecomment-381429406 Glad you got this working. Here is the pip freeze output, just

[GitHub] graceguo-supercat commented on a change in pull request #4791: apply new Dashboard builder to dashboard

2018-04-15 Thread GitBox
graceguo-supercat commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r181592105 ## File path: superset/assets/javascripts/chart/Chart.jsx ## @@ -5,6 +5,7 @@ import

[GitHub] codecov-io commented on issue #4827: [config] Updating configuration logic

2018-04-15 Thread GitBox
codecov-io commented on issue #4827: [config] Updating configuration logic URL: https://github.com/apache/incubator-superset/pull/4827#issuecomment-381447164 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4827?src=pr=h1) Report > Merging

[GitHub] Neuliaus commented on issue #4818: Viz Plugins and Widget Set

2018-04-15 Thread GitBox
Neuliaus commented on issue #4818: Viz Plugins and Widget Set URL: https://github.com/apache/incubator-superset/issues/4818#issuecomment-381449207 Cool thanks , we are working ins some stuff here as well but I'll get someone to look at the link and work on it , Cheers Oz

[GitHub] mistercrunch closed pull request #4831: db_engine_specs: use correct sqlite week time grain

2018-04-15 Thread GitBox
mistercrunch closed pull request #4831: db_engine_specs: use correct sqlite week time grain URL: https://github.com/apache/incubator-superset/pull/4831 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mistercrunch commented on issue #4828: [travis] Fixing environments

2018-04-15 Thread GitBox
mistercrunch commented on issue #4828: [travis] Fixing environments URL: https://github.com/apache/incubator-superset/pull/4828#issuecomment-381445917 LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

2018-04-15 Thread GitBox
graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here are my thoughts: 1. I don't like the idea of delete v1, it will destroy code history

[GitHub] john-bodley closed pull request #4828: [travis] Fixing environments

2018-04-15 Thread GitBox
john-bodley closed pull request #4828: [travis] Fixing environments URL: https://github.com/apache/incubator-superset/pull/4828 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign