[GitHub] joriewong commented on issue #3510: failed to install
joriewong commented on issue #3510: failed to install URL: https://github.com/apache/incubator-superset/pull/3510#issuecomment-331356534  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint
coveralls commented on issue #3513: Feature: query string API endpoint URL: https://github.com/apache/incubator-superset/pull/3513#issuecomment-331355311 [](https://coveralls.io/builds/13384038) Coverage increased (+0.2%) to 69.739% when pulling **977680bb9d731936e1e1ce72c55df9f03ae21e10 on Mogball:mogball/feature/query_apiendpoint** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3508: Feature: Datepicker and time granularity options to dashboard filters
coveralls commented on issue #3508: Feature: Datepicker and time granularity options to dashboard filters URL: https://github.com/apache/incubator-superset/pull/3508#issuecomment-331304629 [](https://coveralls.io/builds/13380915) Coverage increased (+0.08%) to 69.613% when pulling **d764fd2eb0646993947d44236385285dd8610348 on Mogball:mogball/feature/dashboard_filter** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3508: Feature: Datepicker and time granularity options to dashboard filters
coveralls commented on issue #3508: Feature: Datepicker and time granularity options to dashboard filters URL: https://github.com/apache/incubator-superset/pull/3508#issuecomment-331303844 [](https://coveralls.io/builds/13380860) Coverage increased (+0.09%) to 69.622% when pulling **d764fd2eb0646993947d44236385285dd8610348 on Mogball:mogball/feature/dashboard_filter** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros
fabianmenges commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros URL: https://github.com/apache/incubator-superset/pull/3512#issuecomment-331288385 If you think it makes more sense to enhance resampling on the server side (e.g. support the various period types, derive it from the time grain) I'm happy to improve that experience instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros
coveralls commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros URL: https://github.com/apache/incubator-superset/pull/3512#issuecomment-331278200 [](https://coveralls.io/builds/13378195) Coverage remained the same at 69.535% when pulling **1f477f6475a0bc3526175b0ac00183099bcfbaad on tc-dc:fmegnes/zeros** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges opened a new pull request #3512: Feature: Making data gaps visible in line charts by inserting zeros
fabianmenges opened a new pull request #3512: Feature: Making data gaps visible in line charts by inserting zeros URL: https://github.com/apache/incubator-superset/pull/3512 ## Description For many different kinds of metrics you might want to immediately see that you did not record any values in a given time period (e.g. not registering any user impressions for the first minute of every hour). With the current line chart visualization this would be very difficult to spot, you would have to spot a "missing" marker: 1 out of 60 every hour. This merge request adds a "insert zeros" control that takes the current selected `Time Grain` into account to insert 0s into the time series data if the time series did not contain any data points for a given period specified by the `Time Grain`. ## Example: We are visualizing the `birth_name` example datasource. As you can see looking at the markers on the first screenshot we have one data point per year.  As you can see we selected the time grain "month". Checking the box "Insert Zeros" will now scan the time series if two data points are more than a month apart from one another it will insert a 0 data point into the time series accordingly.  ## Features: - Works with Druid and Sql - Works with Grouped and Filtered Data - I the time grain is set to "Time Column" or "All" it applies a heuristic for the correct period length. - It will only insert a minimal number of 0s to make the missing data visible. I added unit tests for the granularity/time-grain/period parsing. Happy to add a unit test for the adding 0 logic, I couldn't find a good place to add the spec file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx opened a new issue #3511: i18n documentation is confusing
xrmx opened a new issue #3511: i18n documentation is confusing URL: https://github.com/apache/incubator-superset/issues/3511 Documentation in CONTRIBUTING documents two way of getting the translation: one with pybabel and the other one with fabmanager babel-extract. We should settle on one but i don't know which one. While at it we should probably refresh the localization after the js translation merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331246121 [](https://coveralls.io/builds/13376740) Coverage remained the same at 69.535% when pulling **c696942fb29479806975a0c389e80c630aca78af on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331246123 [](https://coveralls.io/builds/13376740) Coverage remained the same at 69.535% when pulling **c696942fb29479806975a0c389e80c630aca78af on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on a change in pull request #3509: Add Table performance improvements
Mogball commented on a change in pull request #3509: Add Table performance
improvements
URL:
https://github.com/apache/incubator-superset/pull/3509#discussion_r140281124
##
File path: superset/models/core.py
##
@@ -743,6 +744,16 @@ def get_perm(self):
return (
"[{obj.database_name}].(id:{obj.id})").format(obj=self)
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
Review comment:
There's a bit more overhead to it, plus creating an engine just to get the
dialect and then ignoring the instance seems wasteful.
These few lines are what `create_engine` does to determine dialect anyway.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jaylindquist commented on issue #3498: No permission check for save_or_overwrite_slice allows users to manipulate dashboards
jaylindquist commented on issue #3498: No permission check for save_or_overwrite_slice allows users to manipulate dashboards URL: https://github.com/apache/incubator-superset/issues/3498#issuecomment-331150283 @xmrx The documentation implies that `all datasource access of all_datasource_access` allows users to see slices using all datasources, not create slices or create dashboards From the security documentation: > * Data source: For each data source, a permission is created. If the user does not have the all_datasource_access permission granted, the user will only be able to see Slices or explore the data sources that are granted to them I'm reading that as "Granting `datasource access on ` lets the user see Slices or explore data on that specific data source. Granting `all_datasource_access` lets the user see Slices or explore data on all data sources" Meanwhile, Model permissions are used to let a user add / edit slices and dashboards. If I don't give the user `can_add` on Dashboards, then they are not allowed to create dashboards. > * Model & action: models are entities like Dashboard, Slice, or User. Each model has a fixed set of permissions, like can_edit, can_show, can_delete, can_list, can_add, and so on. By adding can_delete on Dashboard to a role, and granting that role to a user, this user will be able to delete dashboards. Am I reading that wrong? If so, is there no way to let users see existing dashboards while preventing them from creating dashboards? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.
coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend. URL: https://github.com/apache/incubator-superset/pull/3504#issuecomment-331148430 [](https://coveralls.io/builds/13370955) Coverage increased (+0.03%) to 69.567% when pulling **4c728647e46355ed1055b675e7d535c1e6a700c8 on tc-dc:fmenges/verbose_names_timeseries** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.
coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend. URL: https://github.com/apache/incubator-superset/pull/3504#issuecomment-331148427 [](https://coveralls.io/builds/13370955) Coverage increased (+0.03%) to 69.567% when pulling **4c728647e46355ed1055b675e7d535c1e6a700c8 on tc-dc:fmenges/verbose_names_timeseries** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.
coveralls commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend. URL: https://github.com/apache/incubator-superset/pull/3504#issuecomment-331148429 [](https://coveralls.io/builds/13370955) Coverage increased (+0.03%) to 69.567% when pulling **4c728647e46355ed1055b675e7d535c1e6a700c8 on tc-dc:fmenges/verbose_names_timeseries** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #3427: Cannot run queries in SQL Lab with a DB that has timestamps
fabianmenges commented on issue #3427: Cannot run queries in SQL Lab with a DB that has timestamps URL: https://github.com/apache/incubator-superset/issues/3427#issuecomment-331145539 This should be fixed #2937 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #3502: Time Series Annotation Layer
fabianmenges commented on issue #3502: Time Series Annotation Layer URL: https://github.com/apache/incubator-superset/issues/3502#issuecomment-331145108 I'm working on something like this. I'll keep you posted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vtyran commented on issue #519: Ordering on X axis on the distribution bar chart
vtyran commented on issue #519: Ordering on X axis on the distribution bar chart URL: https://github.com/apache/incubator-superset/issues/519#issuecomment-331118985 Still only able to sort alphabetically, not by numerical x value. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vtyran commented on issue #519: Ordering on X axis on the distribution bar chart
vtyran commented on issue #519: Ordering on X axis on the distribution bar chart URL: https://github.com/apache/incubator-superset/issues/519#issuecomment-331118985 Still only able to sort alphabetically, not by numerical x value. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 commented on issue #3271: date type field display error
macfly1202 commented on issue #3271: date type field display error URL: https://github.com/apache/incubator-superset/issues/3271#issuecomment-331112283 I've got the same issue exactly on mysql and superset 0.19.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
URL:
https://github.com/apache/incubator-superset/issues/2950#issuecomment-331099646
SQLAlchemy URI:
hive://localhost:1
I solved this problem by follow reference. Hoping can help :-)
https://pypi.python.org/pypi/PyHive
```
from sqlalchemy import *
from sqlalchemy.engine import create_engine
from sqlalchemy.schema import *
engine = create_engine('hive://localhost:1/default')
logs = Table('my_awesome_data', MetaData(bind=engine), autoload=True)
print select([func.count('*')], from_obj=logs).scalar()
```
Requirements
Install using
pip install pyhive[hive] for the Hive interface and
pip install pyhive[presto] for the Presto interface.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
URL:
https://github.com/apache/incubator-superset/issues/2950#issuecomment-331099646
SQLAlchemy URI:
hive://localhost:1
I solved this problem by follow reference. Hope follow info. could help
https://pypi.python.org/pypi/PyHive
```
from sqlalchemy import *
from sqlalchemy.engine import create_engine
from sqlalchemy.schema import *
engine = create_engine('hive://localhost:1/default')
logs = Table('my_awesome_data', MetaData(bind=engine), autoload=True)
print select([func.count('*')], from_obj=logs).scalar()
```
Requirements
Install using
pip install pyhive[hive] for the Hive interface and
pip install pyhive[presto] for the Presto interface.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
JazzChen commented on issue #2950: jdbc+hive in sqlalchemy URI is not working
URL:
https://github.com/apache/incubator-superset/issues/2950#issuecomment-331099646
SQLAlchemy URI:
hive://localhost:1
I solved this problem by follow reference. Hope follow info. could help
https://pypi.python.org/pypi/PyHive
from sqlalchemy import *
from sqlalchemy.engine import create_engine
from sqlalchemy.schema import *
# Hive
engine = create_engine('hive://localhost:1/default')
logs = Table('my_awesome_data', MetaData(bind=engine), autoload=True)
print select([func.count('*')], from_obj=logs).scalar()
Requirements
Install using
pip install pyhive[hive] for the Hive interface and
pip install pyhive[presto] for the Presto interface.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vnnw commented on issue #3272: Filter box should also allow custom order
vnnw commented on issue #3272: Filter box should also allow custom order URL: https://github.com/apache/incubator-superset/issues/3272#issuecomment-331087090 Strongly agreed! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #3510: failed to install
xrmx commented on issue #3510: failed to install URL: https://github.com/apache/incubator-superset/pull/3510#issuecomment-331084027 The there's something wrong with your installation as the path should be there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vnnw commented on issue #1055: How to sort table by timestamp by default?
vnnw commented on issue #1055: How to sort table by timestamp by default?
URL:
https://github.com/apache/incubator-superset/issues/1055#issuecomment-331079554
Care to give more details on how to edit the code to make the table order by
timestamp by default?
I tried to modify the code as below but didn't work.
```
datatable.column(data.columns.indexOf('__timestamp')).order('asc').draw();
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] joriewong commented on issue #3510: failed to install
joriewong commented on issue #3510: failed to install URL: https://github.com/apache/incubator-superset/pull/3510#issuecomment-331081834 centos This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3510: failed to install
coveralls commented on issue #3510: failed to install URL: https://github.com/apache/incubator-superset/pull/3510#issuecomment-331081021 [](https://coveralls.io/builds/13367168) Coverage remained the same at 69.535% when pulling **283ddcb27c0bc22de85c9cf9ceb7beab76a8b146 on joriewong:patch-1** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vnnw commented on issue #1055: How to sort table by timestamp by default?
vnnw commented on issue #1055: How to sort table by timestamp by default? URL: https://github.com/apache/incubator-superset/issues/1055#issuecomment-331079554 Care to give more details on how to edit the code to make the table order by timestamp by default? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331064068 [](https://coveralls.io/builds/13366387) Coverage decreased (-0.1%) to 69.386% when pulling **50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331063829 [](https://coveralls.io/builds/13366321) Coverage remained the same at 69.535% when pulling **50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331063825 [](https://coveralls.io/builds/13366321) Coverage remained the same at 69.535% when pulling **50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3466: Allow user update slice title in visualize flow
coveralls commented on issue #3466: Allow user update slice title in visualize flow URL: https://github.com/apache/incubator-superset/pull/3466#issuecomment-331063827 [](https://coveralls.io/builds/13366321) Coverage remained the same at 69.535% when pulling **50852037e9ee5c8e9562fae26ff7f1269d11ca90 on graceguo-supercat:gg-AllowUpdateTitleOnVisualize** into **9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
