[GitHub] graceguo-supercat commented on a change in pull request #3581: Dashboard refactory

2017-10-23 Thread GitBox
graceguo-supercat commented on a change in pull request #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#discussion_r146447222 ## File path: superset/assets/javascripts/dashboard/components/Slice.jsx ## @@ -0,0 +1,113 @@ +/* eslint

[GitHub] graceguo-supercat commented on a change in pull request #3581: Dashboard refactory

2017-10-23 Thread GitBox
graceguo-supercat commented on a change in pull request #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#discussion_r146447529 ## File path: superset/assets/javascripts/dashboard/actions.js ## @@ -0,0 +1,171 @@ +/* global notify */

[GitHub] graceguo-supercat commented on a change in pull request #3581: Dashboard refactory

2017-10-23 Thread GitBox
graceguo-supercat commented on a change in pull request #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#discussion_r146447540 ## File path: superset/assets/javascripts/dashboard/actions.js ## @@ -0,0 +1,171 @@ +/* global notify */

[GitHub] graceguo-supercat commented on a change in pull request #3581: Dashboard refactory

2017-10-23 Thread GitBox
graceguo-supercat commented on a change in pull request #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#discussion_r146447222 ## File path: superset/assets/javascripts/dashboard/components/Slice.jsx ## @@ -0,0 +1,113 @@ +/* eslint

[GitHub] coveralls commented on issue #3711: fix the slice permission issue after user click-edit new slice title

2017-10-23 Thread GitBox
coveralls commented on issue #3711: fix the slice permission issue after user click-edit new slice title URL: https://github.com/apache/incubator-superset/pull/3711#issuecomment-338864030 [![Coverage

[GitHub] graceguo-supercat commented on a change in pull request #3581: Dashboard refactory

2017-10-23 Thread GitBox
graceguo-supercat commented on a change in pull request #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#discussion_r146447069 ## File path: superset/assets/javascripts/dashboard/components/SliceContainer.jsx ## @@ -0,0 +1,198 @@ +/*

[GitHub] graceguo-supercat closed pull request #3698: fixing the datasource inconsistence bug in visualize flow

2017-10-23 Thread GitBox
graceguo-supercat closed pull request #3698: fixing the datasource inconsistence bug in visualize flow URL: https://github.com/apache/incubator-superset/pull/3698 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] graceguo-supercat opened a new pull request #3711: fix the slice permission issue after user click-edit new slice title

2017-10-23 Thread GitBox
graceguo-supercat opened a new pull request #3711: fix the slice permission issue after user click-edit new slice title URL: https://github.com/apache/incubator-superset/pull/3711 step to reproduce: 1. user start visualize a query from sql lab, and landing in explore view. At this

[GitHub] coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710#issuecomment-338853029 [![Coverage

[GitHub] coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710#issuecomment-338848518 [![Coverage

[GitHub] coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710#issuecomment-338848520 [![Coverage

[GitHub] coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710#issuecomment-338848519 [![Coverage

[GitHub] coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
coveralls commented on issue #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710#issuecomment-338848521 [![Coverage

[GitHub] zhouyao1994 opened a new pull request #3710: add some lables that have been use in the view of "show Slice" to tanslates

2017-10-23 Thread GitBox
zhouyao1994 opened a new pull request #3710: add some lables that have been use in the view of "show Slice" to tanslates URL: https://github.com/apache/incubator-superset/pull/3710 add some lables that have been use in the view of "show Slice" to tanslates add some lines to

[GitHub] annusri commented on issue #3709: Intall Superset same instance in different server

2017-10-23 Thread GitBox
annusri commented on issue #3709: Intall Superset same instance in different server URL: https://github.com/apache/incubator-superset/issues/3709#issuecomment-338825230 @xrmx - ok. so everything is in the superset.db. I'm getting the below error after following this steps.

[GitHub] mistercrunch closed pull request #3683: [cleanup] removing print() artefacts

2017-10-23 Thread GitBox
mistercrunch closed pull request #3683: [cleanup] removing print() artefacts URL: https://github.com/apache/incubator-superset/pull/3683 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mistercrunch closed pull request #3702: Add support for IE 11 for markup slices

2017-10-23 Thread GitBox
mistercrunch closed pull request #3702: Add support for IE 11 for markup slices URL: https://github.com/apache/incubator-superset/pull/3702 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] mistercrunch commented on issue #2953: [WiP] ElasticSearch connector integration

2017-10-23 Thread GitBox
mistercrunch commented on issue #2953: [WiP] ElasticSearch connector integration URL: https://github.com/apache/incubator-superset/pull/2953#issuecomment-338816382 I made a fair amount of progress, the skeleton of the work that needs to get done is here. I'm not planning on working on

[GitHub] mistercrunch closed issue #3709: Intall Superset same instance in different server

2017-10-23 Thread GitBox
mistercrunch closed issue #3709: Intall Superset same instance in different server URL: https://github.com/apache/incubator-superset/issues/3709 This is an automated message from the Apache Git Service. To respond to the

[GitHub] xrmx commented on issue #3709: Intall Superset same instance in different server

2017-10-23 Thread GitBox
xrmx commented on issue #3709: Intall Superset same instance in different server URL: https://github.com/apache/incubator-superset/issues/3709#issuecomment-338802776 It's everything in the db This is an automated message

[GitHub] annusri opened a new issue #3709: Intall Superset same instance in different server

2017-10-23 Thread GitBox
annusri opened a new issue #3709: Intall Superset same instance in different server URL: https://github.com/apache/incubator-superset/issues/3709 I installed Superset few months back on Server A. I created few Slices/Dashboard. Now I'm trying to install Superset on Server B. But I

[GitHub] sureshrag3 commented on issue #2953: [WiP] ElasticSearch connector integration

2017-10-23 Thread GitBox
sureshrag3 commented on issue #2953: [WiP] ElasticSearch connector integration URL: https://github.com/apache/incubator-superset/pull/2953#issuecomment-338762401 @mistercrunch - Thanks for working on this. Were you able to make any progress on this feature? We are eagerly waiting to

[GitHub] graceguo-supercat closed pull request #3693: defaultSort should be false when no sort is necessary

2017-10-23 Thread GitBox
graceguo-supercat closed pull request #3693: defaultSort should be false when no sort is necessary URL: https://github.com/apache/incubator-superset/pull/3693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] graceguo-supercat commented on issue #3693: defaultSort should be false when no sort is necessary

2017-10-23 Thread GitBox
graceguo-supercat commented on issue #3693: defaultSort should be false when no sort is necessary URL: https://github.com/apache/incubator-superset/pull/3693#issuecomment-338749616 LGTM! This is an automated message from

[GitHub] coveralls commented on issue #3701: [form-data] Quoting /slice/ form data

2017-10-23 Thread GitBox
coveralls commented on issue #3701: [form-data] Quoting /slice/ form data URL: https://github.com/apache/incubator-superset/pull/3701#issuecomment-338345991 [![Coverage Status](https://coveralls.io/builds/13814379/badge)](https://coveralls.io/builds/13814379) Coverage

[GitHub] coveralls commented on issue #3702: Add support for IE 11 for markup slices

2017-10-23 Thread GitBox
coveralls commented on issue #3702: Add support for IE 11 for markup slices URL: https://github.com/apache/incubator-superset/pull/3702#issuecomment-338720073 [![Coverage Status](https://coveralls.io/builds/13845471/badge)](https://coveralls.io/builds/13845471) Coverage

[GitHub] jaylindquist commented on a change in pull request #3702: Add support for IE 11 for markup slices

2017-10-23 Thread GitBox
jaylindquist commented on a change in pull request #3702: Add support for IE 11 for markup slices URL: https://github.com/apache/incubator-superset/pull/3702#discussion_r146313414 ## File path: superset/assets/visualizations/markup.js ## @@ -23,9 +24,11 @@ function

[GitHub] kangjin2014 commented on issue #3681: OSError: [Errno 5] Input/output error

2017-10-23 Thread GitBox
kangjin2014 commented on issue #3681: OSError: [Errno 5] Input/output error URL: https://github.com/apache/incubator-superset/issues/3681#issuecomment-338700408 me too. who could help? This is an automated message from the

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338692866 Thinking about it: We use information that is at this point only present in the JSON stored in the cache. If the

[GitHub] gsemyonov opened a new issue #3708: Continuous timeline for Time Series plots

2017-10-23 Thread GitBox
gsemyonov opened a new issue #3708: Continuous timeline for Time Series plots URL: https://github.com/apache/incubator-superset/issues/3708 ### Superset version 0.20.4 ### Expected results When I display my data on time series plot, I want to see the **continuous timeline**

[GitHub] gsemyonov opened a new issue #3707: Timezone offset doesn't work for filtering and grouping in PgSQL

2017-10-23 Thread GitBox
gsemyonov opened a new issue #3707: Timezone offset doesn't work for filtering and grouping in PgSQL URL: https://github.com/apache/incubator-superset/issues/3707 ### Superset version 0.20.4 ### Expected results When I set the Offset (timezone) in the table properties, I

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338639157 @xrmx: Spaces are fixed now. However, unfortunately I have no idea how to add a test, what needs to be

[GitHub] coveralls commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
coveralls commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338667644 [![Coverage Status](https://coveralls.io/builds/13842306/badge)](https://coveralls.io/builds/13842306)

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338639157 @xrmx: I did not introduce any whitespace. Could you please specify? Furthermore I have no idea how to add a

[GitHub] xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices

2017-10-23 Thread GitBox
xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices URL: https://github.com/apache/incubator-superset/pull/3702#discussion_r146259114 ## File path: superset/assets/visualizations/markup.js ## @@ -23,9 +24,11 @@ function

[GitHub] xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices

2017-10-23 Thread GitBox
xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices URL: https://github.com/apache/incubator-superset/pull/3702#discussion_r146259151 ## File path: superset/assets/visualizations/markup.js ## @@ -23,9 +24,11 @@ function

[GitHub] jaylindquist commented on issue #3672: URL link to parent or blank does not work within Markup or Separator widget

2017-10-23 Thread GitBox
jaylindquist commented on issue #3672: URL link to parent or blank does not work within Markup or Separator widget URL: https://github.com/apache/incubator-superset/issues/3672#issuecomment-338651152 @xrmx PR #3702 opened to fix this. The issue was the iframe was sandboxing and

[GitHub] jaylindquist commented on issue #3387: 0.19.1 Markup chart type does not display on I.E.

2017-10-23 Thread GitBox
jaylindquist commented on issue #3387: 0.19.1 Markup chart type does not display on I.E. URL: https://github.com/apache/incubator-superset/issues/3387#issuecomment-338650736 @xrmx PR #3702 Opened This is an automated

Distribution chart lacking "more options", stacked bars, contribution, etc.

2017-10-23 Thread Robert Lawson
Apologies if this has already been asked, but what happened to all the old features of the "Distribution - Bar Chart" viz? Previously we could set up controls that were usable on the dashboard for things like stacked bars and contribution, but this is gone now. Did it go somewhere else or get

[GitHub] chengwei1231 commented on issue #1519: Choose encoding when export csv

2017-10-23 Thread GitBox
chengwei1231 commented on issue #1519: Choose encoding when export csv URL: https://github.com/apache/incubator-superset/issues/1519#issuecomment-338630415 I modify config.py: CSV_EXPORT = { 'encoding': 'gbk', } But it doesn't work.Using vim to view the downloaded file:

[GitHub] andor-pierdelacabeza opened a new issue #3706: Wrong/incoherent permision on ALPHA role for 'Dashboard import'

2017-10-23 Thread GitBox
andor-pierdelacabeza opened a new issue #3706: Wrong/incoherent permision on ALPHA role for 'Dashboard import' URL: https://github.com/apache/incubator-superset/issues/3706 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset

[GitHub] xrmx commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
xrmx commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338624518 Add tests and while at it fixup whitespace in your code (spaces before and after ==).

[GitHub] xrmx commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
xrmx commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338624518 Add tests and while at it fixup whitespace in your code.

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338614185 What am I supposed to do when the **coverage/coveralls** test fails?

[GitHub] dmigo commented on issue #3700: Feature proposal: trim for the bar chart labels

2017-10-23 Thread GitBox
dmigo commented on issue #3700: Feature proposal: trim for the bar chart labels URL: https://github.com/apache/incubator-superset/issues/3700#issuecomment-338428696 @xrmx it might be that after a trim in SQL several different categories will end up in one. e.g. `abcde1` and `abcde2`

[GitHub] dmigo commented on issue #3700: Feature proposal: trim for the bar chart labels

2017-10-23 Thread GitBox
dmigo commented on issue #3700: Feature proposal: trim for the bar chart labels URL: https://github.com/apache/incubator-superset/issues/3700#issuecomment-338428696 @xrmx it might be that after a trim in SQL several different categories will end up in one. e.g. `abcde1` and `abcde2`

[GitHub] coveralls commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
coveralls commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338585419 [![Coverage Status](https://coveralls.io/builds/13837414/badge)](https://coveralls.io/builds/13837414)

[GitHub] rumbin commented on issue #3695: [CSV export] Regression: Inconsistent formatting of arrays and timestamps: Explore vs SQLLab

2017-10-23 Thread GitBox
rumbin commented on issue #3695: [CSV export] Regression: Inconsistent formatting of arrays and timestamps: Explore vs SQLLab URL: https://github.com/apache/incubator-superset/issues/3695#issuecomment-338581879 Decided to split the two issues: * DATETIME formatting in SQLLab: see #3704

[GitHub] rumbin opened a new pull request #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin opened a new pull request #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705 Fixes #3704. I'm not quite sure _why_ this is for the CSV export in SQLLab, while the CSV export in Explore handles DATETIME

[GitHub] coveralls commented on issue #3581: Dashboard refactory

2017-10-23 Thread GitBox
coveralls commented on issue #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#issuecomment-338578138 [![Coverage Status](https://coveralls.io/builds/13837005/badge)](https://coveralls.io/builds/13837005) Coverage remained the same at

[GitHub] coveralls commented on issue #3581: Dashboard refactory

2017-10-23 Thread GitBox
coveralls commented on issue #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#issuecomment-338578137 [![Coverage Status](https://coveralls.io/builds/13837005/badge)](https://coveralls.io/builds/13837005) Coverage remained the same at

[GitHub] coveralls commented on issue #3581: Dashboard refactory

2017-10-23 Thread GitBox
coveralls commented on issue #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#issuecomment-338578140 [![Coverage Status](https://coveralls.io/builds/13837005/badge)](https://coveralls.io/builds/13837005) Coverage remained the same at

[GitHub] coveralls commented on issue #3581: Dashboard refactory

2017-10-23 Thread GitBox
coveralls commented on issue #3581: Dashboard refactory URL: https://github.com/apache/incubator-superset/pull/3581#issuecomment-338578139 [![Coverage Status](https://coveralls.io/builds/13837005/badge)](https://coveralls.io/builds/13837005) Coverage remained the same at

[GitHub] rumbin opened a new issue #3704: [SQLLab] datetime columns interpreted as strings when exporting _cached_ result to CSV

2017-10-23 Thread GitBox
rumbin opened a new issue #3704: [SQLLab] datetime columns interpreted as strings when exporting _cached_ result to CSV URL: https://github.com/apache/incubator-superset/issues/3704 ### Foreword I reported this issue in #3695, together with a related one. As I found out that the two