[GitHub] sanoopmm opened a new issue #4583: Need multiple date filters in slice

sanoopmm opened a new issue #4583: Need multiple date filters in slice URL: https://github.com/apache/incubator-superset/issues/4583 Make sure these boxes are checked before submitting your issue - thank you! - [*] I have checked the superset logs for python stacktraces and included

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests

codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests

codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests

codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests

codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] john-bodley opened a new pull request #4582: [code-climate] Deprecating Code Climate from JavaScript tests

john-bodley opened a new pull request #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582 Given that we're now using `codecov` in Travis to process the various coverage reports, this PR deprecates outdated Code

[GitHub] williaster closed pull request #4570: Adding option to visualize negative values in Table view

williaster closed pull request #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] michellethomas opened a new pull request #4581: Making timeseries_limit not required for phase 2

michellethomas opened a new pull request #4581: Making timeseries_limit not required for phase 2 URL: https://github.com/apache/incubator-superset/pull/4581 We have an issue on time series group by queries, if the chart doesn't have a limit, the data is incorrect. It gets run as a phase 1

[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns

codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name

williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371688774 what about just `Superset` in that case? Or `Superset - ${tableName}`?

[GitHub] williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name

williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371688774 what about just "Superset" in that case? Or `Superset - ${tableName}`?

[GitHub] betodealmeida commented on a change in pull request #4572: Legend for deck.gl scatterplot

betodealmeida commented on a change in pull request #4572: Legend for deck.gl scatterplot URL: https://github.com/apache/incubator-superset/pull/4572#discussion_r173347009 ## File path: superset/assets/visualizations/Legend.jsx ## @@ -0,0 +1,42 @@ +import React from

[GitHub] betodealmeida commented on issue #4572: Legend for deck.gl scatterplot

betodealmeida commented on issue #4572: Legend for deck.gl scatterplot URL: https://github.com/apache/incubator-superset/pull/4572#issuecomment-371687175 

[GitHub] JaeGerW2016 opened a new issue #4580: Invalid identifier on visualize After a SQL query

JaeGerW2016 opened a new issue #4580: Invalid identifier on visualize After a SQL query URL: https://github.com/apache/incubator-superset/issues/4580 Invalid identifier on visualize After a SQL query then I View Query and copy it to SQL Editor The doubt is: the same sql can be

[GitHub] michellethomas commented on issue #4579: Removing [dashboard] and [slice] titles to show name

michellethomas commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371666515 @williaster I added that originally but it just shows the table name if you are in explore which might just

[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view

codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging

[GitHub] elibrumbaugh commented on issue #4579: Removing [dashboard] and [slice] titles to show name

elibrumbaugh commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371661615 Good call @williaster ! Thank you for making this happen @michellethomas !!!

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371659614 @williaster @john-bodley I've pushed the change to make coloring turned on as default. Thanks for reviewing the

[GitHub] williaster commented on issue #4570: Adding option to visualize negative values in Table view

williaster commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371654731 thanks @tanvach! @john-bodley and I think this looks good but think coloring should probably be on by default

[GitHub] williaster commented on a change in pull request #4579: Removing [dashboard] and [slice] titles to show name

williaster commented on a change in pull request #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#discussion_r173318329 ## File path: superset/views/core.py ## @@ -1297,7 +1297,7 @@ def explore(self,

[GitHub] timifasubaa commented on issue #4579: Removing [dashboard] and [slice] titles to show name

timifasubaa commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371651462 LGTM This is an automated message from the Apache

[GitHub] codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name

codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371642722 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=h1) Report > Merging

[GitHub] michellethomas opened a new pull request #4579: Removing [dashboard] and [slice] titles to show name

michellethomas opened a new pull request #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579 Showing [dashboard] and [slice] hide the name of the dashboard or slice in the tab. Anyone object to removing these labels?

[GitHub] graceguo-supercat closed issue #4439: URL parameters not saved for a slice in explorer view

graceguo-supercat closed issue #4439: URL parameters not saved for a slice in explorer view URL: https://github.com/apache/incubator-superset/issues/4439 This is an automated message from the Apache Git Service. To respond

[GitHub] graceguo-supercat closed pull request #4578: [Explore] Save custom url parameters when user save slices

graceguo-supercat closed pull request #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] michellethomas commented on issue #4578: [Explore] Save custom url parameters when user save slices

michellethomas commented on issue #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578#issuecomment-371623330 lgtm This is an automated message from

[GitHub] codecov-io commented on issue #4578: [Explore] Save custom url parameters when user save slices

codecov-io commented on issue #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578#issuecomment-371622470 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices

codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4503#issuecomment-371619489 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=h1) Report > :exclamation:

[GitHub] codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices

codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4503#issuecomment-371619489 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=h1) Report > :exclamation:

[GitHub] graceguo-supercat opened a new pull request #4578: [Explore] Save custom url parameters when user save slices

graceguo-supercat opened a new pull request #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578 fix #4439 when user passed custom parameters in /explore/ request, i build these request parameters into

[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view

codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4570: Adding option to visualize negative values in Table view

john-bodley commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371602918 I agree with @williaster regarding not having to preserve backwards compatibility and that left aligned bars

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371598370 @williaster I've made red channel = 150 and it does look better. Here's aligning to the left. Actually I remember

[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view

codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view

codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4570: Adding option to visualize negative values in Table view

williaster commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371589859 @tanvach thanks for exploring these options! I agree that exposing the controls to the user is ideal given the

[GitHub] mistercrunch commented on issue #4570: Adding option to visualize negative values in Table view

mistercrunch commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371577255 +1 you'll need some css3 kung fu to make that happen :)

[GitHub] mistercrunch closed pull request #4550: Evelynturner/annotation timezone fix2

mistercrunch closed pull request #4550: Evelynturner/annotation timezone fix2 URL: https://github.com/apache/incubator-superset/pull/4550 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] hughhhh commented on a change in pull request #4572: Legend for deck.gl scatterplot

hug commented on a change in pull request #4572: Legend for deck.gl scatterplot URL: https://github.com/apache/incubator-superset/pull/4572#discussion_r173236890 ## File path: superset/assets/visualizations/Legend.jsx ## @@ -0,0 +1,42 @@ +import React from 'react';

[GitHub] darylerwin commented on issue #4577: Should version be showing 23.2 from the UI

darylerwin commented on issue #4577: Should version be showing 23.2 from the UI URL: https://github.com/apache/incubator-superset/issues/4577#issuecomment-371566577 reran and refresh and it shows correctly. I must have missed a step.

[GitHub] darylerwin closed issue #4577: Should version be showing 23.2 from the UI

darylerwin closed issue #4577: Should version be showing 23.2 from the UI URL: https://github.com/apache/incubator-superset/issues/4577 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] darylerwin opened a new issue #4577: Should version be showing 23.2 from the UI

darylerwin opened a new issue #4577: Should version be showing 23.2 from the UI URL: https://github.com/apache/incubator-superset/issues/4577 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371549279 @john-bodley @williaster Since I think the best viz type depends on context, I've simply added options: `Right

[GitHub] EricDiepeveen commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

EricDiepeveen commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-371524655 Same happens here. Added the folder and set the permissions. That

[GitHub] TMorville opened a new issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'

TMorville opened a new issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have

[GitHub] IanWE opened a new issue #4575: Remove Permission from View Error

IanWE opened a new issue #4575: Remove Permission from View Error URL: https://github.com/apache/incubator-superset/issues/4575 I got this problem,Who can tell me how to solve it? database is sqlite3 superset version 2018-03-08

[GitHub] IanWE commented on issue #3061: when create a new role in superset python2.7

IanWE commented on issue #3061: when create a new role in superset python2.7 URL: https://github.com/apache/incubator-superset/issues/3061#issuecomment-371429629 I got the same problem,Can you tell me how to solve it@akfdgg

[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371425925 Maybe I'm just used to [domain coloring ](https://en.wikipedia.org/wiki/Domain_coloring) since I think negative

[GitHub] xrmx commented on issue #4569: Thrift-sasl install problem

xrmx commented on issue #4569: Thrift-sasl install problem URL: https://github.com/apache/incubator-superset/issues/4569#issuecomment-371414691 Then as the error suggests it may have been a network problem. If you retry it should work.

[GitHub] jerowe opened a new issue #4574: Feature Request - Additional Color Gradients

jerowe opened a new issue #4574: Feature Request - Additional Color Gradients URL: https://github.com/apache/incubator-superset/issues/4574 This is not a bug, but a feature request, or a point me towards code so I can do it request. ;-) I would like to have some additional color