[GitHub] syzuhdi commented on issue #3447: 'twophase' is an invalid keyword errors connecting to Oracle
syzuhdi commented on issue #3447: 'twophase' is an invalid keyword errors connecting to Oracle URL: https://github.com/apache/incubator-superset/issues/3447#issuecomment-374836004 rahul, what is your cx_Oracle version ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ktong opened a new issue #4656: the schema of short url is hard code to http
ktong opened a new issue #4656: the schema of short url is hard code to http URL: https://github.com/apache/incubator-superset/issues/4656 https://github.com/apache/incubator-superset/blob/93ec76f7570dcd53d110498cc18ec0f15dd9854b/superset/views/core.py#L750 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
hug commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374833997 Definitely need this!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 1 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 1 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: @jeffreythewang I added `SUPERSET_WEBSERVER_TIMEOUT`. Am I missing other config variables from the commands which are slated to be deprecated? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 1 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 1 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: @jeffreythewang am I missing other config variables from the commands which are slated to be deprecated? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4655: [druid] Updating refresh logic
john-bodley opened a new pull request #4655: [druid] Updating refresh logic URL: https://github.com/apache/incubator-superset/pull/4655 Though the term "refresh" is somewhat vague from a Druid metadata perspective I sense this translates to create or update. Previously we were creating or updates Druid columns but only creating Druid metrics when the Druid metadata was synced/refreshed. This PR ensures that refreshing is consistent for both Druid columns and metrics and specifically addresses the following: 1. Removes redundancy by only controlling metric specifications within the `DruidMetric` class. Previously there was somewhat duplicate logic for both the `DruidColumn` and `DruidMetric` class. 2. Renames `generate_metrics` with `refresh_metrics` to imply that we're both creating and updating. 3. Updates the SQL filters to use `IN` rather than a series of `OR`s. 4. Adds the missing migration for creating Druid uniqueness constraints to the `columns` and `metrics` tables which were added in https://github.com/apache/incubator-superset/pull/3978. 5. Corrects the `--merge` options for the `refresh_druid` command, which should be a flag (true/false) rather than an option. 6. Note I didn't want to change the structure of `get_metrics` in terms of checking whether said metric already exists to ensure consistency with SQLA, hence why the merging logic is handled in `refresh_metrics`. @fabianmenges I only added the missing Druid migrations however I believe there are additional migrations from your PR (https://github.com/apache/incubator-superset/pull/3978) which are missing for the following tables: - `table_columns` - `tables` to: @mistercrunch @Mogball This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4643: Added option to add fill to area line charts
codecov-io commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-374139725 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=h1) Report > Merging [#4643](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/97afcd5809269e885a0dde349081802a427c5674?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4643 +/- ## == + Coverage 71.22% 71.25% +0.03% == Files 190 190 Lines 1488014916 +36 Branches 1098 1102 +4 == + Hits1059810629 +31 - Misses 4279 4284 +5 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.77% <ø> (+0.18%)` | :arrow_up: | | [superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.95% <0%> (-0.56%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.74% <0%> (-0.09%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `76.35% <0%> (+0.03%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `58.25% <0%> (+0.58%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `98.75% <0%> (+1.25%)` | :arrow_up: | | [...sets/javascripts/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `69.15% <0%> (+1.76%)` | :arrow_up: | | [superset/assets/javascripts/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/4643/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdXRpbHMuanM=) | `48.2% <0%> (+3.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=footer). Last update [97afcd5...d161bc7](https://codecov.io/gh/apache/incubator-superset/pull/4643?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175957908 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 1 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 1 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: minor: would these configs (and the rest of the config vars that are only used in `cli.py` also be tagged as `# deprecated`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175957193 ## File path: docs/installation.rst ## @@ -125,10 +125,7 @@ Follow these few simple steps to install Superset.:: # Create default roles and permissions superset init -# Start the web server on port 8088, use -p to bind to another port -superset runserver - -# To start a development web server, use the -d switch +# To start a development web server on port 8088, use -p to bind to anothe port Review comment: nit: typo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4633: Cache the query string
codecov-io commented on issue #4633: Cache the query string URL: https://github.com/apache/incubator-superset/pull/4633#issuecomment-374794885 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=h1) Report > Merging [#4633](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **increase** coverage by `0.11%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4633 +/- ## == + Coverage 71.25% 71.37% +0.11% == Files 190 190 Lines 1491614918 +2 Branches 1102 1102 == + Hits1062910648 +19 + Misses 4284 4267 -17 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4633/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.62% <100%> (+1.15%)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4633/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.96% <0%> (+0.21%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=footer). Last update [fc47729...62d10c0](https://codecov.io/gh/apache/incubator-superset/pull/4633?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4654: Expose metrics to JS
codecov-io commented on issue #4654: Expose metrics to JS URL: https://github.com/apache/incubator-superset/pull/4654#issuecomment-374777021 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=h1) Report > Merging [#4654](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4654 +/- ## == - Coverage 71.25% 71.25% -0.01% == Files 190 190 Lines 1491614918 +2 Branches 1102 1102 == + Hits1062910630 +1 - Misses 4284 4285 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4654/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.46% <ø> (ø)` | :arrow_up: | | [superset/assets/javascripts/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/4654/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvc2FuZGJveC5qcw==) | `93.75% <75%> (-6.25%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=footer). Last update [fc47729...8e8c871](https://codecov.io/gh/apache/incubator-superset/pull/4654?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4654: Expose metrics to JS
betodealmeida opened a new pull request #4654: Expose metrics to JS URL: https://github.com/apache/incubator-superset/pull/4654 @vylc requested the ability of exposing the metrics to the JS advanced tooltip: https://user-images.githubusercontent.com/1534870/37685172-b4537a04-2c4f-11e8-9e3e-37259ab4db5e.png;> I also added a `try/except` block around the sandbox eval, so that the query still runs when the JS is broken, and the exception is shown: https://user-images.githubusercontent.com/1534870/37685215-dbc1ed3c-2c4f-11e8-925d-ed59ec60c645.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kuvsh commented on issue #1231: Support for emailing reports at regular intervals?
kuvsh commented on issue #1231: Support for emailing reports at regular intervals? URL: https://github.com/apache/incubator-superset/issues/1231#issuecomment-374772525 Hello. We also need this feature badly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] darylerwin commented on issue #4644: Superset has no plain number format for Table chart type
darylerwin commented on issue #4644: Superset has no plain number format for Table chart type URL: https://github.com/apache/incubator-superset/issues/4644#issuecomment-374760158 New to all this github stuff but what are the steps to getting a PR into the released code - seems like there are lots in there waiting to merge. Loving all the releases - seems like weekly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0
codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374747816 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=h1) Report > Merging [#4653](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4653 +/- ## === Coverage 71.25% 71.25% === Files 190 190 Lines 1491614916 Branches 1102 1102 === Hits1062910629 Misses 4284 4284 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=footer). Last update [fc47729...f0775d4](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0
codecov-io commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374747816 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=h1) Report > Merging [#4653](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4653 +/- ## === Coverage 71.25% 71.25% === Files 190 190 Lines 1491614916 Branches 1102 1102 === Hits1062910629 Misses 4284 4284 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=footer). Last update [fc47729...f0775d4](https://codecov.io/gh/apache/incubator-superset/pull/4653?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4646: [BugFix] Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on a change in pull request #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@ def run_query( # noqa / druid pre_qry = deepcopy(qry) if timeseries_limit_metric: order_by = timeseries_limit_metric -pre_qry['aggregations'] = self.get_aggregations([timeseries_limit_metric]) +aggs_dict, post_aggs_dict = DruidDatasource.aggs_and_post_aggs( +[timeseries_limit_metric], +metrics_dict) +pre_qry['aggregations'].update(aggs_dict) Review comment: For two-phase queries, replacement is fine since the `pre_qry`s only purpose is to query for the top N groups. For single-phase queries, the `pre_qry` is the only query that runs, so the existing metrics that are queried for must be preserved as well. This situation may not be as obvious since the Table View (in my experience, the view most frequently used for single-phase queries) rarely uses the Sort By field and instead just sorts via the Table UI. I've written a few tests for the scenarios where single-phase queries run with an order and limit specified. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374697547 I've added the fix for `groupby` queries as well, and only scoped the query field updates (with `.update` as opposed to field replacements) to single phase queries. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0
SpyderRivera commented on issue #4653: Add CHANGELOG.md entries for 0.22.0 to 0.24.0 URL: https://github.com/apache/incubator-superset/pull/4653#issuecomment-374737666 I don't know what all the extra differences are from... like RonanW to ronanw This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics
codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374430478 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=h1) Report > Merging [#4646](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5c98f5642b0928f0f496e957b584d97d1d3e7385?src=pr=desc) will **increase** coverage by `0.14%`. > The diff coverage is `91.3%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4646 +/- ## == + Coverage 71.23% 71.37% +0.14% == Files 190 190 Lines 1488414929 +45 Branches 1099 1102 +3 == + Hits1060210656 +54 + Misses 4279 4270 -9 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `78.61% <91.3%> (+2.29%)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.74% <0%> (-0.09%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.77% <0%> (+0.18%)` | :arrow_up: | | [...sets/javascripts/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `69.15% <0%> (+1.76%)` | :arrow_up: | | [superset/assets/javascripts/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdXRpbHMuanM=) | `48.2% <0%> (+3.58%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=footer). Last update [5c98f56...c1d663e](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4646: Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on issue #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#issuecomment-374697547 I've added the fix for `groupby` queries as well, and only limited the query field updates (with `.update` as opposed to field replacements) to single phase queries. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@ def run_query( # noqa / druid pre_qry = deepcopy(qry) if timeseries_limit_metric: order_by = timeseries_limit_metric -pre_qry['aggregations'] = self.get_aggregations([timeseries_limit_metric]) +aggs_dict, post_aggs_dict = DruidDatasource.aggs_and_post_aggs( +[timeseries_limit_metric], +metrics_dict) +pre_qry['aggregations'].update(aggs_dict) Review comment: For two-phase queries, replacement is fine since the `pre_qry`s only purpose is to query for the top N groups. For single-phase queries, the `pre_qry` is the only query that runs, so the existing metrics that are queried for must be preserved as well. This situation may not be as obvious since the Table View (in my experience, the view most frequently used for single-phase queries) rarely uses the Sort By field and instead just sorts via the Table UI. I've written a few test scenarios for the scenarios where single-phase queries run with an order and limit specified. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@ def run_query( # noqa / druid pre_qry = deepcopy(qry) if timeseries_limit_metric: order_by = timeseries_limit_metric -pre_qry['aggregations'] = self.get_aggregations([timeseries_limit_metric]) +aggs_dict, post_aggs_dict = DruidDatasource.aggs_and_post_aggs( +[timeseries_limit_metric], +metrics_dict) +pre_qry['aggregations'].update(aggs_dict) Review comment: For two-phase queries, replacement is fine since the `pre_qry`s only purpose is to query for the top N groups. For single-phase queries, the `pre_qry` is the only query that runs, so the existing metrics that are queried for must be preserved as well. I've written a few test scenarios for this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics
jeffreythewang commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175866052 ## File path: superset/connectors/druid/models.py ## @@ -1134,7 +1137,11 @@ def run_query( # noqa / druid pre_qry = deepcopy(qry) if timeseries_limit_metric: order_by = timeseries_limit_metric -pre_qry['aggregations'] = self.get_aggregations([timeseries_limit_metric]) +aggs_dict, post_aggs_dict = DruidDatasource.aggs_and_post_aggs( +[timeseries_limit_metric], +metrics_dict) +pre_qry['aggregations'].update(aggs_dict) Review comment: For two-phase queries, replacement is fine since the `pre_qry`s only purpose is to query for the top N groups. For single-phase queries, the `pre_qry` is the only query that runs, so the existing metrics that are queried for must be preserved as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4631: Fix flower broker configuration
codecov-io commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-373852220 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=h1) Report > Merging [#4631](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4631 +/- ## == - Coverage 71.25% 71.22% -0.04% == Files 190 190 Lines 1491614879 -37 Branches 1102 1098 -4 == - Hits1062910598 -31 + Misses 4284 4278 -6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `48.7% <ø> (+0.31%)` | :arrow_up: | | [superset/assets/javascripts/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvdXRpbHMuanM=) | `44.61% <0%> (-3.59%)` | :arrow_down: | | [...sets/javascripts/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `67.39% <0%> (-1.77%)` | :arrow_down: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `97.5% <0%> (-1.25%)` | :arrow_down: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `57.67% <0%> (-0.59%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <0%> (-0.19%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `76.31% <0%> (-0.04%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.83% <0%> (+0.08%)` | :arrow_up: | | [superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4631/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==) | `65.51% <0%> (+0.55%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=footer). Last update [fc47729...b1f8b34](https://codecov.io/gh/apache/incubator-superset/pull/4631?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leorochael commented on issue #4631: Fix flower broker configuration
leorochael commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-374687104 > In terms of enforcing that the BROKER_URL is present isn't this required by the Celery worker? It seems that the convention is that it's assumed that these configuration variables exist and thus I'm uncertain whether the check is required. Before this PR, the behaviour of `superset flower` on a missing broker config was to invoke: celery flower --broker=None --port= --address=localhost Which resulted in the following output: ``` [I 180320 14:16:57 command:139] Visit me at http://localhost: [I 180320 14:16:57 command:144] Broker: amqp://guest:**@None:5672// ``` With this PR, but without the check, the resulting command on a missing broker config would be: celery flower -A superset.cli.celery_app --port= --address=localhost With the output: ``` 2018-03-20 14:24:48,106:INFO:flower.command:Visit me at http://localhost: 2018-03-20 14:24:48,111:INFO:flower.command:Broker: amqp://guest:**@localhost:5672// ``` In both cases `flower` guessed wrongly that there is a broker configured using AMQP, and accessing port in the browser results in a page that never finishes loading. I think it would be better to just fail early in this case. As for the deprecation of external command wrapping, if you believe that there is little value in fixing the flower invocation, feel free to close this PR, but as long as there is a `superset flower` command, I'd rather it did the right thing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == + Coverage 71.25% 71.25% +<.01% == Files 190 190 Lines 1491614937 +21 Branches 1102 1106 +4 == + Hits1062910644 +15 - Misses 4284 4290 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.7% <100%> (+0.4%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.14% <37.5%> (-0.78%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.46% <50%> (-0.91%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [fc47729...78bae96](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == + Coverage 71.25% 71.25% +<.01% == Files 190 190 Lines 1491614937 +21 Branches 1102 1106 +4 == + Hits1062910644 +15 - Misses 4284 4290 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.7% <100%> (+0.4%)` | :arrow_up: | | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.14% <37.5%> (-0.78%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.46% <50%> (-0.91%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [fc47729...78bae96](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michellethomas commented on issue #4649: Use one library for table components
michellethomas commented on issue #4649: Use one library for table components URL: https://github.com/apache/incubator-superset/issues/4649#issuecomment-374683340 Thanks for the information Max. This is super useful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Sessions still active on Datasource
Hello, My name is Amine and I am working for Decathlon. I am contacting you concerning a problem found when using superset. We have several session still running on our datasource (Postgres Database) even when superset dashboard is closed or cached on redis. How can we make sure that superset session are well closed after querying the datasource. Thank you for you help. --
[GitHub] SpyderRivera commented on issue #4545: add two more number formats, add number formats to table
SpyderRivera commented on issue #4545: add two more number formats, add number formats to table URL: https://github.com/apache/incubator-superset/pull/4545#issuecomment-374615510 @Pek1s can you fix the conflict? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leehwmj-junta commented on issue #4650: Have to repeat build and install each time when I modify and test jsx in superset/assets/javascript
leehwmj-junta commented on issue #4650: Have to repeat build and install each time when I modify and test jsx in superset/assets/javascript URL: https://github.com/apache/incubator-superset/issues/4650#issuecomment-374535916 @mistercrunch , I tried with the suggested method. But there was a new problem. When I check git to 0.22 and proceed to the proposed protocol, the layout will be displayed as 0.23.0dev. https://user-images.githubusercontent.com/36018781/37643688-ba346e6e-2c64-11e8-8e12-79ae0dcdf9e9.png;> However, the code is clearly marked as 0.22.  And css is not applied properly. https://user-images.githubusercontent.com/36018781/37643770-f1e031d6-2c64-11e8-94f8-970727f469db.png;> This problem only occurs when you use this method (https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#setting-up-a-python-development-environment). On the other hand, when I proceeded to this method (https://superset.incubator.apache.org/installation.html#superset-installation-and-initialization), I constantly reaffirmed that the 0.22 version of the layout worked well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ccl0326 opened a new issue #4652: add group by parameters into filter box
ccl0326 opened a new issue #4652: add group by parameters into filter box URL: https://github.com/apache/incubator-superset/issues/4652 now we can use filter box to filter fields, but if we can make filter box control group by parameters we can make it more free. we can select some fields for group by in dashboard. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo
williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-374506307 @graceguo-supercat I think this is ready to merge into the `dashboard-builder` [branch](https://github.com/apache/incubator-superset/pull/4528). nesting rows in columns should also work now, and column children inherit parent column width where relevant (e.g., charts) as we discussed. going to take a separate pass at tests and for the logic to detect when a row is overflown. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo
williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-374506307 @graceguo-supercat I think this is ready to merge into the `dashboard-builder` [branch](https://github.com/apache/incubator-superset/pull/4528), PTAL . nesting rows in columns should also work now, and column children inherit parent column width where relevant (e.g., charts) as we discussed. going to take a separate pass at tests and for the logic to detect when a row is overflown. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sunyongmofang closed pull request #4614: Add sql editor
sunyongmofang closed pull request #4614: Add sql editor
URL: https://github.com/apache/incubator-superset/pull/4614
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index ec4522be88..13e0d07ecb 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1197,6 +1197,16 @@ export const controls = {
description: t('What should be shown on the label?'),
},
+ sql: {
+type: 'TextAreaControl',
+label: t('Code'),
+description: t('Put your sql here. This feature is for developers who
understand superset. If you are not sure, please do not fill in anything, it
will be ignored.'),
+mapStateToProps: state => ({
+ language: state.controls && state.controls.markup_type ?
state.controls.markup_type.value : 'sql',
+}),
+default: '',
+ },
+
code: {
type: 'TextAreaControl',
label: t('Code'),
diff --git a/superset/assets/javascripts/explore/stores/visTypes.js
b/superset/assets/javascripts/explore/stores/visTypes.js
index 836da7b9cd..d2a2efe58b 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -1078,6 +1078,12 @@ export const visTypes = {
['metric'],
],
},
+ {
+label: t('Code'),
+controlSetRows: [
+ ['sql'],
+],
+ },
{
label: t('Chart Options'),
expanded: true,
diff --git a/superset/connectors/sqla/models.py
b/superset/connectors/sqla/models.py
index ef8c68ebb3..fa2e620b48 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -407,13 +407,28 @@ def get_template_processor(self, **kwargs):
def get_query_str(self, query_obj):
engine = self.database.get_sqla_engine()
-qry = self.get_sqla_query(**query_obj)
-sql = six.text_type(
-qry.compile(
-engine,
-compile_kwargs={'literal_binds': True},
-),
-)
+if 'form_data' in query_obj and \
+'sql' in query_obj['form_data'] and \
+query_obj['form_data']['sql']:
+dttm_to_str = [x for x in self.columns if
x.is_dttm][0].dttm_sql_literal
+query_obj['from_dttm'] = dttm_to_str(query_obj['from_dttm'])
+query_obj['to_dttm'] = dttm_to_str(query_obj['to_dttm'])
+sql = query_obj['form_data']['sql']
+for k in query_obj:
+v = query_obj[k]
+if isinstance(v, basestring):
+sql = sql.replace(''.join(['{', k, '}']), v)
+for v in query_obj['form_data']['filters']:
+tmp_key, tmp_value = v['col'], v['val'][0]
+sql = sql.replace(''.join(['{', tmp_key, '}']), tmp_value)
+else:
+qry = self.get_sqla_query(**query_obj)
+sql = six.text_type(
+qry.compile(
+engine,
+compile_kwargs={'literal_binds': True},
+),
+)
logging.info(sql)
sql = sqlparse.format(sql, reindent=True)
if query_obj['is_prequery']:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4297: [Filter Box] Boolean values show up blank in selector
mistercrunch commented on issue #4297: [Filter Box] Boolean values show up blank in selector URL: https://github.com/apache/incubator-superset/issues/4297#issuecomment-374489750 related as prerequisite: https://github.com/apache/incubator-superset/pull/4651 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4651: [WiP] [explore] proper filtering of NULLs and ''
mistercrunch opened a new pull request #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651 TODO: handling of Druid equivalents This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
