[GitHub] ManojKumarMaurya opened a new issue #4685: superset dashboard is blank

ManojKumarMaurya opened a new issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685 Make sure these boxes are checked before submitting your issue - thank you!

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479 > [root@devn ~]# cd /opt/python-env/Superset/ > [root@devn Superset]# source ./bin/activate >

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479 `[root@devn ~]# cd /opt/python-env/Superset/ [root@devn Superset]# source ./bin/activate

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479 `[root@devn ~]# cd /opt/python-env/Superset/ [root@devn Superset]# source ./bin/activate (Superset)

[GitHub] codecov-io commented on issue #4684: Fix up the Lyft color scheme

codecov-io commented on issue #4684: Fix up the Lyft color scheme URL: https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839789 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=h1) Report > Merging

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479 `[root@devn ~]# cd /opt/python-env/Superset/ [root@devn Superset]# source ./bin/activate (Superset)

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479 `[root@devn ~]# cd /opt/python-env/Superset/ [root@devn Superset]# source ./bin/activate (Superset)

[GitHub] codecov-io commented on issue #4684: Fix up the Lyft color scheme

codecov-io commented on issue #4684: Fix up the Lyft color scheme URL: https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839789 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=h1) Report > Merging

[GitHub] hughhhh commented on issue #4684: Fix up the Lyft color scheme

hug commented on issue #4684: Fix up the Lyft color scheme URL: https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839337 :ship: This is an automated message from the Apache Git Service. To respond to

[GitHub] hughhhh commented on issue #4684: Fix up the Lyft color scheme

hug commented on issue #4684: Fix up the Lyft color scheme URL: https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839337 :ship: This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #4680: [WiP] Hotkeys in SQL Lab

codecov-io commented on issue #4680: [WiP] Hotkeys in SQL Lab URL: https://github.com/apache/incubator-superset/pull/4680#issuecomment-375838321 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=h1) Report > Merging

[GitHub] mistercrunch closed pull request #4682: Add lyftColor to the game 

mistercrunch closed pull request #4682: Add lyftColor to the game  URL: https://github.com/apache/incubator-superset/pull/4682 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] codecov-io commented on issue #4683: Fix bug with sorting columns in group by using time shift

codecov-io commented on issue #4683: Fix bug with sorting columns in group by using time shift URL: https://github.com/apache/incubator-superset/pull/4683#issuecomment-375834201 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=h1) Report > Merging

[GitHub] michellethomas opened a new pull request #4683: Fix bug with sorting columns in group by using time shift

michellethomas opened a new pull request #4683: Fix bug with sorting columns in group by using time shift URL: https://github.com/apache/incubator-superset/pull/4683 Fixing the `'<' not supported between instances of 'str' and 'tuple'` issue with time shift group by line charts.

[GitHub] timifasubaa commented on issue #4669: [sqllab] Using app context for processing Jinja template in async mode

timifasubaa commented on issue #4669: [sqllab] Using app context for processing Jinja template in async mode URL: https://github.com/apache/incubator-superset/pull/4669#issuecomment-375831481 LGTM? This is an automated

[GitHub] timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster?

timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster? URL: https://github.com/apache/incubator-superset/issues/4588#issuecomment-375827342 Some more ideas were shared at today's meeting. One was having a separate flow for downloading query

[GitHub] timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster?

timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster? URL: https://github.com/apache/incubator-superset/issues/4588#issuecomment-375827342 Some more ideas were shared at today's meeting. One was having a separate flow for downloading query

[GitHub] codecov-io commented on issue #4682: Add lyftColor to the game 

codecov-io commented on issue #4682: Add lyftColor to the game  URL: https://github.com/apache/incubator-superset/pull/4682#issuecomment-375825134 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4682: Add lyftColor to the game 

codecov-io commented on issue #4682: Add lyftColor to the game  URL: https://github.com/apache/incubator-superset/pull/4682#issuecomment-375825134 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=h1) Report > Merging

[GitHub] betodealmeida commented on issue #4387: Time filter - remove infinity for end date

betodealmeida commented on issue #4387: Time filter - remove infinity for end date URL: https://github.com/apache/incubator-superset/issues/4387#issuecomment-375824524 @vylc, I can't repro this — @mistercrunch, do you know if this was changed recently?

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-375824124 @mistercrunch @betodealmeida per the conservation regarding pinning earlier today what are your thoughts on this

[GitHub] john-bodley commented on issue #4682: Add lyftColor to the game 

john-bodley commented on issue #4682: Add lyftColor to the game  URL: https://github.com/apache/incubator-superset/pull/4682#issuecomment-375823077 LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] hughhhh opened a new pull request #4682: Add lyftColor to the game 

hug opened a new pull request #4682: Add lyftColor to the game  URL: https://github.com/apache/incubator-superset/pull/4682 Because the branding matters  This is an automated message from the Apache Git Service. To

[GitHub] michellethomas opened a new issue #4681: Time table viz sorting doesn't work with values equal to 0

michellethomas opened a new issue #4681: Time table viz sorting doesn't work with values equal to 0 URL: https://github.com/apache/incubator-superset/issues/4681 This has been a known issue for some time, but I wanted to keep track of this as a known bug. We are seeing an issue with

[GitHub] codecov-io commented on issue #4678: Update documentation about yarn lock

codecov-io commented on issue #4678: Update documentation about yarn lock URL: https://github.com/apache/incubator-superset/pull/4678#issuecomment-375815860 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=h1) Report > Merging

[GitHub] john-bodley closed pull request #4679: add yarn lock info to contributing.md

john-bodley closed pull request #4679: add yarn lock info to contributing.md URL: https://github.com/apache/incubator-superset/pull/4679 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] codecov-io commented on issue #4679: add yarn lock info to contributing.md

codecov-io commented on issue #4679: add yarn lock info to contributing.md URL: https://github.com/apache/incubator-superset/pull/4679#issuecomment-375815118 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=h1) Report > Merging

[GitHub] hughhhh commented on issue #4680: [WiP] Hotkeys in SQL Lab

hug commented on issue #4680: [WiP] Hotkeys in SQL Lab URL: https://github.com/apache/incubator-superset/pull/4680#issuecomment-375813684 @dubtran This is an automated message from the Apache Git Service. To respond to

[GitHub] mistercrunch opened a new pull request #4680: [WiP] Hotkeys in SQL Lab

mistercrunch opened a new pull request #4680: [WiP] Hotkeys in SQL Lab URL: https://github.com/apache/incubator-superset/pull/4680 https://user-images.githubusercontent.com/487433/37855642-8878834c-2ead-11e8-97a0-9cc5fc8468ba.png;>

[GitHub] timifasubaa commented on issue #4245: build master branch failed

timifasubaa commented on issue #4245: build master branch failed URL: https://github.com/apache/incubator-superset/issues/4245#issuecomment-375812248 If you're comfortable with Docker, you can try to see if this works for you : https://hub.docker.com/r/amancevice/superset/

[GitHub] jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2

jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2 URL: https://github.com/apache/incubator-superset/pull/4299#issuecomment-375812162 We're also having issues with the version bump related to the addition of the `get_table_comment` method as described

[GitHub] timifasubaa commented on issue #4245: build master branch failed

timifasubaa commented on issue #4245: build master branch failed URL: https://github.com/apache/incubator-superset/issues/4245#issuecomment-375812248 If you're cmofortable with Docker, you can try to see if this works for you : https://hub.docker.com/r/amancevice/superset/

[GitHub] timifasubaa commented on issue #4348: Add yarn.lock for reproducible build (#4274)

timifasubaa commented on issue #4348: Add yarn.lock for reproducible build (#4274) URL: https://github.com/apache/incubator-superset/pull/4348#issuecomment-375810990 Superseded by https://github.com/apache/incubator-superset/pull/4679 and

[GitHub] timifasubaa commented on issue #4674: Add yarn.lock

timifasubaa commented on issue #4674: Add yarn.lock URL: https://github.com/apache/incubator-superset/pull/4674#issuecomment-375810612 https://github.com/apache/incubator-superset/issues/4274 This is an automated message

[GitHub] timifasubaa opened a new pull request #4679: add yarn lock info to contributing.md

timifasubaa opened a new pull request #4679: add yarn lock info to contributing.md URL: https://github.com/apache/incubator-superset/pull/4679 This adds more info about updating the yarn lock as added in (#4674) @graceguo-supercat @mistercrunch

[GitHub] timifasubaa opened a new pull request #4678: Update documentation about yarn lock

timifasubaa opened a new pull request #4678: Update documentation about yarn lock URL: https://github.com/apache/incubator-superset/pull/4678 This adds more info about updating the yarn lock as added in (https://github.com/apache/incubator-superset/pull/4674)

[GitHub] villebro commented on issue #3998: [SQLLab] Allow common table expressions (CTE), a.k.a. "with" statements

villebro commented on issue #3998: [SQLLab] Allow common table expressions (CTE), a.k.a. "with" statements URL: https://github.com/apache/incubator-superset/issues/3998#issuecomment-375807662 I am unable to reproduce this bug. As we're currently using sqlparse==0.2.4, and CTEs were added

[GitHub] betodealmeida commented on a change in pull request #4654: Expose metrics to JS

betodealmeida commented on a change in pull request #4654: Expose metrics to JS URL: https://github.com/apache/incubator-superset/pull/4654#discussion_r176871595 ## File path: superset/assets/javascripts/modules/sandbox.js ## @@ -22,6 +22,10 @@ export default function

[GitHub] timifasubaa commented on issue #4674: Add yarn.lock

timifasubaa commented on issue #4674: Add yarn.lock URL: https://github.com/apache/incubator-superset/pull/4674#issuecomment-375801147 @mistercrunch Sure. I'll be happy to add. The instructions would be something along the lines of updating the yarn.lock file whenever you add a new

[GitHub] graceguo-supercat closed pull request #4639: forms: make csv import parse dates accepts a list of columns

graceguo-supercat closed pull request #4639: forms: make csv import parse dates accepts a list of columns URL: https://github.com/apache/incubator-superset/pull/4639 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] graceguo-supercat closed issue #4637: csv import "parse dates" should be more flexible

graceguo-supercat closed issue #4637: csv import "parse dates" should be more flexible URL: https://github.com/apache/incubator-superset/issues/4637 This is an automated message from the Apache Git Service. To respond to

[GitHub] mistercrunch commented on issue #4674: Add yarn.lock

mistercrunch commented on issue #4674: Add yarn.lock URL: https://github.com/apache/incubator-superset/pull/4674#issuecomment-375800212 Do we need instructions on `CONTRIBUTING.md` related to this? This is an automated

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging

[GitHub] althorian commented on issue #1338: Cannot connect to MySQL view

althorian commented on issue #1338: Cannot connect to MySQL view URL: https://github.com/apache/incubator-superset/issues/1338#issuecomment-375793509 I have the same issue, I am using mySQL and superset (0.23.2) connecting to the database with mysql+mysqldb. The tables I can see just fine

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging

[GitHub] timifasubaa commented on issue #4639: forms: make csv import parse dates accepts a list of columns

timifasubaa commented on issue #4639: forms: make csv import parse dates accepts a list of columns URL: https://github.com/apache/incubator-superset/pull/4639#issuecomment-375764750 LGTM This is an automated message from

[GitHub] mistercrunch closed pull request #4676: Fix setup.py, comma makes download_url a tuple

mistercrunch closed pull request #4676: Fix setup.py, comma makes download_url a tuple URL: https://github.com/apache/incubator-superset/pull/4676 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] codecov-io commented on issue #4676: Fix setup.py, comma makes download_url a tuple

codecov-io commented on issue #4676: Fix setup.py, comma makes download_url a tuple URL: https://github.com/apache/incubator-superset/pull/4676#issuecomment-375751529 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=h1) Report > Merging

[GitHub] williaster closed pull request #4626: [dashboard-builder] add top-level tabs + undo-redo

williaster closed pull request #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626 This is an automated message from the Apache Git Service. To respond to

[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo

williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-375749838 going to merge. This is an automated message from

[GitHub] xrmx commented on issue #4677: get column values for filters not working with clickhouse datasource

xrmx commented on issue #4677: get column values for filters not working with clickhouse datasource URL: https://github.com/apache/incubator-superset/issues/4677#issuecomment-375749330 Looks like an issue in sqlalchemy_clickhouse more than in superset

[GitHub] baoxiao opened a new issue #4677: get column values for filters not working with clickhouse datasource

baoxiao opened a new issue #4677: get column values for filters not working with clickhouse datasource URL: https://github.com/apache/incubator-superset/issues/4677 Make sure these boxes are checked before submitting your issue - thank you! - [X ] I have checked the superset logs

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging

[GitHub] john-bodley commented on issue #4676: Fix setup.py, comma makes download_url a tuple

john-bodley commented on issue #4676: Fix setup.py, comma makes download_url a tuple URL: https://github.com/apache/incubator-superset/pull/4676#issuecomment-375737637 LGTM This is an automated message from the Apache Git

[GitHub] john-bodley commented on issue #4565: Move access permissions methods to security manager

john-bodley commented on issue #4565: Move access permissions methods to security manager URL: https://github.com/apache/incubator-superset/pull/4565#issuecomment-375736987 @mistercrunch the thinking was that the default security manager is still tightly coupled with FAB concepts

[GitHub] mistercrunch opened a new pull request #4676: Fix setup.py, comma makes download_url a tuple

mistercrunch opened a new pull request #4676: Fix setup.py, comma makes download_url a tuple URL: https://github.com/apache/incubator-superset/pull/4676 @john-bodley This is an automated message from the Apache Git Service.

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null URL: https://github.com/apache/incubator-superset/issues/4613#issuecomment-375717120 Having the same issue, curious how did you fix it ?

[GitHub] mistercrunch commented on issue #4666: Sessions still active on Datasource

mistercrunch commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-375702579 This is the PR you want https://github.com/apache/incubator-superset/pull/4251

[GitHub] mistercrunch commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

mistercrunch commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375701194 Related: https://github.com/jupyterhub/jupyterhub/issues/464 Looks like you need sqlite os

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375696910 `pip install pysqlite3 ` > Collecting pysqlite3 > Downloading

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375696910 `pip install pysqlite3 Collecting pysqlite3 Downloading

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-375690621 @xiaohanyu @WangXueminGit I tried to implement the PR by myself and it works fine for the pivot visualization and it looks

[GitHub] AmineTay commented on issue #4666: Sessions still active on Datasource

AmineTay commented on issue #4666: Sessions still active on Datasource URL: https://github.com/apache/incubator-superset/issues/4666#issuecomment-375602966 Hello, We also do analytics query using external database on which we have active session which is problematic for us. And our

[GitHub] codecov-io commented on issue #4639: forms: make csv import parse dates accepts a list of columns

codecov-io commented on issue #4639: forms: make csv import parse dates accepts a list of columns URL: https://github.com/apache/incubator-superset/pull/4639#issuecomment-374022137 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=h1) Report > Merging

[GitHub] deatheyes opened a new issue #4675: Need proper way to display date time with time zone for epoch_s and epoch_ms

deatheyes opened a new issue #4675: Need proper way to display date time with time zone for epoch_s and epoch_ms URL: https://github.com/apache/incubator-superset/issues/4675 Make sure these boxes are checked before submitting your issue - thank you! - [*] I have checked the

[GitHub] xrmx commented on issue #4639: forms: make csv import parse dates accepts a list of columns

xrmx commented on issue #4639: forms: make csv import parse dates accepts a list of columns URL: https://github.com/apache/incubator-superset/pull/4639#issuecomment-375589780 @timifasubaa any chance you can take a look at this? I'll show this in a talk about superset tomorrow and I'd

[GitHub] riteshemigo commented on issue #2907: Superset very slow when FAB DB hosted on separate server

riteshemigo commented on issue #2907: Superset very slow when FAB DB hosted on separate server URL: https://github.com/apache/incubator-superset/issues/2907#issuecomment-375567411 @BobSaintClare Did you find any permanent resolution for this. I am also facing the same issue.

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging

[GitHub] hughhhh commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid

hug commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#discussion_r176654238 ## File path: superset/connectors/sqla/models.py ## @@

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging

[GitHub] hughhhh commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid

hug commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#discussion_r176654238 ## File path: superset/connectors/sqla/models.py ## @@

[GitHub] napjon commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty

napjon commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty URL: https://github.com/apache/incubator-superset/issues/4635#issuecomment-375565317 >Sorry as we're ironing out our release process. Part of the Apache process will force

[GitHub] codecov-io commented on issue #4673: Add context to templates / respect slice timeout

codecov-io commented on issue #4673: Add context to templates / respect slice timeout URL: https://github.com/apache/incubator-superset/pull/4673#issuecomment-375558796 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=h1) Report > Merging

[GitHub] daoready commented on issue #4673: Add context to templates / respect slice timeout

daoready commented on issue #4673: Add context to templates / respect slice timeout URL: https://github.com/apache/incubator-superset/pull/4673#issuecomment-375556326 I do not know Python, for me it is quite difficult to add tests, sorry about that

[GitHub] graceguo-supercat closed pull request #4630: [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all

graceguo-supercat closed pull request #4630: [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data URL: https://github.com/apache/incubator-superset/pull/4630 This is a PR merged from a

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't