[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/adf9ec0bb1943caa16b7da5515741c1f4905c0ea?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `76.62%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4651/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == + Coverage 72.29% 72.32% +0.02% == Files 208 208 Lines 1552215571 +49 Branches 1202 1209 +7 == + Hits1122211261 +39 - Misses 4297 4307 +10 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [...et/assets/javascripts/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | `93.18% <ø> (ø)` | :arrow_up: | | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.44% <100%> (+0.02%)` | :arrow_up: | | [superset/assets/javascripts/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbW1vbi5qcw==) | `40% <100%> (+40%)` | :arrow_up: | | [superset/assets/javascripts/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `52.52% <33.33%> (-0.6%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.1% <44.44%> (-0.99%)` | :arrow_down: | | [superset/assets/javascripts/SqlLab/actions.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9hY3Rpb25zLmpz) | `72.44% <50%> (+0.12%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.14% <73.33%> (-0.48%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.78% <75%> (-0.58%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.38% <86.95%> (-0.6%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [adf9ec0...570e108](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b925fee80c0d46aeb444326ac499296d682396?src=pr=desc) will **decrease** coverage by `0.14%`. > The diff coverage is `76%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4651/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == - Coverage71.4% 71.25% -0.15% == Files 190 190 Lines 1493414937 +3 Branches 1102 1106 +4 == - Hits1066410644 -20 - Misses 4267 4290 +23 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.7% <100%> (+0.4%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.14% <37.5%> (-0.78%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.46% <50%> (-0.91%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.46% <0%> (-1.16%)` | :arrow_down: | | [superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz) | `76.59% <0%> (-0.49%)` | :arrow_down: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.21% <0%> (-0.4%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.74% <0%> (-0.22%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.21% <0%> (+0.02%)` | :arrow_up: | | [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `100% <0%> (+1.88%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [52b925f...dd6381b](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `76%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4651/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == + Coverage 71.25% 71.25% +<.01% == Files 190 190 Lines 1491614937 +21 Branches 1102 1106 +4 == + Hits1062910644 +15 - Misses 4284 4290 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.7% <100%> (+0.4%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.14% <37.5%> (-0.78%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.46% <50%> (-0.91%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [fc47729...78bae96](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and ''
codecov-io commented on issue #4651: [WiP] [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=h1) Report > Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fc47729233e7ce44e225edbeb628f6a5f0376eda?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `76%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4651/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4651 +/- ## == + Coverage 71.25% 71.25% +<.01% == Files 190 190 Lines 1491614937 +21 Branches 1102 1106 +4 == + Hits1062910644 +15 - Misses 4284 4290 +6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==) | `97.7% <100%> (+0.4%)` | :arrow_up: | | [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.14% <37.5%> (-0.78%)` | :arrow_down: | | [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.46% <50%> (-0.91%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=footer). Last update [fc47729...78bae96](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services