[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.
codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging [#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr=desc) will **increase** coverage by `0.2%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4758 +/- ## = + Coverage 72.39% 72.59% +0.2% = Files 205 205 Lines 1539415401 +7 Branches 1182 1183 +1 = + Hits1114411180 +36 + Misses 4247 4218 -29 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=) | `91.95% <100%> (ø)` | :arrow_up: | | [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <0%> (-1.55%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.54% <0%> (-0.05%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.29% <0%> (ø)` | :arrow_up: | | [...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==) | `99.24% <0%> (ø)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.3% <0%> (+0.05%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.48% <0%> (+2.33%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=footer). Last update [9a79d33...e8d5feb](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.
codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging [#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4758 +/- ## === Coverage 72.39% 72.39% === Files 205 205 Lines 1539415394 Branches 1182 1182 === Hits1114411144 Misses 4247 4247 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=) | `91.95% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=footer). Last update [9a79d33...368006d](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.
codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset. URL: https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=h1) Report > Merging [#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4758 +/- ## === Coverage 72.39% 72.39% === Files 205 205 Lines 1539415394 Branches 1182 1182 === Hits1114411144 Misses 4247 4247 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=) | `91.95% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=footer). Last update [9a79d33...368006d](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
