[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox 
timifasubaa commented on a change in pull request #4432: Added check cache key 
util
URL: 
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -2208,6 +2208,15 @@ def cached_key(self, key):
 return resp
 return 'nope'
 
+@expose('/cache_key_exist//')
 
 Review comment:
   missing `@has_access_api`. Intentional? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox 
timifasubaa commented on a change in pull request #4432: Added check cache key 
util
URL: 
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -2208,6 +2208,15 @@ def cached_key(self, key):
 return resp
 return 'nope'
 
+@expose('/cache_key_exist//')
 
 Review comment:
   missing `@has_access_api`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox 
timifasubaa commented on a change in pull request #4432: Added check cache key 
util
URL: 
https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -2208,6 +2208,15 @@ def cached_key(self, key):
 return resp
 return 'nope'
 
+@expose('/cache_key_exist//')
 
 Review comment:
   Was `@has_access_api` intentionally omitted 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services