[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change whether gamma has access to dashboards it created. Like you suggested in the issue, you could create a new rule in the permissions check that allows the creator to see their dashboards even if it is a gamma user. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change whether gamma has access to dashboards it created. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365378668 Ah, true. I'll do it that way instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365345137 Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365092528 @mistercrunch Done. I left the access requests on by default. Is it better off by default? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4405: Disable user access request
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365092528 @mistercrunch Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
