[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365841957 @shyam2794 Hi, this PR is not merged yet, and if you would like to have a try, you have to cherry pick this PR manually by

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-12 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365168344 HI, all, we have updated lots of screenshots in https://github.com/apache/incubator-superset/pull/4394, please vote for

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-07 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-07 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-363745069 We're almost done. @WangXueminGit is really working quite hard on this feature and after internal code review, we'll

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-01-27 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-360985412 @kartikshanbhag oh really? we think the second one looks more aligned considering layout, while the first one looks a

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-01-15 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-357839164 @kartikshanbhag we're working on it from this week. It should be PRed by the end of this month.

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2017-12-26 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-354039432 @shyam2794 we will start to do this from Jan, so be patient!

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2017-12-22 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-353571580 @shyam2794 Right now, no. We're considering contribute our patch to upstream, maybe start from Next January. And to

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2017-09-11 Thread git
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-328480116 Hi, @gangh Right now these feature is hosted on our own internal private codebase, and we're considering to

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2017-09-07 Thread git
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-327708132 Hi, all, Actually, we have implement similar features for pivot table and plain table, in our own branch. Some