[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180903978 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx ##

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180904481 ## File path: superset/assets/javascripts/explore/components/AdhocMetricEditPopover.jsx ##

[GitHub] GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics

2018-04-11 Thread GitBox
GabeLoins commented on a change in pull request #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#discussion_r180903869 ## File path: superset/assets/javascripts/explore/AdhocMetric.js ## @@ -23,10 +68,