[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 1 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 1 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: @jeffreythewang I added `SUPERSET_WEBSERVER_TIMEOUT`. Am I missing other config variables from the commands which are slated to be deprecated? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r175984184 ## File path: superset/config.py ## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 1 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 1 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: @jeffreythewang am I missing other config variables from the commands which are slated to be deprecated? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r174957518 ## File path: docs/installation.rst ## @@ -521,6 +513,10 @@ have the same configuration. CELERY_CONFIG = CeleryConfig +To start a Celery worker to leverage the configuration run: :: + +celery worker --app=superset.sql_lab:celery_app -Ofair Review comment: Thanks. I added `--pool=gevent`. I've used the long names as they're more descriptive. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands
john-bodley commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r174956903 ## File path: docs/installation.rst ## @@ -147,12 +144,8 @@ Gunicorn, preferably in **async mode**, which allows for impressive concurrency even and is fairly easy to install and configure. Please refer to the documentation of your preferred technology to set up this Flask WSGI -application in a way that works well in your environment. - -While the `superset runserver` command act as an quick wrapper -around `gunicorn`, it doesn't expose all the options you may need, -so you'll want to craft your own `gunicorn` command in your production -environment. Here's an **async** setup known to work well: :: +application in a way that works well in your environment. Here's an **async** +setup known to work well in production: :: 　gunicorn \ Review comment: @fabianmenges the `-k gevent` argument is specified. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
