[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-11-02 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-341327403 I don't want to sound stubborn, however, I do not understand why these two lines of code would require to write a

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338692866 Thinking about it: We use information that is at this point only present in the JSON stored in the cache. If the

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338639157 @xrmx: Spaces are fixed now. However, unfortunately I have no idea how to add a test, what needs to be

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338639157 @xrmx: I did not introduce any whitespace. Could you please specify? Furthermore I have no idea how to add a

[GitHub] rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV

2017-10-23 Thread GitBox
rumbin commented on issue #3705: convert DATETIME columns when exporting from cache to CSV URL: https://github.com/apache/incubator-superset/pull/3705#issuecomment-338614185 What am I supposed to do when the **coverage/coveralls** test fails?