[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-366039139 Thanks again for the support; did the proposed changes and also added slash+asterisk comments. The test

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365962934 Something along these lines? ```diff diff --git a/tests/core_tests.py b/tests/core_tests.py

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-366039139 Thanks again for the support; did the proposed changes and also added slash+asterisk comments. The test

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-366039139 Thanks again for the support; did the proposed changes and also added slash+asterisk comments. The test

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365962934 Something along these lines? ``` diff --git a/tests/core_tests.py b/tests/core_tests.py index

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365692257 @xrmx I would appreciate some guidance on what type of test case is requested, e.g. a similar case or

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365383714 The comments are only removed when the table is queried on, i.e. they remain in the table definition.

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365350711 Sorry, I'm kinda new to this, will add a test shortly.