[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884402 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889321 ## File path: superset/assets/javascripts/dashboard/v2/stylesheets/builder.less ## @@ -1,12

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883377 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886743 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884161 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885018 ## File path: superset/assets/javascripts/dashboard/reducers/propShapes.jsx ## @@ -0,0 +1,15

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885141 ## File path: superset/assets/javascripts/dashboard/v2/actions/dashboardLayout.js ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888454 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardComponent.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886001 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872924 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -127,24

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885413 ## File path: superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879856 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877123 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877483 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877948 ## File path: superset/assets/javascripts/dashboard/components/SliceAdderContainer.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880328 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872812 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -87,12

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876462 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881204 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879319 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874993 ## File path: superset/assets/javascripts/dashboard/components/GridLayout.jsx ## @@ -1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879257 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869980 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887080 ## File path: superset/assets/javascripts/dashboard/v2/components/gridComponents/ChartHolder.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883699 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887685 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889672 ## File path: superset/assets/javascripts/dashboard/v2/util/propShapes.jsx ## @@ -19,6 +19,9

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889189 ## File path: superset/assets/javascripts/dashboard/v2/reducers/index.js ## @@ -1,17 +1,10

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180887523 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardComponent.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885543 ## File path: superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889255 ## File path: superset/assets/javascripts/dashboard/v2/reducers/index.js ## @@ -1,17 +1,10

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869813 ## File path: superset/assets/javascripts/dashboard/actions/allSlices.js ## @@ -0,0 +1,66 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881331 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877358 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -1,43

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883555 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180873274 ## File path: superset/assets/javascripts/chart/chartReducer.js ## @@ -6,6 +6,7 @@ import *

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871667 ## File path: superset/assets/javascripts/dashboard/actions/datasources.js ## @@ -0,0 +1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876633 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883909 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883434 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874259 ## File path: superset/assets/javascripts/dashboard/components/DashboardContainer.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180877222 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878276 ## File path: superset/assets/javascripts/dashboard/components/SliceHeader.jsx ## @@ -1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879991 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876866 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886368 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871121 ## File path: superset/assets/javascripts/chart/chartAction.js ## @@ -111,6 +111,17 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r18096 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardHeader.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888627 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardGrid.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874614 ## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ## @@ -4,8 +4,8

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880502 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879055 ## File path: superset/assets/javascripts/dashboard/components/SliceHeaderControls.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875972 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -1,43

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180885735 ## File path: superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180869210 ## File path: superset/assets/javascripts/chart/Chart.jsx ## @@ -5,6 +5,7 @@ import Mustache

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884288 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880670 ## File path: superset/assets/javascripts/dashboard/reducers/allSlices.js ## @@ -0,0 +1,74

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884843 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874909 ## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ## @@ -68,7

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878522 ## File path: superset/assets/javascripts/dashboard/components/SliceHeaderControls.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875495 ## File path: superset/assets/javascripts/dashboard/components/Header.jsx ## @@ -10,37

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881088 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875745 ## File path: superset/assets/javascripts/dashboard/components/SaveModal.jsx ## @@ -12,18

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180874337 ## File path: superset/assets/javascripts/dashboard/components/GridCell.jsx ## @@ -4,8 +4,8

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871341 ## File path: superset/assets/javascripts/dashboard/actions/dashboard.js ## @@ -0,0 +1,166

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878059 ## File path: superset/assets/javascripts/dashboard/components/SliceAdderContainer.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180880942 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180876699 ## File path: superset/assets/javascripts/dashboard/components/SliceAdder.jsx ## @@ -46,174

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180884064 ## File path: superset/assets/javascripts/dashboard/reducers/index.js ## @@ -0,0 +1,116 @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872416 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -3,47

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180883266 ## File path: superset/assets/javascripts/dashboard/reducers/datasources.js ## @@ -0,0 +1,17

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180875082 ## File path: superset/assets/javascripts/dashboard/components/GridLayout.jsx ## @@ -1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180878595 ## File path: superset/assets/javascripts/dashboard/components/SliceHeaderControls.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888327 ## File path: superset/assets/javascripts/dashboard/v2/containers/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180872216 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -3,47

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180879476 ## File path: superset/assets/javascripts/dashboard/index.jsx ## @@ -8,36 +8,17 @@ import {

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180873997 ## File path: superset/assets/javascripts/dashboard/components/DashboardContainer.jsx ## @@

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180881658 ## File path: superset/assets/javascripts/dashboard/reducers/dashboard.js ## @@ -0,0 +1,123

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180873472 ## File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx ## @@ -153,6

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180888117 ## File path: superset/assets/javascripts/dashboard/v2/components/gridComponents/Row.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180886547 ## File path: superset/assets/javascripts/dashboard/v2/components/DashboardBuilder.jsx ##

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180871486 ## File path: superset/assets/javascripts/dashboard/actions/datasources.js ## @@ -0,0 +1,33

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180873197 ## File path: superset/assets/javascripts/chart/chartReducer.js ## @@ -6,6 +6,7 @@ import *

[GitHub] williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard

williaster commented on a change in pull request #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#discussion_r180889852 ## File path: superset/assets/package.json ## @@ -96,6 +95,7 @@ "react-grid-layout":