Re: ClientConnectionDebug question

2010-05-16 Thread Ruwan Linton
Right, metrics != null has nothing to do with this, ideally it should be outside of that block. I will fix it. Thanks, Ruwan On Sun, May 16, 2010 at 1:15 PM, Andreas Veithen wrote: > What about the metrics != null part of the condition? > > Andreas > > On Sun, May 16, 2010 at 03:55, Ruwan Linton

Re: ClientConnectionDebug question

2010-05-16 Thread Andreas Veithen
What about the metrics != null part of the condition? Andreas On Sun, May 16, 2010 at 03:55, Ruwan Linton wrote: > Hi Andreas, > > Although the existing code calls requestCompletionTime unnecessarily even > before the encoder gets completed, it captures the requestCompletionTime > even in error

Re: ClientConnectionDebug question

2010-05-15 Thread Ruwan Linton
Hi Andreas, Although the existing code calls requestCompletionTime unnecessarily even before the encoder gets completed, it captures the requestCompletionTime even in error cases. For example the request transmission not getting completed properly. Basically when ever we write some bytes to the ch

ClientConnectionDebug question

2010-05-15 Thread Andreas Veithen
Could the people who did the ClientConnectionDebug stuff please have a look at the TODO item below. I don't think that the code is executed in the right place. Andreas -- Forwarded message -- From: Date: Sat, May 15, 2010 at 21:15 Subject: svn commit: r944701 - /synapse/trunk/j