[GitHub] [syncope] mmoayyed commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-29 Thread GitBox
mmoayyed commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r417290694 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: Strictly

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416618050 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: ATM in the

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416608586 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: I think

[GitHub] [syncope] mat-ale commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416607578 ## File path: fit/core-reference/pom.xml ## @@ -222,6 +222,30 @@ under the License. bcpkix-jdk15on test + Review comment:

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416606552 ## File path: wa/starter/src/main/java/org/apache/syncope/wa/SyncopeCoreNotReadyException.java ## @@ -0,0 +1,25 @@ +/* Review comment: Is this

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416605070 ## File path: fit/core-reference/pom.xml ## @@ -222,6 +222,30 @@ under the License. bcpkix-jdk15on test + Review comment:

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416604234 ## File path: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/auth/JPASAML2IdPMetadataDAO.java ## @@ -0,0 +1,61 @@ +/* + *

[GitHub] [syncope] ilgrosso commented on a change in pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
ilgrosso commented on a change in pull request #178: URL: https://github.com/apache/syncope/pull/178#discussion_r416602771 ## File path: common/am/lib/src/main/java/org/apache/syncope/common/lib/to/SAML2IdPMetadataTO.java ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] [syncope] mat-ale opened a new pull request #178: [SYNCOPE-1555] Allow WA as SAMLs IdP to fetch metadata over REST

2020-04-28 Thread GitBox
mat-ale opened a new pull request #178: URL: https://github.com/apache/syncope/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] ilgrosso commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
ilgrosso commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619849853 @coheigea done, thx This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [syncope] coheigea commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
coheigea commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619841955 @ilgrosso Done. Can you backmerge it? This is an automated message from the Apache Git Service. To respond

[GitHub] [syncope] ilgrosso commented on pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
ilgrosso commented on pull request #177: URL: https://github.com/apache/syncope/pull/177#issuecomment-619840505 @coheigea Travis CI has passed, AppVeyor is quite unstable; please, go ahead and merge. This is an automated

[GitHub] [syncope] coheigea opened a new pull request #177: Updating Log4j to 2.13.2 due to CVE-2020-9488

2020-04-27 Thread GitBox
coheigea opened a new pull request #177: URL: https://github.com/apache/syncope/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] mmoayyed commented on issue #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-22 Thread GitBox
mmoayyed commented on issue #176: URL: https://github.com/apache/syncope/pull/176#issuecomment-617707225 PS Just a note for public's and archive's sake that the saml stuff likely will be revised shortly to handle mappings better with richer pac4j support.

[GitHub] [syncope] ilgrosso commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
ilgrosso commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411946603 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] mmoayyed commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
mmoayyed commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411943268 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] ilgrosso commented on a change in pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
ilgrosso commented on a change in pull request #176: URL: https://github.com/apache/syncope/pull/176#discussion_r411940454 ## File path: core/am/logic/src/main/java/org/apache/syncope/core/logic/AuthModuleLogic.java ## @@ -60,7 +59,8 @@ public AuthModuleTO update(final

[GitHub] [syncope] mmoayyed opened a new pull request #176: SYNCOPE-1553: Translate AuthModuleConfs to WA

2020-04-21 Thread GitBox
mmoayyed opened a new pull request #176: URL: https://github.com/apache/syncope/pull/176 TODO: - Translate profile item mappings for attributes, etc. - Fix configuration data and tests for AuthModuleITs to not bootstrap the context with invalid state/configuration.

<    4   5   6   7   8   9