Hi Andrei,
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since
containing methods have little to nothing to do with authentication.
It is only about Entitlements...
+1 for Entitlement, -1 for Service. I would keep names consistently, if use
Btw. I would rather name the xml element Entitlement than EntitlementTO
as the fact that it is a transfer object is not important on the xml level.
I agree. Not using *TO ending would look nicer on transport layer.
The question here is, should we also remove TO in Classnames, or just set a
I would rather do it in the annotations. Internally we often have a
internal class without TO and a transfer object that ends in TO.
So I think it makes sense to differentiate them on the class level.
Christian
On 18.01.2013 09:51, Jan Bernhardt wrote:
Btw. I would rather name the xml element
Names will be Consistent. New CXF REST Services will all End with *Service.
Old Spring Services currently ending with *Controller will eventually all
vanish, once new Services are actually used (migration is complete).
Than is absolutely OK for me. + 1.
Andrei.
Best regards.
Jan
Hi Syncoper,
The following changes are proposed regarding AuthenticationController:
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since containing
methods have little to nothing to do with authentication. It is only about
Entitlements...
=== Changing
:04
To: dev@syncope.apache.org
Subject: RE: [Discussion] New REST Service Interfaces - Entitlements
Hi Syncoper,
The following changes are proposed regarding AuthenticationController:
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since
containing
Il giorno 17/gen/2013, alle ore 14.03, Jan Bernhardt ha scritto:
Hi Syncoper,
The following changes are proposed regarding AuthenticationController:
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since containing
methods have little to nothing to
Hi Jan,
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since
containing methods have little to nothing to do with authentication. It is
only
about Entitlements...
+1 for Entitlement, -1 for Service. I would keep names consistently, if use
On 17.01.2013 14:43, Fabio Martelli wrote:
Il giorno 17/gen/2013, alle ore 14.03, Jan Bernhardt ha scritto:
Hi Syncoper,
The following changes are proposed regarding AuthenticationController:
=== Renaming Service ===
Rename AuthenticationController to EntitlementService(Impl), since