Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100663
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181103559
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181089858
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181093676
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181093708
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181096467
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181097338
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100023
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181100854
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181102107
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181103181
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181086944
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181088154
--- Diff:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
@@ -135,11 +135,7
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181087678
--- Diff:
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java
---
@@ -34,6 +34,8
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181087221
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java
---
@@ -115,6 +115,16 @@ public
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/70#discussion_r181088731
--- Diff:
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java
---
@@ -44,7 +44,7 @@
@Temporal
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
I would stick with minimal changes, so this PR should only change
`JPAAccessToken`.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
Ok so...
> Are you simply proposing to add such constraint and leave the rest of the
code as is?
e.g. to change again this PR by reverting all changes and adding the UNIQUE
constraint?
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
> That way replace won't work since it saves first (2 tokens exist.violate
UNIQUE constraint) and deletes next. That way it will only delete the existing
one which results in no token at
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera the point is that the existence of `replaceFlag` (I did not
realize that at first) is what prevents to enforce the UNIQUE constraint.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera I don't remember the details, but what I can see from the
source three is that `AccessTokenDataBinderImpl#create` is invoked in two
places:
1.
https://github.com/apache
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
Ok, let's try this way: please re-introduce the UNIQUE constraint but
rework the whole `AccessTokenDataBinderImpl#create` to comply with the two
invocation scenarios as reported above.
Do
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/70
@IsurangaPerera the only effect of UNIQUE constraint will be that a
validation error is raised whenever a second AccessToken is created with same
owner of an existing one.
Are you simply
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/71
@loredicola please open an issue on JIRA about the fixes you are proposing
with this PR.
Besides the comment I've added, the rest looks good.
Please revert the aforementioned changes
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/71#discussion_r183312735
--- Diff:
client/cli/src/main/java/org/apache/syncope/client/cli/commands/migrate/MigrateConf.java
---
@@ -731,18 +752,18 @@ private static void exec
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/71#discussion_r183326763
--- Diff:
client/cli/src/main/java/org/apache/syncope/client/cli/commands/migrate/MigrateConf.java
---
@@ -864,9 +885,6 @@ private static void exec(final
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/71
SYNCOPE-303 was created to support this PR.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/71
Thx @loredicola I've merged this PR
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/61
@clucgdc are you still interested? If not, please close this PR as I don't
have karma to do that.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/79
I have seen:
* you opened SYNCOPE-1328 for this PR
* your new commit, which fixes the build
Could you please squash your two commits into one, preserving the text
`SYNCOPE-1328
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
Thanks for your contribution: see it on-line at
https://ci.apache.org/projects/syncope/2_1_X/getting-started.html#kubernetes-sample
As you can see, I did some minor editing and reflow.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/84
That call is *not* redundant, it is invoking the `after()` method with any
defined push actions.
Please close this PR.
---
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/85
@AlexTsvetkov I have reviewed the code in `DefaultRealmPullResultHandler`
and found that you were right about removing the additional `after()` calls -
as proposed in #84 .
This because
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/83
ping @mornindew
---
301 - 334 of 334 matches
Mail list logo
