[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-16 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/68


---

[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-13 Thread ilgrosso 
Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/68#discussion_r174045249
  
--- Diff: ide/netbeans/pom.xml ---
@@ -133,7 +133,6 @@ under the License.
   false
 
   
-  
--- End diff --

Any reason to remove this line?


---

[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-13 Thread rohanjulka19 
Github user rohanjulka19 commented on a diff in the pull request:

https://github.com/apache/syncope/pull/68#discussion_r174041172
  
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
 
   
 
-  
+
--- End diff --

ok


---

[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-13 Thread ilgrosso 
Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/68#discussion_r174040731
  
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
 
   
 
-  
+
--- End diff --

No need to open a new PR, just revert this sole change and make a new 
commit: it will be added to this PR.
Once the review is finished, you might be asked to squash all the commits, 
but for the moment it will work like this.


---

[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-13 Thread rohanjulka19 
Github user rohanjulka19 commented on a diff in the pull request:

https://github.com/apache/syncope/pull/68#discussion_r174040384
  
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
 
   
 
-  
+
--- End diff --

yes ok I won't sorry for causing the trouble should I fix it and open the 
pr again  .  


---

[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin

2018-03-13 Thread ilgrosso 
Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/68#discussion_r173764200
  
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
 
   
 
-  
+
--- End diff --

Please do not change indentation.


---