[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266813#comment-15266813 ] ASF GitHub Bot commented on SYNCOPE-798: Github user mteo closed the pull request at: https://github.com/apache/syncope/pull/13 > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266804#comment-15266804 ] ASF subversion and git services commented on SYNCOPE-798: - Commit edb0cb33d4ca6ac6b993dfc2f8ee536752f17e02 in syncope's branch refs/heads/master from [~mdicarlo] [ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=edb0cb3 ] SYNCOPE-798 now cancel does logout plus refactoring authorization > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266800#comment-15266800 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216268832 LGTM @mteo I'll go ahead and merge, thanks! > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266762#comment-15266762 ] ASF GitHub Bot commented on SYNCOPE-798: Github user mteo commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216263417 Hi @ilgrosso, I made the changes. Thanks for the review. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266589#comment-15266589 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216232120 Hi @mteo thanks for your PR! There are few minor comments of mine: once fixed, I'll be happy to merge it. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266583#comment-15266583 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736403 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266580#comment-15266580 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736317 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266575#comment-15266575 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736265 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266578#comment-15266578 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736304 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266577#comment-15266577 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736292 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266576#comment-15266576 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736276 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', +'ui.bootstrap', +'ui.select', +'ngSanitize', +'ngAnimate', +'ngResource', +'ngCookies', +'treasure-overlay-spinner', +'ngPasswordStrength', +'kendo.directives', +'home', +'login', +'language', +'self', +'info' ]); app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider', - function ($stateProvider, $urlRouterProvider, $httpProvider) { -// route configuration -$stateProvider -.state('home', { - url: '/', - templateUrl: 'views/self.html' -}) -.state('self', { - url: '/self', - templateUrl: 'views/self.html' -}) -.state('user-self-update', { - url: '/user-self-update', - templateUrl: 'views/home.html', - controller: 'HomeController', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('create', { - url: '/self/create', - templateUrl: 'views/editUser.html' -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/create) -.state('create.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html' -}) -.state('create.groups', { - url: '/groups', - templateUrl: 'views/user-groups.html' -}) -.state('create.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html' -}) -.state('create.derivedSchemas', { - url: '/derivedSchemas', - templateUrl: 'views/user-derived-schemas.html' -}) -.state('create.virtualSchemas', { - url: '/virtualSchemas', - templateUrl: 'views/user-virtual-schemas.html' -}) -.state('create.resources', { - url: '/resources', - templateUrl: 'views/user-resources.html' -}) -.state('create.finish', { - url: '/finish', - templateUrl: 'views/user-form-finish.html' -}) -.state('update', { - url: '/self/update', - templateUrl: 'views/editUser.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -// nested states -// each of these sections will have their own view -// url will be nested (/self/update) -.state('update.credentials', { - url: '/credentials', - templateUrl: 'views/user-credentials.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -}) -.state('update.plainSchemas', { - url: '/plainSchemas', - templateUrl: 'views/user-plain-schemas.html', - resolve: { -'authenticated': function (AuthenticationHelper) { - return AuthenticationHelper.authenticated(); -} - } -
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266572#comment-15266572 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61736063 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -27,394 +29,409 @@ angular.module('info', []); // Declare app level module which depends on views, and components var app = angular.module('SyncopeEnduserApp', [ - 'ui.router', - 'ui.bootstrap', - 'ui.select', - 'ngSanitize', - 'ngAnimate', - 'ngResource', - 'ngCookies', - 'treasure-overlay-spinner', - 'ngPasswordStrength', - 'kendo.directives', - 'home', - 'login', - 'language', - 'self', - 'info' +'ui.router', --- End diff -- Please avoid this formatting-only modifications, they make harder to recognize actual changes. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266569#comment-15266569 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61735968 --- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/app.js --- @@ -1,3 +1,5 @@ +/* global $http, AuthService */ --- End diff -- Is this required? If not, please remove; otherwise move it past the license header. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266566#comment-15266566 ] ASF GitHub Bot commented on SYNCOPE-798: Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/13#discussion_r61735681 --- Diff: client/enduser/src/main/java/org/apache/syncope/client/enduser/SyncopeEnduserApplication.java --- @@ -154,6 +155,16 @@ public IResource getResource() { return new LogoutResource(); } }); + +mountResource("/api/self/islogged", new ResourceReference("userAuthentication") { + +private static final long serialVersionUID = -128426276529456602L; + +@Override +public IResource getResource() { +return new UserAuthentication(); --- End diff -- Please rename `UserAuthentication` according to its mount point. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266552#comment-15266552 ] ASF GitHub Bot commented on SYNCOPE-798: Github user mteo commented on the pull request: https://github.com/apache/syncope/pull/13#issuecomment-216227329 Pr is completed, now you can take a look. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257865#comment-15257865 ] Francesco Chicchiriccò commented on SYNCOPE-798: Hi [~mdicarlo] your PR looks fine: please [submit your ICLA|http://www.apache.org/licenses/#clas] so I can accept, merge and close your PR. > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò >Assignee: Matteo Di Carlo > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere
[ https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257853#comment-15257853 ] ASF GitHub Bot commented on SYNCOPE-798: GitHub user mteo opened a pull request: https://github.com/apache/syncope/pull/13 SYNCOPE-798 now cancel does logout You can merge this pull request into a Git repository by running: $ git pull https://github.com/mteo/syncope SYNCOPE-798 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/syncope/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit c6c88bd56038c2a21e3b0d22aeac4a6104e8f280 Author: Matteo Di CarloDate: 2016-04-26T10:17:55Z SYNCOPE-798 now cancel does logout > Once authenticated to enduser, "Cancel" brings nowhere > --- > > Key: SYNCOPE-798 > URL: https://issues.apache.org/jira/browse/SYNCOPE-798 > Project: Syncope > Issue Type: Bug > Components: enduser >Affects Versions: 2.0.0-M2 >Reporter: Francesco Chicchiriccò > Fix For: 2.0.0 > > Attachments: pointless page.png > > > How to reproduce: > # log into enduser > # hit the red button Cancel on the bottom > # you are redirected to an empty page (see screenshot attached) > Cancel should be equivalent to Logout (so it is really needed? The logout > button is already there). > Incidentally, the same pointless page is returned when accessing > /syncope-enduser if authenticated - which looks wrong, the excepted landing > page should be first one, e.g. "crendentials". -- This message was sent by Atlassian JIRA (v6.3.4#6332)